diff mbox

[committed] PR 63410: Fix missing plugin headers

Message ID 1412091938.16438.65.camel@surprise
State New
Headers show

Commit Message

David Malcolm Sept. 30, 2014, 3:45 p.m. UTC 
We install the header "pass_manager.h", but it can't be included by a
plugin, since it includes "pass-instances.def", and we don't current
install that.

Similarly, the installed header pretty-print.h now uses
wide-int-print.h, but the latter isn't installed.

FWIW, both of these issues prevent building gcc-python-plugin.

Fixed by the attached patch. 

Bootstrapped on x86_64-unknown-linux (Fedora 20), verified that "make
install" installs the previously-missing files.

Committed to trunk as obvious, as r215727.

The missing pass-instances.def also affects the 4.9 branch (and is
currently blocking gcc-python-plugin for gcc 4.9); I'll fix it on that
branch after bootstrapping (without the wide-int part).

Comments

Mike Stump Sept. 30, 2014, 7:24 p.m. UTC | #1 
On Sep 30, 2014, at 8:45 AM, David Malcolm <dmalcolm@redhat.com> wrote:
> We install the header "pass_manager.h", but it can't be included by a
> plugin, since it includes "pass-instances.def", and we don't current
> install that.
> 
> Similarly, the installed header pretty-print.h now uses
> wide-int-print.h, but the latter isn't installed.

So, installing wide-int-print.h seems reasonable.
diff mbox

Patch

Index: gcc/ChangeLog
===================================================================
--- gcc/ChangeLog	(revision 215726)
+++ gcc/ChangeLog	(revision 215727)
@@ -1,3 +1,9 @@ 
+2014-09-30  David Malcolm  <dmalcolm@redhat.com>
+
+	PR plugins/63410
+	* Makefile.in (PRETTY_PRINT_H): Add wide-int-print.h.
+	(PLUGIN_HEADERS): Add pass-instances.def.
+
 2014-09-30  James Greenhalgh  <james.greenhalgh@arm.com>
 
 	* config/aarch64/aarch64-simd-builtins.def (sqdmull_laneq): Expand
Index: gcc/Makefile.in
===================================================================
--- gcc/Makefile.in	(revision 215726)
+++ gcc/Makefile.in	(revision 215727)
@@ -916,7 +916,7 @@ 
 		$(BITMAP_H) sbitmap.h $(BASIC_BLOCK_H) $(GIMPLE_H) \
 		$(HASHTAB_H) $(CGRAPH_H) $(IPA_REFERENCE_H) \
 		tree-ssa-alias.h
-PRETTY_PRINT_H = pretty-print.h $(INPUT_H) $(OBSTACK_H)
+PRETTY_PRINT_H = pretty-print.h $(INPUT_H) $(OBSTACK_H) wide-int-print.h
 TREE_PRETTY_PRINT_H = tree-pretty-print.h $(PRETTY_PRINT_H)
 GIMPLE_PRETTY_PRINT_H = gimple-pretty-print.h $(TREE_PRETTY_PRINT_H)
 DIAGNOSTIC_CORE_H = diagnostic-core.h $(INPUT_H) bversion.h diagnostic.def
@@ -3148,7 +3148,7 @@ 
   tree-ssa-loop.h tree-ssa-loop-ivopts.h tree-ssa-loop-manip.h \
   tree-ssa-loop-niter.h tree-ssa-ter.h tree-ssa-threadedge.h \
   tree-ssa-threadupdate.h inchash.h wide-int.h signop.h hash-map.h \
-  hash-set.h
+  hash-set.h pass-instances.def
 
 # generate the 'build fragment' b-header-vars
 s-header-vars: Makefile