| Message ID | 1410961052-32402-1-git-send-email-sebastian.huber@embedded-brains.de |
|---|---|
| State | New |
| Headers | show |
On Wed, 2014-09-17 15:37:32 +0200, Sebastian Huber <sebastian.huber@embedded-brains.de> wrote: > contrib/ChangeLog > 2014-09-17 Sebastian Huber <sebastian.huber@embedded-brains.de> > > * config-list.mk (LIST): Add arm-rtems. > Add nios2-rtems. Remove extra option from powerpc-rtems. What's the rationale for removing --enable-threads=yes here, as well as the specific version number? Don't get me wrong: I don't question this change, though it's not obvious to me; I'd probably just add powerpc-rtems additionally? MfG, JBG
Is there anyone else from GCC who needs to approve this? As RTEMS maintainer for GCC, I am ok with it. --joel On 9/17/2014 8:37 AM, Sebastian Huber wrote: > contrib/ChangeLog > 2014-09-17 Sebastian Huber <sebastian.huber@embedded-brains.de> > > * config-list.mk (LIST): Add arm-rtems. > Add nios2-rtems. Remove extra option from powerpc-rtems. > --- > contrib/config-list.mk | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/contrib/config-list.mk b/contrib/config-list.mk > index 4345487..056fbf0 100644 > --- a/contrib/config-list.mk > +++ b/contrib/config-list.mk > @@ -17,7 +17,7 @@ LIST = aarch64-elf aarch64-linux-gnu \ > arc-elf32OPT-with-cpu=arc600 arc-elf32OPT-with-cpu=arc700 \ > arc-linux-uclibcOPT-with-cpu=arc700 arceb-linux-uclibcOPT-with-cpu=arc700 \ > arm-wrs-vxworks arm-netbsdelf \ > - arm-linux-androideabi arm-uclinux_eabi arm-eabi \ > + arm-linux-androideabi arm-uclinux_eabi arm-eabi arm-rtems \ > arm-symbianelf avr-rtems avr-elf \ > bfin-elf bfin-uclinux bfin-linux-uclibc bfin-rtems bfin-openbsd \ > c6x-elf c6x-uclinux cr16-elf cris-elf cris-linux crisv32-elf crisv32-linux \ > @@ -48,13 +48,13 @@ LIST = aarch64-elf aarch64-linux-gnu \ > moxie-uclinux moxie-rtems \ > msp430-elf \ > nds32le-elf nds32be-elf \ > - nios2-elf nios2-linux-gnu \ > + nios2-elf nios2-linux-gnu nios2-rtems \ > pdp11-aout picochip-elfOPT-enable-obsolete \ > powerpc-darwin8 \ > powerpc-darwin7 powerpc64-darwin powerpc-freebsd6 powerpc-netbsd \ > powerpc-eabispe powerpc-eabisimaltivec powerpc-eabisim ppc-elf \ > powerpc-eabialtivec powerpc-xilinx-eabi powerpc-eabi \ > - powerpc-rtems4.11OPT-enable-threads=yes powerpc-linux_spe \ > + powerpc-rtems powerpc-linux_spe \ > powerpc-linux_paired powerpc64-linux_altivec \ > powerpc-wrs-vxworks powerpc-wrs-vxworksae powerpc-lynxos powerpcle-elf \ > powerpcle-eabisim powerpcle-eabi rs6000-ibm-aix4.3 rs6000-ibm-aix5.1.0 \
On 09/17/2014 04:45 PM, Jan-Benedict Glaw wrote: > On Wed, 2014-09-17 15:37:32 +0200, Sebastian Huber<sebastian.huber@embedded-brains.de> wrote: >> >contrib/ChangeLog >> >2014-09-17 Sebastian Huber<sebastian.huber@embedded-brains.de> >> > >> > * config-list.mk (LIST): Add arm-rtems. >> > Add nios2-rtems. Remove extra option from powerpc-rtems. > What's the rationale for removing --enable-threads=yes here, as well > as the specific version number? The version number can be arbitrary. All the other RTEMS targets in this list omit it. The --enable-threads=yes is not specific to PowerPC for RTEMS. So all RTEMS targets should have it or none. With a recent commit this option is superfluous.
On 9/17/2014 10:41 AM, Sebastian Huber wrote: > On 09/17/2014 04:45 PM, Jan-Benedict Glaw wrote: >> On Wed, 2014-09-17 15:37:32 +0200, Sebastian Huber<sebastian.huber@embedded-brains.de> wrote: >>>> contrib/ChangeLog >>>> 2014-09-17 Sebastian Huber<sebastian.huber@embedded-brains.de> >>>> >>>> * config-list.mk (LIST): Add arm-rtems. >>>> Add nios2-rtems. Remove extra option from powerpc-rtems. >> What's the rationale for removing --enable-threads=yes here, as well >> as the specific version number? > The version number can be arbitrary. All the other RTEMS targets in > this list omit it. > > The --enable-threads=yes is not specific to PowerPC for RTEMS. So all > RTEMS targets should have it or none. With a recent commit this option > is superfluous. > I was noticing that at least the v850 is not represented by any target. Other than that, it looks like all the RTEMS targets except that the or1k (which is not in the FSF tree yet) are included. I didn't review against the list of *-elf targets though. What is the rationale for inclusion on the list? Should v850-elf and v850-rtems also be added? And is this the input to your buildbot? :)
On 09/17/14 09:10, Joel Sherrill wrote: > Is there anyone else from GCC who needs to approve this? I think you're OK is all we need here. > > As RTEMS maintainer for GCC, I am ok with it. Then it's good to go :-) Thanks, jeff
On Wed, 2014-09-17 10:52:34 -0500, Joel Sherrill <joel.sherrill@oarcorp.com> wrote: > On 9/17/2014 10:41 AM, Sebastian Huber wrote: > > On 09/17/2014 04:45 PM, Jan-Benedict Glaw wrote: > > > On Wed, 2014-09-17 15:37:32 +0200, Sebastian Huber<sebastian.huber@embedded-brains.de> wrote: > > > > > contrib/ChangeLog > > > > > 2014-09-17 Sebastian Huber<sebastian.huber@embedded-brains.de> > > > > > > > > > > * config-list.mk (LIST): Add arm-rtems. > > > > > Add nios2-rtems. Remove extra option from powerpc-rtems. > > > What's the rationale for removing --enable-threads=yes here, as well > > > as the specific version number? [...] > And is this the input to your buildbot? :) Yes, the target list in contrib/config-list.mk is what'll be built using the config-list.mk-building backend. (The robot has another backend using a different build strategy, which has a separate target list, though one could argue that I'd also include all the config-list.mk targets in that other list as well.) And to tell the whole story, Sebastian approached me with extending the target lists in use by those targets he sent a patch for; I just asked him to go this route, because I guess that'd be beneficial for other folks as well. MfG, JBG
I committed this to 4.9 and head. Sebastian.. please double check that it is OK please. I had some issues with applying it to the head and manually did it. --joel On 9/17/2014 8:37 AM, Sebastian Huber wrote: > contrib/ChangeLog > 2014-09-17 Sebastian Huber <sebastian.huber@embedded-brains.de> > > * config-list.mk (LIST): Add arm-rtems. > Add nios2-rtems. Remove extra option from powerpc-rtems. > --- > contrib/config-list.mk | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/contrib/config-list.mk b/contrib/config-list.mk > index 4345487..056fbf0 100644 > --- a/contrib/config-list.mk > +++ b/contrib/config-list.mk > @@ -17,7 +17,7 @@ LIST = aarch64-elf aarch64-linux-gnu \ > arc-elf32OPT-with-cpu=arc600 arc-elf32OPT-with-cpu=arc700 \ > arc-linux-uclibcOPT-with-cpu=arc700 arceb-linux-uclibcOPT-with-cpu=arc700 \ > arm-wrs-vxworks arm-netbsdelf \ > - arm-linux-androideabi arm-uclinux_eabi arm-eabi \ > + arm-linux-androideabi arm-uclinux_eabi arm-eabi arm-rtems \ > arm-symbianelf avr-rtems avr-elf \ > bfin-elf bfin-uclinux bfin-linux-uclibc bfin-rtems bfin-openbsd \ > c6x-elf c6x-uclinux cr16-elf cris-elf cris-linux crisv32-elf crisv32-linux \ > @@ -48,13 +48,13 @@ LIST = aarch64-elf aarch64-linux-gnu \ > moxie-uclinux moxie-rtems \ > msp430-elf \ > nds32le-elf nds32be-elf \ > - nios2-elf nios2-linux-gnu \ > + nios2-elf nios2-linux-gnu nios2-rtems \ > pdp11-aout picochip-elfOPT-enable-obsolete \ > powerpc-darwin8 \ > powerpc-darwin7 powerpc64-darwin powerpc-freebsd6 powerpc-netbsd \ > powerpc-eabispe powerpc-eabisimaltivec powerpc-eabisim ppc-elf \ > powerpc-eabialtivec powerpc-xilinx-eabi powerpc-eabi \ > - powerpc-rtems4.11OPT-enable-threads=yes powerpc-linux_spe \ > + powerpc-rtems powerpc-linux_spe \ > powerpc-linux_paired powerpc64-linux_altivec \ > powerpc-wrs-vxworks powerpc-wrs-vxworksae powerpc-lynxos powerpcle-elf \ > powerpcle-eabisim powerpcle-eabi rs6000-ibm-aix4.3 rs6000-ibm-aix5.1.0 \
On 9/18/2014 6:51 AM, Jan-Benedict Glaw wrote: > On Wed, 2014-09-17 10:52:34 -0500, Joel Sherrill <joel.sherrill@oarcorp.com> wrote: >> On 9/17/2014 10:41 AM, Sebastian Huber wrote: >>> On 09/17/2014 04:45 PM, Jan-Benedict Glaw wrote: >>>> On Wed, 2014-09-17 15:37:32 +0200, Sebastian Huber<sebastian.huber@embedded-brains.de> wrote: >>>>>> contrib/ChangeLog >>>>>> 2014-09-17 Sebastian Huber<sebastian.huber@embedded-brains.de> >>>>>> >>>>>> * config-list.mk (LIST): Add arm-rtems. >>>>>> Add nios2-rtems. Remove extra option from powerpc-rtems. >>>> What's the rationale for removing --enable-threads=yes here, as well >>>> as the specific version number? > [...] >> And is this the input to your buildbot? :) > Yes, the target list in contrib/config-list.mk is what'll be built > using the config-list.mk-building backend. (The robot has another > backend using a different build strategy, which has a separate target > list, though one could argue that I'd also include all the > config-list.mk targets in that other list as well.) > > And to tell the whole story, Sebastian approached me with extending > the target lists in use by those targets he sent a patch for; I just > asked him to go this route, because I guess that'd be beneficial for > other folks as well. OK. Thanks for clarifying that. I suspected there was a link. And it is committed. And I will post a follow up patch to add v850-elf and v850-rtems. --joel > MfG, JBG >
On 9/18/2014 6:51 AM, Jan-Benedict Glaw wrote: > On Wed, 2014-09-17 10:52:34 -0500, Joel Sherrill <joel.sherrill@oarcorp.com> wrote: >> On 9/17/2014 10:41 AM, Sebastian Huber wrote: >>> On 09/17/2014 04:45 PM, Jan-Benedict Glaw wrote: >>>> On Wed, 2014-09-17 15:37:32 +0200, Sebastian Huber<sebastian.huber@embedded-brains.de> wrote: >>>>>> contrib/ChangeLog >>>>>> 2014-09-17 Sebastian Huber<sebastian.huber@embedded-brains.de> >>>>>> >>>>>> * config-list.mk (LIST): Add arm-rtems. >>>>>> Add nios2-rtems. Remove extra option from powerpc-rtems. >>>> What's the rationale for removing --enable-threads=yes here, as well >>>> as the specific version number? > [...] >> And is this the input to your buildbot? :) > Yes, the target list in contrib/config-list.mk is what'll be built > using the config-list.mk-building backend. (The robot has another > backend using a different build strategy, which has a separate target > list, though one could argue that I'd also include all the > config-list.mk targets in that other list as well.) > > And to tell the whole story, Sebastian approached me with extending > the target lists in use by those targets he sent a patch for; I just > asked him to go this route, because I guess that'd be beneficial for > other folks as well. I only see one RTEMS target that has been built in the top page. Are more than the powerpc-rtems being built? How can I check? Thanks. > MfG, JBG >
On Thu, 2014-09-18 10:27:46 -0500, Joel Sherrill <joel.sherrill@oarcorp.com> wrote: > On 9/18/2014 6:51 AM, Jan-Benedict Glaw wrote: > > And to tell the whole story, Sebastian approached me with > > extending the target lists in use by those targets he sent a patch > > for; I just asked him to go this route, because I guess that'd be > > beneficial for other folks as well. > OK. Thanks for clarifying that. I suspected there was a link. > > And it is committed. And I will post a follow up patch to > add v850-elf and v850-rtems. Highly welcome :) MfG, JBG
On Thu, 2014-09-18 16:55:35 -0500, Joel Sherrill <joel.sherrill@oarcorp.com> wrote: > I only see one RTEMS target that has been built in the top page. > Are more than the powerpc-rtems being built? How can I check? The builders work down their list, and when done will start a new round (with a list that would now contain the three new targets.) Though they're still working down their "old" list; I've just added the targets there as well, they should show up soonish on one of the *-configlist_mk* builders. MfG, JBG
On Fri, 2014-09-19 22:26:59 +0200, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote: > On Thu, 2014-09-18 16:55:35 -0500, Joel Sherrill <joel.sherrill@oarcorp.com> wrote: > > I only see one RTEMS target that has been built in the top page. > > Are more than the powerpc-rtems being built? How can I check? > > The builders work down their list, and when done will start a new > round (with a list that would now contain the three new targets.) > Though they're still working down their "old" list; I've just added > the targets there as well, they should show up soonish on one of the > *-configlist_mk* builders. Here we are: arm-rtems was successfully built http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=355716 powerpc-rtems was successfully built http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=355861 nios2-rtems failed to build http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=355729 Please note that nios2 failed in the same way a number of other targets fail, too: cr16-elf http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=351532 fr30-elf http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=348510 lm32-elf http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=352224 microblaze-elf http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=347412 moxie-elf http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=355056 rl78-elf http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=355368 The build error always looks like this (I should have opened a PR for that already, but didn't): [...] g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common -DHAVE_CONFIG_H -I. -I. -I../../../gcc/gcc -I../../../gcc/gcc/. -I../../../gcc/gcc/../include -I../../../gcc/gcc/../libcpp/include -I/opt/cfarm/mpc/include -I../../../gcc/gcc/../libdecnumber -I../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../gcc/gcc/../libbacktrace -o reload1.o -MT reload1.o -MMD -MP -MF ./.deps/reload1.TPo ../../../gcc/gcc/reload1.c ../../../gcc/gcc/reload1.c: In function ‘void elimination_costs_in_insn(rtx_insn*)’: ../../../gcc/gcc/reload1.c:3762:41: error: ‘orig_dup[0]’ may be used uninitialized in this function [-Werror=maybe-uninitialized] *recog_data.dup_loc[i] = orig_dup[i]; ^ cc1plus: all warnings being treated as errors make[2]: *** [reload1.o] Error 1 (All config-list.mk builds are done with a compiler of the very same revision number.) MfG, JBG
On Sat, 20 Sep 2014, Jan-Benedict Glaw wrote: > Please note that nios2 failed in the same way a number of other > targets fail, too: > > cr16-elf > http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=351532 > fr30-elf > http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=348510 > lm32-elf > http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=352224 > microblaze-elf > http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=347412 > moxie-elf > http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=355056 > rl78-elf > http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=355368 > > The build error always looks like this (I should have opened a PR for > that already, but didn't): > > [...] > g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common -DHAVE_CONFIG_H -I. -I. -I../../../gcc/gcc -I../../../gcc/gcc/. -I../../../gcc/gcc/../include -I../../../gcc/gcc/../libcpp/include -I/opt/cfarm/mpc/include -I../../../gcc/gcc/../libdecnumber -I../../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../../gcc/gcc/../libbacktrace -o reload1.o -MT reload1.o -MMD -MP -MF ./.deps/reload1.TPo ../../../gcc/gcc/reload1.c > ../../../gcc/gcc/reload1.c: In function ?void elimination_costs_in_insn(rtx_insn*)?: > ../../../gcc/gcc/reload1.c:3762:41: error: ?orig_dup[0]? may be used uninitialized in this function [-Werror=maybe-uninitialized] > *recog_data.dup_loc[i] = orig_dup[i]; Joern, who wrote config-list.mk, has most if not all of them covered already. This is PR55035. brgds, H-P
diff --git a/contrib/config-list.mk b/contrib/config-list.mk index 4345487..056fbf0 100644 --- a/contrib/config-list.mk +++ b/contrib/config-list.mk @@ -17,7 +17,7 @@ LIST = aarch64-elf aarch64-linux-gnu \ arc-elf32OPT-with-cpu=arc600 arc-elf32OPT-with-cpu=arc700 \ arc-linux-uclibcOPT-with-cpu=arc700 arceb-linux-uclibcOPT-with-cpu=arc700 \ arm-wrs-vxworks arm-netbsdelf \ - arm-linux-androideabi arm-uclinux_eabi arm-eabi \ + arm-linux-androideabi arm-uclinux_eabi arm-eabi arm-rtems \ arm-symbianelf avr-rtems avr-elf \ bfin-elf bfin-uclinux bfin-linux-uclibc bfin-rtems bfin-openbsd \ c6x-elf c6x-uclinux cr16-elf cris-elf cris-linux crisv32-elf crisv32-linux \ @@ -48,13 +48,13 @@ LIST = aarch64-elf aarch64-linux-gnu \ moxie-uclinux moxie-rtems \ msp430-elf \ nds32le-elf nds32be-elf \ - nios2-elf nios2-linux-gnu \ + nios2-elf nios2-linux-gnu nios2-rtems \ pdp11-aout picochip-elfOPT-enable-obsolete \ powerpc-darwin8 \ powerpc-darwin7 powerpc64-darwin powerpc-freebsd6 powerpc-netbsd \ powerpc-eabispe powerpc-eabisimaltivec powerpc-eabisim ppc-elf \ powerpc-eabialtivec powerpc-xilinx-eabi powerpc-eabi \ - powerpc-rtems4.11OPT-enable-threads=yes powerpc-linux_spe \ + powerpc-rtems powerpc-linux_spe \ powerpc-linux_paired powerpc64-linux_altivec \ powerpc-wrs-vxworks powerpc-wrs-vxworksae powerpc-lynxos powerpcle-elf \ powerpcle-eabisim powerpcle-eabi rs6000-ibm-aix4.3 rs6000-ibm-aix5.1.0 \