| Message ID | 1407853881-11152-1-git-send-email-joel.sherrill@oarcorp.com |
|---|---|
| State | New |
| Headers | show |
> This didn't get any comments earlier. Is it OK to comment? This one is a bit tricky so requires more thoughts. On which targets did you test it? > Somewhere along the way, the Ada run-time Makefile's quit > honoring CFLAGS_FOR_TARGET. This just adds it back. > > 2014-08-12 Joel Sherrill <joel.sherrill@oarcorp.com> > > * Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C. I guess this is OK on principle, but if someone reports an issue with this patch, we might need to revert it. Arno
On 8/12/2014 12:33 PM, Arnaud Charlet wrote: >> This didn't get any comments earlier. Is it OK to comment? > This one is a bit tricky so requires more thoughts. On which targets did > you test it? native CentOS and sparc-rtems4.11. I don't have access to much else except *-rtems* which is basically the same thing with different backend gcc issues. The build needs a way to see the RTEMS network .h files since they are not installed with the libc files. libc/gcc .h files are part of the normal GNU toolset. The others are part of the BSP install. >> Somewhere along the way, the Ada run-time Makefile's quit >> honoring CFLAGS_FOR_TARGET. This just adds it back. >> >> 2014-08-12 Joel Sherrill <joel.sherrill@oarcorp.com> >> >> * Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C. > I guess this is OK on principle, but if someone reports an issue with this > patch, we might need to revert it. It was in the rts Makefile back when it was under gcc. I suspect it disappeared when this all moved to libada. Could check the history if we need to. > Arno
> It was in the rts Makefile back when it was under gcc. I suspect it > disappeared when this > all moved to libada. Could check the history if we need to. Well, libada has been introduced many many years ago. Are you saying you haven't built Ada since then, or were using local patches? Arno
On 8/12/2014 2:22 PM, Arnaud Charlet wrote: >> It was in the rts Makefile back when it was under gcc. I suspect it >> disappeared when this >> all moved to libada. Could check the history if we need to. > Well, libada has been introduced many many years ago. Are you saying you > haven't built Ada since then, or were using local patches? I don't know when I last built it but it has been broken for a while and I didn't get a chance to track it down and submit patches. I have had local patches but didn't like them. Ada is just a volunteer activity at this point for me. If AdaCore would like to include one RTEMS target in your automated testing, that would help. > Arno
> I don't know when I last built it but it has been broken for a while and > I didn't get a chance to track it down and submit patches. OK well as I said, as long as your change doesn't break other targets, that's OK. > I have had local patches but didn't like them. Ada is just a volunteer > activity at this > point for me. If AdaCore would like to include one RTEMS target in your > automated testing, that would help. Thanks, but no thanks :-) Arno
diff --git a/libada/Makefile.in b/libada/Makefile.in index c307b99..93da740 100644 --- a/libada/Makefile.in +++ b/libada/Makefile.in @@ -60,7 +60,7 @@ CFLAGS=-g PICFLAG = @PICFLAG@ GNATLIBFLAGS= -W -Wall -gnatpg -nostdinc GNATLIBCFLAGS= -g -O2 -GNATLIBCFLAGS_FOR_C = -W -Wall $(GNATLIBCFLAGS) \ +GNATLIBCFLAGS_FOR_C = -W -Wall $(GNATLIBCFLAGS) $(CFLAGS_FOR_TARGET) \ -fexceptions -DIN_RTS @have_getipinfo@ host_subdir = @host_subdir@