| Message ID | 1407345815-14551-40-git-send-email-dmalcolm@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 08/06/14 11:20, David Malcolm wrote: > gcc/ > * sel-sched-ir.h (create_insn_rtx_from_pattern): Strengthen return > type from rtx to rtx_insn *. > * sel-sched-ir.h (create_copy_of_insn_rtx): Likewise. > * sel-sched-ir.c (create_insn_rtx_from_pattern): Likewise. > * sel-sched-ir.c (create_copy_of_insn_rtx): Likewise, also for > local "res". OK. jeff
On Wed, 2014-08-13 at 12:02 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > gcc/ > > * sel-sched-ir.h (create_insn_rtx_from_pattern): Strengthen return > > type from rtx to rtx_insn *. > > * sel-sched-ir.h (create_copy_of_insn_rtx): Likewise. > > * sel-sched-ir.c (create_insn_rtx_from_pattern): Likewise. > > * sel-sched-ir.c (create_copy_of_insn_rtx): Likewise, also for > > local "res". > OK. Thanks; committed to trunk as r214253.
On Aug 20, 2014, at 6:03 PM, David Malcolm <dmalcolm@redhat.com> wrote: >> OK. > Thanks; committed to trunk as r214253. So, unless there is a consumer of this information, in general, you don’t need to let us know you checked things in. We assume that by default. Cases were it is useful, you check in someone else’s patch and you want them to know the patch is now in, or say, you want someone working with you to know the work went in, or someone depending upon a patch, you want them to know that they are now unblocked, say for testing or additional work.
diff --git a/gcc/sel-sched-ir.c b/gcc/sel-sched-ir.c index 43569ee..f51f4f3 100644 --- a/gcc/sel-sched-ir.c +++ b/gcc/sel-sched-ir.c @@ -5724,10 +5724,10 @@ sel_unregister_cfg_hooks (void) /* Emit an insn rtx based on PATTERN. If a jump insn is wanted, LABEL is where this jump should be directed. */ -rtx +rtx_insn * create_insn_rtx_from_pattern (rtx pattern, rtx label) { - rtx insn_rtx; + rtx_insn *insn_rtx; gcc_assert (!INSN_P (pattern)); @@ -5767,10 +5767,11 @@ create_vinsn_from_insn_rtx (rtx insn_rtx, bool force_unique_p) } /* Create a copy of INSN_RTX. */ -rtx +rtx_insn * create_copy_of_insn_rtx (rtx insn_rtx) { - rtx res, link; + rtx_insn *res; + rtx link; if (DEBUG_INSN_P (insn_rtx)) return create_insn_rtx_from_pattern (copy_rtx (PATTERN (insn_rtx)), diff --git a/gcc/sel-sched-ir.h b/gcc/sel-sched-ir.h index 16e7806..d2bf7e2 100644 --- a/gcc/sel-sched-ir.h +++ b/gcc/sel-sched-ir.h @@ -1629,9 +1629,9 @@ extern void sel_register_cfg_hooks (void); extern void sel_unregister_cfg_hooks (void); /* Expression transformation routines. */ -extern rtx create_insn_rtx_from_pattern (rtx, rtx); +extern rtx_insn *create_insn_rtx_from_pattern (rtx, rtx); extern vinsn_t create_vinsn_from_insn_rtx (rtx, bool); -extern rtx create_copy_of_insn_rtx (rtx); +extern rtx_insn *create_copy_of_insn_rtx (rtx); extern void change_vinsn_in_expr (expr_t, vinsn_t); /* Various initialization functions. */