Message ID | 1389888913.2087.19.camel@e104536-lin.cambridge.arm.com |
---|---|
State | New |
Headers | show |
On 16/01/14 16:15, Alan Lawrence wrote: > This is a small patch that makes the -mcpu, -march and -mtune > command-line options case-insensitive, allowing e.g. -mcpu=Cortex-A15 > -march=ARMv7. > > Regression tested on arm-none-eabi with no issues; options passed onto > e.g. ld are always lowercase (as previously). > > OK for trunk? > > --Alan > > ChangeLog: > * config/arm/arm.opt: Make -mcpu, -march, -mtune case-insensitive. * config/arm/arm.opt (mcpu, march, mtune): Make case-insensitive. Don't forget the leading tab; and since someone else will have to commit the patch for you, you should also include the date/author part as well. Generally <date> Alan Lawrence <Alan.Lawrence@arm.com> would be acceptable, since the commit date may not be the same as the posting date. Otherwise, this is OK. R. > > > aarch32.diff > > > diff --git a/gcc/config/arm/arm.opt b/gcc/config/arm/arm.opt > index 8bcf199..d80f1f1 100644 > --- a/gcc/config/arm/arm.opt > +++ b/gcc/config/arm/arm.opt > @@ -77,7 +77,7 @@ mapcs-stack-check > Target Report Mask(APCS_STACK) Undocumented > > march= > -Target RejectNegative Joined Enum(arm_arch) Var(arm_arch_option) > +Target RejectNegative ToLower Joined Enum(arm_arch) Var(arm_arch_option) > Specify the name of the target architecture > > ; Other arm_arch values are loaded from arm-tables.opt > @@ -102,7 +102,7 @@ Target Report Mask(CALLER_INTERWORKING) > Thumb: Assume function pointers may go to non-Thumb aware code > > mcpu= > -Target RejectNegative Joined Enum(processor_type) Var(arm_cpu_option) Init(arm_none) > +Target RejectNegative ToLower Joined Enum(processor_type) Var(arm_cpu_option) Init(arm_none) > Specify the name of the target CPU > > mfloat-abi= > @@ -223,7 +223,7 @@ Target Report Mask(TPCS_LEAF_FRAME) > Thumb: Generate (leaf) stack frames even if not needed > > mtune= > -Target RejectNegative Joined Enum(processor_type) Var(arm_tune_option) Init(arm_none) > +Target RejectNegative ToLower Joined Enum(processor_type) Var(arm_tune_option) Init(arm_none) > Tune code for the given processor > > ; Other processor_type values are loaded from arm-tables.opt >
On Thu, Jan 16, 2014 at 05:14:24PM +0000, Richard Earnshaw wrote: > On 16/01/14 16:15, Alan Lawrence wrote: > > This is a small patch that makes the -mcpu, -march and -mtune > > command-line options case-insensitive, allowing e.g. -mcpu=Cortex-A15 > > -march=ARMv7. > > > > Regression tested on arm-none-eabi with no issues; options passed onto > > e.g. ld are always lowercase (as previously). > > > > OK for trunk? > > > > --Alan > > > > ChangeLog: > > * config/arm/arm.opt: Make -mcpu, -march, -mtune case-insensitive. > > * config/arm/arm.opt (mcpu, march, mtune): Make case-insensitive. > > Don't forget the leading tab; and since someone else will have to commit > the patch for you, you should also include the date/author part as well. > Generally > > <date> Alan Lawrence <Alan.Lawrence@arm.com> > > would be acceptable, since the commit date may not be the same as the > posting date. > > Otherwise, this is OK. > I've committed this to trunk on Alan's behalf as revision 206673, with the following Changelog: 2014-01-16 Alan Lawrence <alan.lawrence@arm.com> * config/arm/arm.opt: Make -mcpu, -march, -mtune case-insensitive. Thanks, James
On Thu, Jan 16, 2014 at 06:13:33PM +0000, James Greenhalgh wrote: > On Thu, Jan 16, 2014 at 05:14:24PM +0000, Richard Earnshaw wrote: > > On 16/01/14 16:15, Alan Lawrence wrote: > > > This is a small patch that makes the -mcpu, -march and -mtune > > > command-line options case-insensitive, allowing e.g. -mcpu=Cortex-A15 > > > -march=ARMv7. > > > > > > Regression tested on arm-none-eabi with no issues; options passed onto > > > e.g. ld are always lowercase (as previously). > > > > > > OK for trunk? > > > > > > --Alan > > > > > > ChangeLog: > > > * config/arm/arm.opt: Make -mcpu, -march, -mtune case-insensitive. > > > > * config/arm/arm.opt (mcpu, march, mtune): Make case-insensitive. > > > > Don't forget the leading tab; and since someone else will have to commit > > the patch for you, you should also include the date/author part as well. > > Generally > > > > <date> Alan Lawrence <Alan.Lawrence@arm.com> > > > > would be acceptable, since the commit date may not be the same as the > > posting date. > > > > Otherwise, this is OK. > > > > I've committed this to trunk on Alan's behalf as revision 206673, > with the following Changelog: > > 2014-01-16 Alan Lawrence <alan.lawrence@arm.com> > > * config/arm/arm.opt: Make -mcpu, -march, -mtune case-insensitive. > A more careful reading of your review of Alan's patch shows that this should have been: 2014-01-16 Alan Lawrence <alan.lawrence@arm.com> * config/arm/arm.opt (mcpu, march, mtune): Make case-insensitive. I've fixed this up in revision 206700. Sorry for the noise. James
diff --git a/gcc/config/arm/arm.opt b/gcc/config/arm/arm.opt index 8bcf199..d80f1f1 100644 --- a/gcc/config/arm/arm.opt +++ b/gcc/config/arm/arm.opt @@ -77,7 +77,7 @@ mapcs-stack-check Target Report Mask(APCS_STACK) Undocumented march= -Target RejectNegative Joined Enum(arm_arch) Var(arm_arch_option) +Target RejectNegative ToLower Joined Enum(arm_arch) Var(arm_arch_option) Specify the name of the target architecture ; Other arm_arch values are loaded from arm-tables.opt @@ -102,7 +102,7 @@ Target Report Mask(CALLER_INTERWORKING) Thumb: Assume function pointers may go to non-Thumb aware code mcpu= -Target RejectNegative Joined Enum(processor_type) Var(arm_cpu_option) Init(arm_none) +Target RejectNegative ToLower Joined Enum(processor_type) Var(arm_cpu_option) Init(arm_none) Specify the name of the target CPU mfloat-abi= @@ -223,7 +223,7 @@ Target Report Mask(TPCS_LEAF_FRAME) Thumb: Generate (leaf) stack frames even if not needed mtune= -Target RejectNegative Joined Enum(processor_type) Var(arm_tune_option) Init(arm_none) +Target RejectNegative ToLower Joined Enum(processor_type) Var(arm_tune_option) Init(arm_none) Tune code for the given processor ; Other processor_type values are loaded from arm-tables.opt