From patchwork Thu Oct 17 16:28:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 284309 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 8E5992C00C8 for ; Fri, 18 Oct 2013 03:28:39 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:subject:from:to:cc:date:in-reply-to:references :content-type:content-transfer-encoding:mime-version; q=dns; s= default; b=Ppuh46uSqG/8b+uD1bRfMqmDu2ahUAbcRepP3pdH6gGI2mm6ZoXxF 2QfSVYOD7Qa9rEmW+TEKY29MWnxKfSlYPG6ZcJsntOVgvltMYSDUk8K2tdEkoAO0 vp/++iewTaG7cAveQ709WX88/2TUIViEYez4QakooJmiGE9aA8Cbw0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:subject:from:to:cc:date:in-reply-to:references :content-type:content-transfer-encoding:mime-version; s=default; bh=l6oPzXV5AMOgJ2Pb63DuTxy54wk=; b=ng0GUe0/G8tqnzpNE8QbGG4Eq2Kj kD8C2u9UwCSe1DauMlewhtSkRUqYuel1qk/X+Y7BG82IzvQOKcKNHf8Bczlu5eIp THBSE6tm0PHPs6Wqb09ZGXrQOwD9m+ZchAKZ0nf8p4b0U0a75cA0jYTCEW8+lMVQ 0XugdbrMNJ8X/M8= Received: (qmail 20118 invoked by alias); 17 Oct 2013 16:28:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 20099 invoked by uid 89); 17 Oct 2013 16:28:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: multi.imgtec.com Received: from multi.imgtec.com (HELO multi.imgtec.com) (194.200.65.239) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 17 Oct 2013 16:28:32 +0000 Message-ID: <1382027306.2558.16.camel@ubuntu-sellcey> Subject: Re: [PATCH][i386]Fix PR 57756 From: Steve Ellcey To: Diego Novillo CC: David Edelsohn , Sriraman Tallam , Michael Meissner , GCC Patches , David Edelsohn , David Li , Richard Biener Date: Thu, 17 Oct 2013 09:28:26 -0700 In-Reply-To: References: MIME-Version: 1.0 X-SEF-Processed: 7_3_0_01192__2013_10_17_17_28_29 On Thu, 2013-10-17 at 06:03 -0700, Diego Novillo wrote: > On Wed, Oct 16, 2013 at 6:06 PM, David Edelsohn wrote: > > > How is Google going to change its patch commit policies to ensure that > > this does not happen again? > > There is nothing to change. Google follows > http://gcc.gnu.org/contribute.html, like everyone else. Sri just fixed > the oversight and if there is any other fallout from his patch, he > will address it. > > I don't see anything out of the ordinary here. > > > Diego. FYI: I just want to make sure everyone is aware that there are still broken targets. rs6000 may be fixed but mips still doesn't work and I presume other platforms like sparc are also still broken. /local/home/sellcey/nightly_full/src/gcc/gcc/c-family/c-cppbuiltin.c: In function 'void cpp_atomic_builtins(cpp_reader*)': /local/home/sellcey/nightly_full/src/gcc/gcc/c-family/c-cppbuiltin.c:594:7: error: 'target_flags_explicit' was not declared in this scope /local/home/sellcey/nightly_full/src/gcc/gcc/c-family/c-cppbuiltin.c:606:7: error: 'target_flags_explicit' was not declared in this scope /local/home/sellcey/nightly_full/src/gcc/gcc/c-family/c-cppbuiltin.c:618:7: error: 'target_flags_explicit' was not declared in this scope /local/home/sellcey/nightly_full/src/gcc/gcc/c-family/c-cppbuiltin.c:630:7: error: 'target_flags_explicit' was not declared in this scope make[1]: *** [c-family/c-cppbuiltin.o] Error 1 Sriraman, are you looking at how to fix this globally or are the target maintainers expected to fix this? Currently I am using this one line patch to get things building, but I presume this is not what we want long term. % git diff opth-gen.awk print "" Steve Ellcey sellcey@mips.com diff --git a/gcc/opth-gen.awk b/gcc/opth-gen.awk index 01c5ab6..46bd570 100644 --- a/gcc/opth-gen.awk +++ b/gcc/opth-gen.awk @@ -114,6 +114,7 @@ print "};" print "extern struct gcc_options global_options;" print "extern const struct gcc_options global_options_init;" print "extern struct gcc_options global_options_set;" +print "#define target_flags_explicit global_options_set.x_target_flag s" print "#endif" print "#endif"