diff mbox series

rs6000: Use strlen instead of sizeof - 1

Message ID 136c18ed814dea8942251304535b88a8c17f8ce2.1581387959.git.segher@kernel.crashing.org
State New
Headers show
Series rs6000: Use strlen instead of sizeof - 1 | expand

Commit Message

Segher Boessenkool Feb. 11, 2020, 2:30 a.m. UTC 
It is easier to read and understand  strlen ("string")  than it is to
read and understrand  sizeof ("string") - 1  .

Tested on powerpc64-linux {-m32,-m64}.  Committing to trunk.


Segher


2020-02-10  Segher Boessenkool  <segher@kernel.crashing.org>

	* config/rs6000/rs6000.c (rs6000_debug_print_mode): Don't use sizeof
	where strlen is more legible.
	(rs6000_builtin_vectorized_libmass): Ditto.
	(rs6000_print_options_internal): Ditto.

---
 gcc/config/rs6000/rs6000.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff mbox series

Patch

diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c
index fc68976..a6fd1e6 100644
--- a/gcc/config/rs6000/rs6000.c
+++ b/gcc/config/rs6000/rs6000.c
@@ -2135,7 +2135,7 @@  rs6000_debug_print_mode (ssize_t m)
       spaces = 0;
     }
   else
-    spaces += sizeof ("  Reload=sl") - 1;
+    spaces += strlen ("  Reload=sl");
 
   if (reg_addr[m].scalar_in_vmx_p)
     {
@@ -2143,7 +2143,7 @@  rs6000_debug_print_mode (ssize_t m)
       spaces = 0;
     }
   else
-    spaces += sizeof ("  Upper=y") - 1;
+    spaces += strlen ("  Upper=y");
 
   if (rs6000_vector_unit[m] != VECTOR_NONE
       || rs6000_vector_mem[m] != VECTOR_NONE)
@@ -5206,7 +5206,7 @@  rs6000_builtin_vectorized_libmass (combined_fn fn, tree type_out,
   if (!bname)
     return NULL_TREE;
 
-  strcpy (name, bname + sizeof ("__builtin_") - 1);
+  strcpy (name, bname + strlen ("__builtin_"));
   strcat (name, suffix);
 
   if (n_args == 1)
@@ -23547,7 +23547,7 @@  rs6000_print_options_internal (FILE *file,
 	  if ((flags & mask) == 0)
 	    {
 	      no_str = "no-";
-	      len += sizeof ("no-") - 1;
+	      len += strlen ("no-");
 	    }
 
 	  flags &= ~mask;
@@ -23558,7 +23558,7 @@  rs6000_print_options_internal (FILE *file,
 	  if ((flags & mask) != 0)
 	    {
 	      no_str = "no-";
-	      len += sizeof ("no-") - 1;
+	      len += strlen ("no-");
 	    }
 
 	  flags |= mask;
@@ -23574,7 +23574,7 @@  rs6000_print_options_internal (FILE *file,
 
       fprintf (file, "%s%s%s%s", comma, prefix, no_str, name);
       comma = ", ";
-      comma_len = sizeof (", ") - 1;
+      comma_len = strlen (", ");
     }
 
   fputs ("\n", file);