From patchwork Thu Feb 28 09:40:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: James Greenhalgh X-Patchwork-Id: 223854 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 9BBD32C03D4 for ; Thu, 28 Feb 2013 20:40:44 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1362649247; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=YOz7H5mC+Osv25sd++/aXlMkp8Y=; b=ITSb/Jedy8ulFeV Nush26ydyWCAMSjWEs1gRDn6/E6GjnGkz8h2NAJTVs4S6zRMJtLfQc/DTL6wKhv7 UKQLg6IGI2kGsoguL9GVjP1az0zaO+g1N4prYt09VEGC1yYizPvEd/5bpliB1jaD ep6xvaxoEl2mdg4IEpRv9q94lVME= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:X-MC-Unique:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=eiPTLhkTYMStrU99GGQWn33qNvWUlaBdk3kKgmQrnDwIlN0TYoMscsZbr5hrPo +thbW1MKyhhe6hhfU7VrtqWzYCAG+EWh3R53BY4xHg/O45MoZbdzJp9S8+ZLa1pA Dcw/r3C34/aCO7qJXCKxEoiqhACKTiIdlfhWtQbosuTko=; Received: (qmail 20887 invoked by alias); 28 Feb 2013 09:40:38 -0000 Received: (qmail 20825 invoked by uid 22791); 28 Feb 2013 09:40:37 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_SPAMHAUS_DROP, KHOP_THREADED, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Feb 2013 09:40:31 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Thu, 28 Feb 2013 09:40:30 +0000 Received: from e106375-lin.cambridge.arm.com ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 28 Feb 2013 09:40:29 +0000 From: James Greenhalgh To: gcc-patches@gcc.gnu.org Cc: marcus.shawcroft@arm.com Subject: [AArch64/AArch64-4.7] Fix warning - aarch64_simd_make_constant has no prototype. Date: Thu, 28 Feb 2013 09:40:25 +0000 Message-Id: <1362044425-7855-1-git-send-email-james.greenhalgh@arm.com> In-Reply-To: <1362044092-7629-1-git-send-email-james.greenhalgh@arm.com> References: <1362044092-7629-1-git-send-email-james.greenhalgh@arm.com> MIME-Version: 1.0 X-MC-Unique: 113022809403002801 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi, aarch64_simd_make_constant has no prototype, but it doesn't need one as it should be declared static. This patch fixes the warning: config/aarch64/aarch64.c:6574:1: warning: no previous prototype for ‘aarch64_simd_make_constant’ [-Wmissing-prototypes] Which is hidden when building with g++, but looks like: config/aarch64/aarch64.c:6590:1: warning: no previous declaration for ‘aarch64_simd_make_constant’ [-Wmissing-declarations] On Trunk. Regression tested with no regressions on aarch64-none-elf. OK for trunk and aarch64-4.7-branch? Thanks, James Greenhalgh --- gcc/ 2013-02-28 James Greenhalgh * config/aarch64/aarch64.c (aarch64_simd_make_constant): Make static. diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index 85668da..f091297 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -6586,7 +6586,7 @@ aarch64_simd_dup_constant (rtx vals) constants (for vec_init) or CONST_VECTOR, efficiently into a register. Returns an RTX to copy into the register, or NULL_RTX for a PARALLEL that can not be converted into a CONST_VECTOR. */ -rtx +static rtx aarch64_simd_make_constant (rtx vals) { enum machine_mode mode = GET_MODE (vals);