From patchwork Thu Sep 6 09:14:22 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleg Endo X-Patchwork-Id: 182119 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id AA1392C00A0 for ; Thu, 6 Sep 2012 19:14:49 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1347527690; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:Content-Transfer-Encoding:Mime-Version:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=eFd4G3FQpFcTlb2s1G3cbiXfTCY=; b=l6ug6Ea4zCi7emfTQOrK5ETuKNdbQwt9w4NJTPmMzHOkt+/clzIr0qGyj4MRua mtcHepn0TWDakd7GTlEihMQd+GnuI4ALzRyzZFuTpv4b6X3LD+SKqXt6J0fFtz6V tZBjuKOyTMoS84dPL4Lmzfg6nMOL6H6ARVN/kuiyhyND4= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Mime-Version:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=FVQqasM/hm4Vg86V6aQJROPu7OZx5p62neYfd3d/pM7iUB1RphgNtsEXNHNb5d 79YbeoP8+N9MHjRFGm0nSevXJD1nougEABhwatR5aXWmVIJjF5Oj+GLNG9NffmIJ cnD0VjIMaqm3RYjriSMF0rfDOJXIadhq3vVMyXtW058WU=; Received: (qmail 13368 invoked by alias); 6 Sep 2012 09:14:45 -0000 Received: (qmail 13343 invoked by uid 22791); 6 Sep 2012 09:14:43 -0000 X-SWARE-Spam-Status: No, hits=-3.4 required=5.0 tests=AWL, BAYES_00, KHOP_THREADED, RCVD_IN_DNSWL_NONE, RCVD_IN_HOSTKARMA_NO, RP_MATCHES_RCVD, UNPARSEABLE_RELAY X-Spam-Check-By: sourceware.org Received: from mailout10.t-online.de (HELO mailout10.t-online.de) (194.25.134.21) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Sep 2012 09:14:28 +0000 Received: from fwd03.aul.t-online.de (fwd03.aul.t-online.de ) by mailout10.t-online.de with smtp id 1T9YAN-0002SU-2j; Thu, 06 Sep 2012 11:14:27 +0200 Received: from [192.168.0.100] (ECSSz8ZXwhiRTMOREE1yOx4lo-F+OfwGO8ExthpfMveCtB5E2ZLeRHx4RQoV10eZ1I@[93.218.164.60]) by fwd03.t-online.de with esmtp id 1T9YAM-053kno0; Thu, 6 Sep 2012 11:14:26 +0200 Message-ID: <1346922862.2130.11.camel@yam-132-YW-E178-FTW> Subject: Re: [middle-end] Add machine_mode to address_cost target hook From: Oleg Endo To: Dominique Dhumieres Cc: gcc-patches@gcc.gnu.org Date: Thu, 06 Sep 2012 11:14:22 +0200 In-Reply-To: <20120906074952.B3A6E3BE1B@mailhost.lps.ens.fr> References: <20120906074952.B3A6E3BE1B@mailhost.lps.ens.fr> Mime-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Thu, 2012-09-06 at 09:49 +0200, Dominique Dhumieres wrote: > Oleg, > > Bootstrap fails at revision 190996 on powerpc-apple-darwin9 with: > > g++ -c -g -DIN_GCC -fno-exceptions -fno-rtti -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I../../work/gcc -I../../work/gcc/. -I../../work/gcc/../include -I./../intl -I../../work/gcc/../libcpp/include -I/opt/mp/include -I../../work/gcc/../libdecnumber -I../../work/gcc/../libdecnumber/dpd -I../libdecnumber -DCLOOG_INT_GMP -I/opt/mp/include \ > ../../work/gcc/config/rs6000/rs6000.c -o rs6000.o > ../../work/gcc/config/rs6000/rs6000.c: In function 'int rs6000_debug_address_cost(rtx, machine_mode, addr_space_t, bool)': > ../../work/gcc/config/rs6000/rs6000.c:26077:42: error: cannot convert 'bool' to 'machine_mode' for argument '2' to 'int hook_int_rtx_mode_as_bool_0(rtx, machine_mode, addr_space_t, bool)' > int ret = TARGET_ADDRESS_COST (x, speed); > > Obvious(?) fix > > --- ../_gcc_clean/gcc/config/rs6000/rs6000.c 2012-09-05 20:25:39.000000000 +0200 > +++ ../work/gcc/config/rs6000/rs6000.c 2012-09-06 00:56:21.000000000 +0200 > @@ -26074,7 +26074,7 @@ static int > rs6000_debug_address_cost (rtx x, enum machine_mode mode ATTRIBUTE_UNUSED, > addr_space_t as ATTRIBUTE_UNUSED, bool speed) > { > - int ret = TARGET_ADDRESS_COST (x, speed); > + int ret = TARGET_ADDRESS_COST (x, mode, as, speed); > > fprintf (stderr, "\nrs6000_address_cost, return = %d, speed = %s, x:\n", > ret, speed ? "true" : "false"); > Argh, sorry. Yes, you're right. The unused attrs can also go away in this case: Could you please commit this (I can't at the moment)? Cheers, Oleg Index: gcc/config/rs6000/rs6000.c =================================================================== --- gcc/config/rs6000/rs6000.c (revision 190990) +++ gcc/config/rs6000/rs6000.c (working copy) @@ -26071,10 +26071,10 @@ /* Debug form of ADDRESS_COST that is selected if -mdebug=cost. */ static int -rs6000_debug_address_cost (rtx x, enum machine_mode mode ATTRIBUTE_UNUSED, - addr_space_t as ATTRIBUTE_UNUSED, bool speed) +rs6000_debug_address_cost (rtx x, enum machine_mode mode, addr_space_t as, + bool speed) { - int ret = TARGET_ADDRESS_COST (x, speed); + int ret = TARGET_ADDRESS_COST (x, mode, as, speed); fprintf (stderr, "\nrs6000_address_cost, return = %d, speed = %s, x:\n", ret, speed ? "true" : "false");