From patchwork Fri Nov 4 21:48:19 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Torvald Riegel X-Patchwork-Id: 123706 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id DF96EB7091 for ; Sat, 5 Nov 2011 08:48:44 +1100 (EST) Received: (qmail 11516 invoked by alias); 4 Nov 2011 21:48:43 -0000 Received: (qmail 11479 invoked by uid 22791); 4 Nov 2011 21:48:38 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Nov 2011 21:48:25 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA4LmMBr030669 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 Nov 2011 17:48:22 -0400 Received: from [10.36.4.215] (vpn1-4-215.ams2.redhat.com [10.36.4.215]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pA4LmKJO027604; Fri, 4 Nov 2011 17:48:20 -0400 Subject: Re: [patch] 17/n: trans-mem: compiler trans-mem main engine From: Torvald Riegel To: "Joseph S. Myers" Cc: Aldy Hernandez , gcc-patches In-Reply-To: References: <4EB2E6FC.5070901@redhat.com> Date: Fri, 04 Nov 2011 22:48:19 +0100 Message-ID: <1320443299.5756.1066.camel@triegel.csb> Mime-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Thu, 2011-11-03 at 20:38 +0000, Joseph S. Myers wrote: > Make sure that you do need each #include present in this and any other new > file. Since 2008 a lot of includes of tm.h and toplev.h have been removed > and diagnostic-core.h introduced as an alternative to diagnostic.h for > many users. If tm.h is needed, it's good to have a comment on the > #include explaining why (which target macros are used, for example), since > we'd like to avoid unnecessary tm.h includes. See attached patch. OK for branch? commit dddfec5e83627ef4dc208eddad644d478250a1c4 Author: Torvald Riegel Date: Fri Nov 4 16:59:44 2011 +0100 Removed unnecessary includes. * trans-mem.c: Removed unnecessary includes. --- a/gcc/ChangeLog.tm +++ b/gcc/ChangeLog.tm @@ -1,3 +1,7 @@ +2011-11-04 Torvald Riegel + + * trans-mem.c: Removed unnecessary includes. + 2011-11-04 Richard Henderson * cp/parser.c (cp_parser_init_declarator): Fix production comments. diff --git a/gcc/trans-mem.c b/gcc/trans-mem.c index f0f5c8a..db65e12 100644 --- a/gcc/trans-mem.c +++ b/gcc/trans-mem.c @@ -20,21 +20,15 @@ #include "config.h" #include "system.h" #include "coretypes.h" -#include "tm.h" #include "tree.h" #include "gimple.h" -#include "tree-dump.h" #include "tree-flow.h" #include "tree-pass.h" #include "tree-inline.h" -#include "except.h" -#include "diagnostic.h" -#include "toplev.h" -#include "flags.h" +#include "diagnostic-core.h" #include "demangle.h" #include "output.h" #include "trans-mem.h" -#include "ggc.h" #include "params.h" #include "target.h" #include "langhooks.h"