From patchwork Thu May 26 09:14:28 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Pero X-Patchwork-Id: 97511 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 9F195B6F90 for ; Thu, 26 May 2011 19:14:49 +1000 (EST) Received: (qmail 30938 invoked by alias); 26 May 2011 09:14:46 -0000 Received: (qmail 30930 invoked by uid 22791); 26 May 2011 09:14:45 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL, BAYES_00, TW_BJ, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 May 2011 09:14:31 +0000 Received: from eggs.gnu.org ([140.186.70.92]:36720) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QPWeE-0007yW-FA for gcc-patches@gnu.org; Thu, 26 May 2011 05:14:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QPWeD-0002HD-9x for gcc-patches@gnu.org; Thu, 26 May 2011 05:14:30 -0400 Received: from smtp131.iad.emailsrvr.com ([207.97.245.131]:55442) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QPWeD-0002H9-58 for gcc-patches@gnu.org; Thu, 26 May 2011 05:14:29 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp33.relay.iad1a.emailsrvr.com (SMTP Server) with ESMTP id 752D4301C7 for ; Thu, 26 May 2011 05:14:28 -0400 (EDT) Received: from dynamic11.wm-web.iad.mlsrvr.com (dynamic11.wm-web.iad1a.rsapps.net [192.168.2.218]) by smtp33.relay.iad1a.emailsrvr.com (SMTP Server) with ESMTP id 641AA3012C for ; Thu, 26 May 2011 05:14:28 -0400 (EDT) Received: from meta-innovation.com (localhost [127.0.0.1]) by dynamic11.wm-web.iad.mlsrvr.com (Postfix) with ESMTP id 4C43AE00A9 for ; Thu, 26 May 2011 05:14:28 -0400 (EDT) Received: by www2.webmail.us (Authenticated sender: nicola.pero@meta-innovation.com, from: nicola.pero@meta-innovation.com) with HTTP; Thu, 26 May 2011 11:14:28 +0200 (CEST) Date: Thu, 26 May 2011 11:14:28 +0200 (CEST) Subject: Fix missing function declaration warnings in yesterday's libobjc patch From: "Nicola Pero" To: "gcc-patches@gnu.org" MIME-Version: 1.0 X-Type: plain Message-ID: <1306401268.305429184@www2.webmail.us> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 207.97.245.131 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This patch fixes a problem with the patch from Richard/David that was committed yesterday; presumably since the patch was originally written before the new libobjc API revamp, it was still using objc_lookup_class(), which is not part of the Modern API, hence currently undeclared in sendmsg.c. I replaced it with the Modern API counter-part, which is objc_getClass(), fixing the compiler warnings, and providing the compiler with the correct function declaration. Applied to trunk. Thanks Index: sendmsg.c =================================================================== --- sendmsg.c (revision 174267) +++ sendmsg.c (working copy) @@ -1111,7 +1111,7 @@ else { /* Retreive the class from the meta class. */ - Class c = objc_lookup_class (cls->name); + Class c = objc_getClass (cls->name); assert (CLS_ISMETA (cls)); assert (c); __objc_send_initialize (c); Index: ChangeLog =================================================================== --- ChangeLog (revision 174267) +++ ChangeLog (working copy) @@ -1,3 +1,8 @@ +2011-05-26 Nicola Pero + + * sendmsg.c (__objc_install_dtable_for_class): Use objc_getClass, + not objc_lookupClass. + 2011-05-25 Richard Frith-Macdonald David Ayers