diff mbox series

[OBVIOUS] Fix release checking build of ARM.

Message ID 1296f567-4214-5201-774b-d3c46530bd57@suse.cz
State New
Headers show
Series [OBVIOUS] Fix release checking build of ARM. | expand

Commit Message

Martin Liška Feb. 4, 2020, 8:22 a.m. UTC
Hi.

It's a move of code outside of seltests that are not enabled with
--enable-checking=release.

@Stam: Can you please take a look at observer warnings related to your
code:

/home/marxin/Programming/gcc2/gcc/config/arm/arm.c: In function ‘const char* arm_gen_far_branch(rtx_def**, int, const char*, const char*)’:
/home/marxin/Programming/gcc2/gcc/config/arm/arm.c:33089:38: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 128 [-Wformat-truncation=]
33089 |   snprintf (buffer, sizeof (buffer), "%s%s", branch_format , label_ptr);
       |                                      ^~~~~~
/home/marxin/Programming/gcc2/gcc/config/arm/arm.c:33089:12: note: ‘snprintf’ output 1 or more bytes (assuming 256) into a destination of size 128
33089 |   snprintf (buffer, sizeof (buffer), "%s%s", branch_format , label_ptr);
       |   ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/marxin/Programming/gcc2/gcc/config/arm/arm.c:33092:38: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size between 111 and 121 [-Wformat-truncation=]
33092 |   snprintf (buffer, sizeof (buffer), "b\t%%l0%d\n%s:", pos_label, label_ptr);
       |                                      ^~~~~~~~~~~~~~~~
/home/marxin/Programming/gcc2/gcc/config/arm/arm.c:33092:12: note: ‘snprintf’ output between 9 and 274 bytes into a destination of size 128
33092 |   snprintf (buffer, sizeof (buffer), "b\t%%l0%d\n%s:", pos_label, label_ptr);
       |   ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Martin

gcc/ChangeLog:

2020-02-04  Martin Liska  <mliska@suse.cz>

	* config/arm/arm.c (arm_gen_far_branch): Move the function
	outside of selftests.
---
  gcc/config/arm/arm.c | 41 ++++++++++++++++++++---------------------
  1 file changed, 20 insertions(+), 21 deletions(-)
diff mbox series

Patch

diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
index b5ae7e3e9ce..fe3bc675b42 100644
--- a/gcc/config/arm/arm.c
+++ b/gcc/config/arm/arm.c
@@ -33041,6 +33041,26 @@  arm_run_selftests (void)
 }
 } /* Namespace selftest.  */
 
+#undef TARGET_RUN_TARGET_SELFTESTS
+#define TARGET_RUN_TARGET_SELFTESTS selftest::arm_run_selftests
+#endif /* CHECKING_P */
+
+/* Worker function for TARGET_MD_ASM_ADJUST, while in thumb1 mode.
+   Unlike the arm version, we do NOT implement asm flag outputs.  */
+
+rtx_insn *
+thumb1_md_asm_adjust (vec<rtx> &outputs, vec<rtx> &/*inputs*/,
+		      vec<const char *> &constraints,
+		      vec<rtx> &/*clobbers*/, HARD_REG_SET &/*clobbered_regs*/)
+{
+  for (unsigned i = 0, n = outputs.length (); i < n; ++i)
+    if (strncmp (constraints[i], "=@cc", 4) == 0)
+      {
+	sorry ("asm flags not supported in thumb1 mode");
+	break;
+      }
+  return NULL;
+}
 
 /* Generate code to enable conditional branches in functions over 1 MiB.
    Parameters are:
@@ -33075,27 +33095,6 @@  arm_gen_far_branch (rtx * operands, int pos_label, const char * dest,
   return "";
 }
 
-#undef TARGET_RUN_TARGET_SELFTESTS
-#define TARGET_RUN_TARGET_SELFTESTS selftest::arm_run_selftests
-#endif /* CHECKING_P */
-
-/* Worker function for TARGET_MD_ASM_ADJUST, while in thumb1 mode.
-   Unlike the arm version, we do NOT implement asm flag outputs.  */
-
-rtx_insn *
-thumb1_md_asm_adjust (vec<rtx> &outputs, vec<rtx> &/*inputs*/,
-		      vec<const char *> &constraints,
-		      vec<rtx> &/*clobbers*/, HARD_REG_SET &/*clobbered_regs*/)
-{
-  for (unsigned i = 0, n = outputs.length (); i < n; ++i)
-    if (strncmp (constraints[i], "=@cc", 4) == 0)
-      {
-	sorry ("asm flags not supported in thumb1 mode");
-	break;
-      }
-  return NULL;
-}
-
 struct gcc_target targetm = TARGET_INITIALIZER;
 
 #include "gt-arm.h"