From patchwork Fri Jan 3 20:28:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Stump X-Patchwork-Id: 306674 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 743792C007C for ; Sat, 4 Jan 2014 07:28:21 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; q=dns; s= default; b=vNSCSPtXktf0FkLEHvycA840YjnNIV176vlicePBG+d46djvR1TDN Se0KHKCvlnAEMMUOG2n8uCEIqCivCCYzkRQwQsuuEUHsgrONPw8BoV3SloeZ4NNB 8KVOiNmli7FshYtdv2SUwrWo1D/+XzmcC6XxRNEfZxgpm5+NZHKKms= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=default; bh=7TZTJvVICpLYGas6gGVgBobkodc=; b=YEt95eilxCdkML4PtLSIYPO5k3oL MT05aCZeH39cxJUgJoAmFvCkKt+i8aW9BBA+L6OmTKYY/Vf1xlD2bJX/Gj8bvhm/ ZjH7TOQhawCS6VnIqPxHsEs0VqiXY6yk0ejP4Oq0ofZttpQyUDu7xWwgMiqjkStl MBZlcunPQageDKE= Received: (qmail 32246 invoked by alias); 3 Jan 2014 20:28:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 32232 invoked by uid 89); 3 Jan 2014 20:28:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: qmta02.emeryville.ca.mail.comcast.net Received: from qmta02.emeryville.ca.mail.comcast.net (HELO qmta02.emeryville.ca.mail.comcast.net) (76.96.30.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Jan 2014 20:28:11 +0000 Received: from omta16.emeryville.ca.mail.comcast.net ([76.96.30.72]) by qmta02.emeryville.ca.mail.comcast.net with comcast id 9XZv1n0031ZMdJ4A2YUA8M; Fri, 03 Jan 2014 20:28:10 +0000 Received: from up.mrs.kithrup.com ([24.4.193.8]) by omta16.emeryville.ca.mail.comcast.net with comcast id 9YU91n0080BKwT48cYU9UF; Fri, 03 Jan 2014 20:28:09 +0000 Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: wide-int, rtl From: Mike Stump In-Reply-To: <201401022326.36915.ebotcazou@adacore.com> Date: Fri, 3 Jan 2014 12:28:08 -0800 Cc: gcc-patches@gcc.gnu.org, Kenneth Zadeck Message-Id: <09A87FBE-5327-41C9-9BBD-461CAEE6E41C@comcast.net> References: <1673383.yVHhgiMuu2@polaris> <20CE4C78-00CC-410E-98AB-A454B37E0FC9@comcast.net> <201401022326.36915.ebotcazou@adacore.com> To: Eric Botcazou X-IsSubscribed: yes On Jan 2, 2014, at 2:26 PM, Eric Botcazou wrote: >> So, I'd like to ping the original patch and Kenny's patch to resolve the >> issues you found. If you have any other concerns or thoughts, let us >> know. > > Almost OK, but remove the strange quotes in the comment for the INTEGER_CST > case of expand_expr_real_1 Ok, thanks. I've resolved it this way: Index: expr.c =================================================================== --- expr.c (revision 206323) +++ expr.c (working copy) @@ -9477,11 +9477,10 @@ expand_expr_real_1 (tree exp, rtx target return decl_rtl; case INTEGER_CST: - /* "Given that TYPE_PRECISION (type) is not always equal to + /* Given that TYPE_PRECISION (type) is not always equal to GET_MODE_PRECISION (TYPE_MODE (type)), we need to extend from the former to the latter according to the signedness of the - type". */ - + type. */ temp = immed_wide_int_const (wide_int::from (exp, GET_MODE_PRECISION (TYPE_MODE (type)),