| Message ID | 08111237-fe7b-4878-9e68-817a602d2996@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [committed,_GLIBCXX_INLINE_VERSION] Add emul TLS symbol exports | expand |
On Sun, 29 Oct 2023 at 21:25, François Dumont <frs.dumont@gmail.com> wrote: > > libstdc++: [_GLIBCXX_INLINE_VERSION] Add emul TLS symbols > > libstdc++-v3/ChangeLog: > > * config/abi/pre/gnu-versioned-namespace.ver: Add missing emul TLS > symbols. Please put a comment above the two new lines, the same as in gnu.ver: # targets using emutls OK with that change, thanks.
On 30/10/2023 14:58, Jonathan Wakely wrote: > On Sun, 29 Oct 2023 at 21:25, François Dumont <frs.dumont@gmail.com> wrote: >> libstdc++: [_GLIBCXX_INLINE_VERSION] Add emul TLS symbols >> >> libstdc++-v3/ChangeLog: >> >> * config/abi/pre/gnu-versioned-namespace.ver: Add missing emul TLS >> symbols. > > Please put a comment above the two new lines, the same as in gnu.ver: > > # targets using emutls > > OK with that change, thanks. It's already committed as it was a trivial change limited to the versioned namespace special mode for which I'm maintainer. Can you confirm you want a new commit just to add this comment ?
On Mon, 30 Oct 2023, 18:07 François Dumont, <frs.dumont@gmail.com> wrote: > > On 30/10/2023 14:58, Jonathan Wakely wrote: > > On Sun, 29 Oct 2023 at 21:25, François Dumont <frs.dumont@gmail.com> > wrote: > >> libstdc++: [_GLIBCXX_INLINE_VERSION] Add emul TLS symbols > >> > >> libstdc++-v3/ChangeLog: > >> > >> * config/abi/pre/gnu-versioned-namespace.ver: Add missing emul TLS > >> symbols. > > > > Please put a comment above the two new lines, the same as in gnu.ver: > > > > # targets using emutls > > > > OK with that change, thanks. > > It's already committed as it was a trivial change limited to the > versioned namespace special mode for which I'm maintainer. > > Can you confirm you want a new commit just to add this comment ? > Yes please >
diff --git a/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver b/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver index 9fab8bead15..3140a9628d8 100644 --- a/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver +++ b/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver @@ -78,6 +78,8 @@ GLIBCXX_8.0 { # thread/mutex/condition_variable/future __once_proxy; + __emutls_v._ZSt3__811__once_call; + __emutls_v._ZSt3__815__once_callable; # std::__convert_to_v _ZNSt3__814__convert_to_v*;