From patchwork Tue Jan 3 14:53:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Cowgill X-Patchwork-Id: 710496 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ttH5805TSz9t0v for ; Wed, 4 Jan 2017 01:53:32 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="Rf8UI+AS"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; q=dns; s= default; b=dkl5EBS6fPWRmmEKavKYo3Q+jBCd/lnSdsNv8V4RA1GSqHbg04m5V HjB7/QVVykAz62Bkk5J5AvlFwkxBzQo5fFmw3g4IAGAWlpPc0vQbmDCUasmSaJ/C 49RhZsLXtEBaIoFdsVRh0OSkhTHe8SDHFrhisl8H5/ZZeEA4gZoas8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=default; bh=xK2fDDyS3lxcnSvPyvurhuQL5oY=; b=Rf8UI+ASKnQJCiW2Hf6lhEhdg5UD BcLf33IvVfvEo1CONIPt9OKvjNAPDsnwkZXMpETXH3ICXv8ZOm44J3nAGlqUwQv3 uLBC0aWkK0upZ6iQyRcclJWKdMbepNtM2+7tUrmMgjIerAjlWbWD/jCjNj7PRFQz iM2epE41QUKK0wo= Received: (qmail 127711 invoked by alias); 3 Jan 2017 14:53:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 127700 invoked by uid 89); 3 Jan 2017 14:53:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:U*charlet, charlet, arnaud, Hx-languages-length:3410 X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Jan 2017 14:53:14 +0000 Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19]) by Forcepoint Email with ESMTPS id DCDFB9AB272BA; Tue, 3 Jan 2017 14:53:07 +0000 (GMT) Received: from [10.150.130.85] (10.150.130.85) by HHMAIL01.hh.imgtec.org (10.100.10.21) with Microsoft SMTP Server (TLS) id 14.3.294.0; Tue, 3 Jan 2017 14:53:11 +0000 Subject: Re: [PATCH 1/2] [ADA] Fix MIPS big-endian build To: Arnaud Charlet References: <20170103144739.GA32406@adacore.com> CC: From: James Cowgill Message-ID: <04f3bf7f-3689-ee62-610d-fceb8394fa83@imgtec.com> Date: Tue, 3 Jan 2017 14:53:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170103144739.GA32406@adacore.com> Hi, On 03/01/17 14:47, Arnaud Charlet wrote: >> This patch merges the mips and mipsel sections in >> gcc-interface/Makefile.in favoring the existing variables in mipsel. >> Over time, the mipsel target was tested much more than the mips target >> and a number of fixes were applied which should have been applied to >> both. Since the only real difference between mips and mipsel is the >> endianness, it makes sense to merge them together and add an extra ifeq >> for the one file which does differ with endianness. >> >> I don't have commit access. >> >> Thanks, >> James >> >> gcc/ada/Changelog: >> >> 2017-01-03 James Cowgill >> >> * s-linux-mips.ads: Rename from s-linux-mipsel.ads. >> * gcc-interface/Makefile.in (MIPS/Linux): Merge mips and mipsel >> sections. > > Changes look OK to me. Thanks, can you commit it for me? I screwed up the patch in the email I sent a few minutes ago but the patch below should apply. James gcc/ada/Changelog: 2017-01-03 James Cowgill * s-linux-mips.ads: Rename from s-linux-mipsel.ads. * gcc-interface/Makefile.in (MIPS/Linux): Merge mips and mipsel sections. diff --git a/gcc/ada/gcc-interface/Makefile.in b/gcc/ada/gcc-interface/Makefile.in index 98889c0f30f..b47a16c8b41 100644 --- a/gcc/ada/gcc-interface/Makefile.in +++ b/gcc/ada/gcc-interface/Makefile.in @@ -1813,36 +1813,12 @@ ifeq ($(strip $(filter-out cygwin% mingw32% pe,$(target_os))),) endif # Mips Linux -ifeq ($(strip $(filter-out mips linux%,$(target_cpu) $(target_os))),) +ifeq ($(strip $(filter-out mips% linux%,$(target_cpu) $(target_os))),) LIBGNAT_TARGET_PAIRS = \ a-intnam.ads