diff mbox

Questionable code in gcov-io.c

Message ID 03ab905d-d364-a3df-860e-94b47bba3910@acm.org
State New
Headers show

Commit Message

Nathan Sidwell Oct. 14, 2016, 10:52 a.m. UTC 
On 10/13/16 18:10, Andrew Pinski wrote:

> /home/jenkins/workspace/BuildToolchainAARCH64_thunder_elf_upstream/toolchain/scripts/../src/libgcc/libgcov-driver.c:53:0:
> /home/jenkins/workspace/BuildToolchainAARCH64_thunder_elf_upstream/toolchain/scripts/../src/libgcc/../gcc/gcov-io.c:
> In function ‘__gcov_open’:
> /home/jenkins/workspace/BuildToolchainAARCH64_thunder_elf_upstream/toolchain/scripts/../src/libgcc/../gcc/gcov-io.c:184:10:
> error: assignment of read-only variable ‘mode’
>      mode = 1;

Darn, even when I'm paranoid I still mess up :(

fixed.

nathan
diff mbox

Patch

2016-10-14  Nathan Sidwell  <nathan@acm.org>

	* gcov-io.c (gcov_open): Deconstify 'mode'.

Index: gcov-io.c
===================================================================
--- gcov-io.c	(revision 241153)
+++ gcov-io.c	(working copy)
@@ -127,7 +127,7 @@  gcov_open (const char *name, int mode)
 #endif
 {
 #if IN_LIBGCOV
-  const int mode = 0;
+  int mode = 0;
 #endif
 #if GCOV_LOCKED
   struct flock s_flock;