From patchwork Thu Jun 13 08:43:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bin Cheng X-Patchwork-Id: 251011 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 9E7D92C009A for ; Thu, 13 Jun 2013 18:48:02 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-type; q=dns; s=default; b=oGds5BiLQ73LGq4X TBiAVltU38OUEy3PoM6nCQFMp8FpXXVFeyh92kQzxVFc702M/iwjwihytFLm0OUc zGff73gST09cExbAr10TzzMSSun+DlRKnVHmf5qxivauq0NPll7vT0UGxZiz3T6N A1d8rz+tWkvnNF31XlWO3WEoUf0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-type; s=default; bh=lLBzunfAd7RThGj+mamweC ugwOg=; b=ROqBPhRv7p2TNhoYRmyW4VTHLmpi57w4w0SZ72beHULE0lYBDbdEHm hEci1twYCpMtNG789vGhzLGDDCEDNH6fxzY/tbpHOqRXAcy3pOg2UaZvIvLuzJd7 K3fIpMtKAKacSqrzqOhX/oA9futtdeyj+3PtdvEuCV+DK1S8pbGX4= Received: (qmail 5658 invoked by alias); 13 Jun 2013 08:47:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 5605 invoked by uid 89); 13 Jun 2013 08:47:50 -0000 X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_05, KHOP_THREADED, MSGID_MULTIPLE_AT, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.1 Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 13 Jun 2013 08:47:49 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Thu, 13 Jun 2013 09:47:46 +0100 Received: from Binsh02 ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 13 Jun 2013 09:47:45 +0100 From: "Bin Cheng" To: "'Eric Botcazou'" Cc: References: <1940891.qGd5ztU7Rp@polaris> In-Reply-To: <1940891.qGd5ztU7Rp@polaris> Subject: RE: [PATCH GCC]Check the code to be executed for COND_EXEC in noop_move_p Date: Thu, 13 Jun 2013 16:43:25 +0800 Message-ID: <00b201ce6812$13c3eb70$3b4bc250$@cheng@arm.com> MIME-Version: 1.0 X-MC-Unique: 113061309474605901 X-Virus-Found: No > -----Original Message----- > From: Eric Botcazou [mailto:ebotcazou@adacore.com] > Sent: Thursday, June 13, 2013 3:36 PM > To: Bin Cheng > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH GCC]Check the code to be executed for COND_EXEC in > noop_move_p > > > 2013-06-13 Bin Cheng > > > > * rtlanal.c (noop_move_p): Check the code to be executed for > > COND_EXEC. > > OK if you use COND_EXEC_CODE instead of EXP and remove the useless assertion. > Hi Eric, Attached patch is applied as r200061, modified according to your comments. Thanks. bin Index: gcc/rtlanal.c =================================================================== --- gcc/rtlanal.c (revision 199949) +++ gcc/rtlanal.c (working copy) @@ -1199,6 +1199,10 @@ noop_move_p (const_rtx insn) if (find_reg_note (insn, REG_EQUAL, NULL_RTX)) return 0; + /* Check the code to be executed for COND_EXEC. */ + if (GET_CODE (pat) == COND_EXEC) + pat = COND_EXEC_CODE (pat); + if (GET_CODE (pat) == SET && set_noop_p (pat)) return 1;