From patchwork Thu Jul 6 09:00:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Sayle X-Patchwork-Id: 1804201 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=nextmovesoftware.com header.i=@nextmovesoftware.com header.a=rsa-sha256 header.s=default header.b=btn3XaVI; dkim-atps=neutral Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QxVqM0dhxz20ZQ for ; Thu, 6 Jul 2023 19:00:29 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 047F738560A4 for ; Thu, 6 Jul 2023 09:00:27 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from server.nextmovesoftware.com (server.nextmovesoftware.com [162.254.253.69]) by sourceware.org (Postfix) with ESMTPS id 61FC63858C50 for ; Thu, 6 Jul 2023 09:00:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 61FC63858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nextmovesoftware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nextmovesoftware.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nextmovesoftware.com; s=default; h=Content-Type:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=T9Xy2bg7gou875Kpv9EOLIwUk9o1sM2uNp0D7oC/CvE=; b=btn3XaVIxnRZ2PUR0Wa0zqcF5G mwPhrGmEUBrEfEb882uizFkaqOkYHUoNN+ohV6nM+k1bJ++27Er4Hl2AbjyNYX2r5adcOyR/CDGMl AWo9Hh2XFSiYOYYxhEc/ZH8D2Fdxm2poPRt9zyrfdX9BVmqIORUplrK72IveTh3qCW1Y7tlaRlzic CQ0LlzDALimobmrKNZbUvD+M+LglCDjSKAdIvb5RjrItTQJJiBefzG7ea3xAnkzrsEwiSbf1dD0z6 p8yBWCzKSRVmyvLsPO+XKo5L6OdO8C0IXUXQJPxv48jC2EGs7a5grp6EknpgJ0m20WMSzSMbi9QZI Id6ELXnQ==; Received: from host86-161-68-50.range86-161.btcentralplus.com ([86.161.68.50]:52252 helo=Dell) by server.nextmovesoftware.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qHKqU-0005Xx-0j; Thu, 06 Jul 2023 05:00:14 -0400 From: "Roger Sayle" To: Cc: "'Hans-Peter Nilsson'" Subject: [Committed] Handle COPYSIGN in dwarf2out.cc'd mem_loc_descriptor Date: Thu, 6 Jul 2023 10:00:12 +0100 Message-ID: <001b01d9afe8$4762efc0$d628cf40$@nextmovesoftware.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: Admv50EOQ9YKUfn8QXCt4xqhEHvvGw== Content-Language: en-gb X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.nextmovesoftware.com X-AntiAbuse: Original Domain - gcc.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - nextmovesoftware.com X-Get-Message-Sender-Via: server.nextmovesoftware.com: authenticated_id: roger@nextmovesoftware.com X-Authenticated-Sender: server.nextmovesoftware.com: roger@nextmovesoftware.com X-Source: X-Source-Args: X-Source-Dir: X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Many thanks to Hans-Peter Nilsson for reminding me that new RTX codes need to be added to dwarf2out.cc's mem_loc_descriptor, and for doing this for BITREVERSE. This patch does the same for the recently added COPYSIGN. I'd been testing these on a target that doesn't use DWARF (nvptx-none) and so didn't exhibit the issue, and my additional testing on x86_64-pc-linux-gnu to double check that changes were safe, doesn't (yet) trigger the problematic assert in dwarf2out.cc's mem_loc_descriptor. Committed to mainline as obvious, after bootstrapping and regression testing on x86_64-pc-linux-gnu. 2023-07-06 Roger Sayle gcc/ChangeLog * dwarf2out.cc (mem_loc_descriptor): Handle COPYSIGN. diff --git a/gcc/dwarf2out.cc b/gcc/dwarf2out.cc index e973644..238d0a9 100644 --- a/gcc/dwarf2out.cc +++ b/gcc/dwarf2out.cc @@ -16941,6 +16941,7 @@ mem_loc_descriptor (rtx rtl, machine_mode mode, case SMUL_HIGHPART: case UMUL_HIGHPART: case BITREVERSE: + case COPYSIGN: break; case CONST_STRING: