From patchwork Wed Oct 28 02:12:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bin Cheng X-Patchwork-Id: 537178 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 814E0140D8F for ; Wed, 28 Oct 2015 13:12:49 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=HVHlJNVZ; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type; q=dns; s= default; b=YX4cd+5wtFcgtTTDoR68qjXkM2MPxJTMGqiBSWSlXOb2ghMa+l0xl g+MKx84sW4y1qYnes8Gm3OVsDuEBGCkQqxjc3Ta4xfuh5VKLd7qjG/qrcqs4Ipcj jqOzpuCAWXRIcs6oxWQe9jJ4YSK7BXmDRZwtCdYz5BXtW2JGrXCwDI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type; s= default; bh=KMG7zaClbYRMLP6R42im6CLG8Gc=; b=HVHlJNVZO6R/jS9SDeYL Dc0f8J2d1eQNSEl34hODcB2/UFneXqL8X+X2kDX+pNv9Zk+HyAy0n0sT1SzbxQz/ Ef1u+XvvE4e7BpbPL9HSuKylBjmSVjf8j5kpuJOf9Zg8flew8WsPul8x0ZVcT3rj xupfk5K04V4DBXqxTKBzC94= Received: (qmail 122931 invoked by alias); 28 Oct 2015 02:12:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 122919 invoked by uid 89); 28 Oct 2015 02:12:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Oct 2015 02:12:38 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-23-Vaw10M59Snq9xpcrJx0vXw-1; Wed, 28 Oct 2015 02:12:33 +0000 Received: from shawin233 ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 28 Oct 2015 02:12:32 +0000 From: "Bin Cheng" To: Subject: [PATCH GCC]Fix memory leak and wrong invariant dependence computation in IVOPT Date: Wed, 28 Oct 2015 10:12:21 +0800 Message-ID: <001701d11126$16e74620$44b5d260$@arm.com> MIME-Version: 1.0 X-MC-Unique: Vaw10M59Snq9xpcrJx0vXw-1 X-IsSubscribed: yes Hi, When address iv uses grouping was introduced, I also introduced memory leak and wrong computation of depends_on bitmap. The intention is to skip `depends_on' computation for sub address type iv uses. Unfortunately, the code is wrong because depends_on is freed in subsequent calls to get_computation_cost for a grouped iv use. This results in loss of depends_on information, as well memory leaks for depends_on bitmap. I think this is an obvious fix to the issue. Bootstrap and test on x86_64. OK? Thanks, bin 2015-10-27 Bin Cheng * tree-ssa-loop-ivopts.c (split_address_cost): Check depends_on. (get_computation_cost_at): Ditto. (determine_use_iv_cost_address): Pass NULL for arguments depends_on and inv_expr_id. diff --git a/gcc/tree-ssa-loop-ivopts.c b/gcc/tree-ssa-loop-ivopts.c index 945d34b..91f7284 100644 --- a/gcc/tree-ssa-loop-ivopts.c +++ b/gcc/tree-ssa-loop-ivopts.c @@ -4328,7 +4328,9 @@ split_address_cost (struct ivopts_data *data, *symbol_present = false; *var_present = true; fd_ivopts_data = data; - walk_tree (&addr, find_depends, depends_on, NULL); + if (depends_on) + walk_tree (&addr, find_depends, depends_on, NULL); + return new_cost (target_spill_cost[data->speed], 0); } @@ -4616,7 +4618,8 @@ get_computation_cost_at (struct ivopts_data *data, ? TYPE_MODE (TREE_TYPE (*use->op_p)) : VOIDmode); - *depends_on = NULL; + if (depends_on) + *depends_on = NULL; /* Only consider real candidates. */ if (!cand->iv) @@ -4908,9 +4911,9 @@ determine_use_iv_cost_address (struct ivopts_data *data, sub_use && !infinite_cost_p (cost); sub_use = sub_use->next) { - sub_cost = get_computation_cost (data, sub_use, cand, true, &depends_on, - &can_autoinc, &inv_expr_id); - cost = add_costs (cost, sub_cost); + sub_cost = get_computation_cost (data, sub_use, cand, true, NULL, + &can_autoinc, NULL); + cost = add_costs (cost, sub_cost); } set_use_iv_cost (data, use, cand, cost, depends_on, NULL_TREE, ERROR_MARK,