| Message ID | 000e0cd34f7ebac5b704a3bc68c3@google.com |
|---|---|
| State | New |
| Headers | show |
On 5/20/11, dnovillo@google.com <dnovillo@google.com> wrote: > > http://codereview.appspot.com/4550064/diff/1/gcc/cp/pph-streamer-in.c > File gcc/cp/pph-streamer-in.c (right): > > http://codereview.appspot.com/4550064/diff/1/gcc/cp/pph-streamer-in.c#newcode251 > gcc/cp/pph-streamer-in.c:251: { > +static VEC(qualified_typedef_usage_t,gc) * > +pph_stream_read_qual_use_vec (pph_stream *stream) > +{ > > This breaks bootstrap. This function is never used. I think you meant > to call it from the TEMPLATE_INFO handler, right? > > Does this look like the right fix? > > > diff --git a/gcc/cp/pph-streamer-in.c b/gcc/cp/pph-streamer-in.c > index d40fd17..c426466 100644 > --- a/gcc/cp/pph-streamer-in.c > +++ b/gcc/cp/pph-streamer-in.c > @@ -904,7 +904,7 @@ pph_stream_read_tree (struct lto_input_block *ib > ATTRIBUTE_UNUSED, > else if (TREE_CODE (expr) == TEMPLATE_INFO) > { > TI_TYPEDEFS_NEEDING_ACCESS_CHECKING (expr) > - = pph_stream_read_tree_vec (stream); > + = pph_stream_read_qual_use_vec (stream); > } > else if (TREE_CODE (expr) == TREE_LIST) > ; /* FIXME pph: already handled? */ > > http://codereview.appspot.com/4550064/ > LGTM
diff --git a/gcc/cp/pph-streamer-in.c b/gcc/cp/pph-streamer-in.c index d40fd17..c426466 100644 --- a/gcc/cp/pph-streamer-in.c +++ b/gcc/cp/pph-streamer-in.c @@ -904,7 +904,7 @@ pph_stream_read_tree (struct lto_input_block *ib ATTRIBUTE_UNUSED, else if (TREE_CODE (expr) == TEMPLATE_INFO) { TI_TYPEDEFS_NEEDING_ACCESS_CHECKING (expr) - = pph_stream_read_tree_vec (stream); + = pph_stream_read_qual_use_vec (stream); } else if (TREE_CODE (expr) == TREE_LIST)
http://codereview.appspot.com/4550064/diff/1/gcc/cp/pph-streamer-in.c File gcc/cp/pph-streamer-in.c (right): http://codereview.appspot.com/4550064/diff/1/gcc/cp/pph-streamer-in.c#newcode251 gcc/cp/pph-streamer-in.c:251: { +static VEC(qualified_typedef_usage_t,gc) * +pph_stream_read_qual_use_vec (pph_stream *stream) +{ This breaks bootstrap. This function is never used. I think you meant to call it from the TEMPLATE_INFO handler, right? Does this look like the right fix? ; /* FIXME pph: already handled? */ http://codereview.appspot.com/4550064/