diff mbox

[GCC/ARM] Redefine the ASM_APP_OFF in a cleaner way

Message ID 000101cf3295$b837bc10$28a73430$@arm.com
State New
Headers show

Commit Message

Terry Guo Feb. 26, 2014, 1:54 a.m. UTC
Hi There,

As the assembler directive ".code 16" equals ".thumb", this small patch is
going to redefine the ASM_APP_OFF in a cleaner way. Tested with GCC
regression test and no regressions. Is it OK to current trunk or shall we
wait until the release-branch mode end?

BR,
Terry

2014-02-25  Terry Guo  <terry.guo@arm.com>

        * config/arm/arm.h (ASM_APP_OFF): Re-define it in a cleaner way.
From fd607bf3a164e885a6e16a1028feff11b8a653bc Mon Sep 17 00:00:00 2001
From: Terry Guo <terry.guo@arm.com>
Date: Thu, 2 Jan 2014 15:08:55 +0800
Subject: [PATCH] patch

---
 gcc/config/arm/arm.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Ramana Radhakrishnan Feb. 26, 2014, 9:18 a.m. UTC | #1
On 02/26/14 01:54, Terry Guo wrote:
> Hi There,
>
> As the assembler directive ".code 16" equals ".thumb", this small patch is
> going to redefine the ASM_APP_OFF in a cleaner way. Tested with GCC
> regression test and no regressions. Is it OK to current trunk or shall we
> wait until the release-branch mode end?

Ok for stage1.

regards
Ramana
diff mbox

Patch

diff --git a/gcc/config/arm/arm.h b/gcc/config/arm/arm.h
index 288ff8b..f9d1537 100644
--- a/gcc/config/arm/arm.h
+++ b/gcc/config/arm/arm.h
@@ -2132,8 +2132,7 @@  extern int making_const_table;
   do { cfun->machine->thumb1_cc_insn = NULL_RTX; } while (0)
 
 #undef  ASM_APP_OFF
-#define ASM_APP_OFF (TARGET_THUMB1 ? "\t.code\t16\n" : \
-		     TARGET_THUMB2 ? "\t.thumb\n" : "")
+#define ASM_APP_OFF (TARGET_ARM ? "" : "\t.thumb\n")
 
 /* Output a push or a pop instruction (only used when profiling).
    We can't push STATIC_CHAIN_REGNUM (r12) directly with Thumb-1.  We know