From patchwork Tue Jun 19 11:26:50 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joey Ye X-Patchwork-Id: 165707 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 6BD1EB6FD4 for ; Tue, 19 Jun 2012 21:26:46 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1340710007; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID: MIME-Version:Content-Type:Content-Transfer-Encoding:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=ow4KBwPVayRzO1ROwL6rCYyXrk4=; b=A6nPg4Jx6CMFvVmEqvykmCUPLt1F0TnTbXGzAq37ftUspPdwuoAL+v0WqW5Ogl mkwRS4s9dKjBtLK1PEVobNwddK4txuLWzDiy2c0JLcrZ2qeXViZqlJlYKBaeUMS6 Zows0yBZ3QUzUld4B2lCuOHvND6Vl+aoKNY1cdhb9sbv0= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:X-MC-Unique:Content-Type:Content-Transfer-Encoding:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=igwVRnlEEs6jBk3L2EJLSmoGSlqBD7cmw8je0CdUEqqeDD5jNQxesJ0DgGN+O4 +DbKF1trhexgm74XOV5oCXpbWyvCDBKuZVgFKTO54IFxkTwyElduhS93hwk7zV9Q BLjrMBZ6ZtwCqVVh4+Xvl5AgbCmiYdJIsDtjeJ+KrVJ34=; Received: (qmail 32026 invoked by alias); 19 Jun 2012 11:26:39 -0000 Received: (qmail 32014 invoked by uid 22791); 19 Jun 2012 11:26:38 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, MSGID_MULTIPLE_AT, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_NO, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Jun 2012 11:26:25 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 19 Jun 2012 12:26:23 +0100 Received: from E103005 ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Tue, 19 Jun 2012 12:27:03 +0100 From: "Joey Ye" To: "Richard Earnshaw" Cc: "GCC Patches" References: <000001cd4dc8$2734ebb0$759ec310$@ye@arm.com> <4FE03B77.7030500@arm.com> In-Reply-To: <4FE03B77.7030500@arm.com> Subject: RE: [4.6][ARM] Backport "MCR Not available in Thumb1" Date: Tue, 19 Jun 2012 19:26:50 +0800 Message-ID: <000001cd4e0e$6efc7580$4cf56080$@ye@arm.com> MIME-Version: 1.0 X-MC-Unique: 112061912262301501 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Oops! Sorry for such a stupid problem. 2012-06-18 Joey Ye Backported from mainline 2011-10-14 David Alan Gilbert * config/arm/arm.h (TARGET_HAVE_DMB_MCR): MCR Not available in Thumb1. > -----Original Message----- > From: Richard Earnshaw > Sent: Tuesday, June 19, 2012 16:43 > To: Joey Ye > Cc: GCC Patches > Subject: Re: [4.6][ARM] Backport "MCR Not available in Thumb1" > > On 19/06/12 04:03, Joey Ye wrote: > > Backporting trunk r179979 > > > > OK for 4.6? > > > > Backported from mainline > > 2011-10-14 David Alan Gilbert > > > > PR target/48126 > > * config/arm/arm.c (arm_output_sync_loop): Move label before > > barrier. > > > > Index: gcc/config/arm/arm.h > > =================================================================== > > --- gcc/config/arm/arm.h (revision 188331) > > +++ gcc/config/arm/arm.h (working copy) > > @@ -294,7 +294,8 @@ > > #define TARGET_HAVE_DMB (arm_arch7) > > > > /* Nonzero if this chip implements a memory barrier via CP15. */ > > -#define TARGET_HAVE_DMB_MCR (arm_arch6k && ! TARGET_HAVE_DMB) > > +#define TARGET_HAVE_DMB_MCR (arm_arch6 && ! TARGET_HAVE_DMB \ > > + && ! TARGET_THUMB1) > > > > /* Nonzero if this chip implements a memory barrier instruction. */ > > #define TARGET_HAVE_MEMORY_BARRIER (TARGET_HAVE_DMB || > TARGET_HAVE_DMB_MCR) > > > > > > Not ok (yet), the ChangeLog entry doesn't match the patch. > > R. Index: gcc/config/arm/arm.h =================================================================== --- gcc/config/arm/arm.h (revision 188331) +++ gcc/config/arm/arm.h (working copy) @@ -294,7 +294,8 @@ #define TARGET_HAVE_DMB (arm_arch7) /* Nonzero if this chip implements a memory barrier via CP15. */ -#define TARGET_HAVE_DMB_MCR (arm_arch6k && ! TARGET_HAVE_DMB) +#define TARGET_HAVE_DMB_MCR (arm_arch6 && ! TARGET_HAVE_DMB \ + && ! TARGET_THUMB1) /* Nonzero if this chip implements a memory barrier instruction. */ #define TARGET_HAVE_MEMORY_BARRIER (TARGET_HAVE_DMB || TARGET_HAVE_DMB_MCR)