| Message ID | 20190410212747.18377-1-shorne@gmail.com |
|---|---|
| Headers | show |
| Series | OpenRISC floating point support + fixes | expand |
On 4/10/19 3:27 PM, Stafford Horne wrote: > Hello, > > This is a set of patches to bring FPU support to the OpenRISC backend. The > backend also add support for 64-bit floating point operations on 32-bit cores > using register pairs, see orfpx64a32 [0]. > > This depends on binutils patches which have also been submitted per review. [1] > > The toolchain has been tested using the gcc and binutils testsuites as well as > floating point test suites running on sim and an fpga soft core or1k_marocchino. > [2] > > There is also an unrelated, but trivial patch to fix a code quality issue with > volatile memory loads. > > This whole patch series can be found on my github repo [3] as well. > > -Stafford > > [0] https://openrisc.io/proposals/orfpx64a32 > [1] git@github.com:stffrdhrn/binutils-gdb.git orfpx64a32-2 > [2] https://github.com/openrisc/or1k_marocchino > [3] git@github.com:stffrdhrn/gcc.git or1k-fpu-1a > > Stafford Horne (3): > or1k: Initial support for FPU > or1k: Allow volatile memory for sign/zero extend loads > or1k: only force reg for immediates > > gcc/config.gcc | 1 + > gcc/config/or1k/or1k.c | 10 ++-- > gcc/config/or1k/or1k.md | 109 ++++++++++++++++++++++++++++++++-- > gcc/config/or1k/or1k.opt | 15 ++++- > gcc/config/or1k/predicates.md | 16 +++++ > gcc/doc/invoke.texi | 15 +++++ > 6 files changed, 156 insertions(+), 10 deletions(-) > So the only question is whether or not you're looking to drop this into gcc-9 or gcc-10. gcc-9 is in regression bugfixing stage, so technically this patch should wait to gcc-10. However, we usually give maintainers a degree of freedom, particularly if a change doens't "bleed" into generic parts of the compiler. So we'll leave it up to you to decide if you want to add this to gcc-9 or wait for gcc-10. jeff
On Fri, Apr 12, 2019 at 09:28:55AM -0600, Jeff Law wrote: > On 4/10/19 3:27 PM, Stafford Horne wrote: > > Hello, > > > > This is a set of patches to bring FPU support to the OpenRISC backend. The > > backend also add support for 64-bit floating point operations on 32-bit cores > > using register pairs, see orfpx64a32 [0]. > > > > This depends on binutils patches which have also been submitted per review. [1] > > > > The toolchain has been tested using the gcc and binutils testsuites as well as > > floating point test suites running on sim and an fpga soft core or1k_marocchino. > > [2] > > > > There is also an unrelated, but trivial patch to fix a code quality issue with > > volatile memory loads. > > > > This whole patch series can be found on my github repo [3] as well. > > > > -Stafford > > > > [0] https://openrisc.io/proposals/orfpx64a32 > > [1] git@github.com:stffrdhrn/binutils-gdb.git orfpx64a32-2 > > [2] https://github.com/openrisc/or1k_marocchino > > [3] git@github.com:stffrdhrn/gcc.git or1k-fpu-1a > > > > Stafford Horne (3): > > or1k: Initial support for FPU > > or1k: Allow volatile memory for sign/zero extend loads > > or1k: only force reg for immediates > > > > gcc/config.gcc | 1 + > > gcc/config/or1k/or1k.c | 10 ++-- > > gcc/config/or1k/or1k.md | 109 ++++++++++++++++++++++++++++++++-- > > gcc/config/or1k/or1k.opt | 15 ++++- > > gcc/config/or1k/predicates.md | 16 +++++ > > gcc/doc/invoke.texi | 15 +++++ > > 6 files changed, 156 insertions(+), 10 deletions(-) > > > So the only question is whether or not you're looking to drop this into > gcc-9 or gcc-10. > > gcc-9 is in regression bugfixing stage, so technically this patch should > wait to gcc-10. However, we usually give maintainers a degree of > freedom, particularly if a change doens't "bleed" into generic parts of > the compiler. > > So we'll leave it up to you to decide if you want to add this to gcc-9 > or wait for gcc-10. Hi Jeff, Thanks, I know I sent all the patches together for review. But, I am thinking for gcc-9 I will only be aiming at including 2/3. The others are only needed for FPU support and I can wait for gcc-10. We had a quick discussion about this on irc yesterday too. -Stafford