mbox series

[v3,0/3] PR preprocessor/83173: C preprocessor generates incorrect linemarkers

Message ID 20181101155607.11388-1-mgulick@mathworks.com
Headers show
Series PR preprocessor/83173: C preprocessor generates incorrect linemarkers | expand

Message

Mike Gulick Nov. 1, 2018, 3:56 p.m. UTC 
Hi,

Changes in v3:
I haven't gotten a response in several months, so I'm reposting these
patches.  I split up the enhancement to the -fdump-internal-locations
output from the actual bugfix.  Hopefully this will make these easier to
review.  I rebased these patches on the gcc master and had to make one
minor change to patch 3/3 to account for removal of the
ORDINARY_MAP_INCLUDER_FILE_INDEX macro that was made back in August.

We have been using this patch internally for the last 9 months without
any issues, and the some other users have indicated the same on the bug
report.  Please let me know if you have any feedback, and how I should
proceed.  I do not have gcc contributor paperwork in place, as I believe
that needs to be initiated by a maintainer, but I do have an employer
disclaimer already approved, so the process should be simple.

Thanks,
Mike

Mike Gulick (3):
  PR preprocessor/83173: Additional check before decrementing
    highest_location
  PR preprocessor/83173: New test
  PR preprocessor/83173: Enhance -fdump-internal-locations output

 gcc/input.c                                   |  49 ++-
 .../plugin/location-overflow-test-pr83173-1.h |   2 +
 .../plugin/location-overflow-test-pr83173-2.h |   2 +
 .../plugin/location-overflow-test-pr83173.c   |  21 ++
 .../plugin/location-overflow-test-pr83173.h   |   2 +
 .../gcc.dg/plugin/location_overflow_plugin.c  |  13 +-
 gcc/testsuite/gcc.dg/plugin/plugin.exp        |   3 +-
 libcpp/files.c                                |  32 +-
 libcpp/location-example.txt                   | 333 ++++++++++--------
 9 files changed, 301 insertions(+), 156 deletions(-)
 create mode 100644 gcc/testsuite/gcc.dg/plugin/location-overflow-test-pr83173-1.h
 create mode 100644 gcc/testsuite/gcc.dg/plugin/location-overflow-test-pr83173-2.h
 create mode 100644 gcc/testsuite/gcc.dg/plugin/location-overflow-test-pr83173.c
 create mode 100644 gcc/testsuite/gcc.dg/plugin/location-overflow-test-pr83173.h