diff mbox series

opal: fix the resource leak for get_linux_mem_devices

Message ID 20240227064730.210023-1-ivan.hu@canonical.com
State Accepted
Headers show
Series opal: fix the resource leak for get_linux_mem_devices | expand

Commit Message

Ivan Hu Feb. 27, 2024, 6:47 a.m. UTC 
BugLink: https://bugs.launchpad.net/fwts/+bug/2055117

resource leak found by coverity,
CID 323932: (#1 of 1): Resource leak (RESOURCE_LEAK)
28. leaked_storage: Variable mem_buffer going out of scope leaks the
storage it points to.

Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
---
 src/opal/mem_info.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/src/opal/mem_info.c b/src/opal/mem_info.c
index 0e173364..0e7e14d4 100644
--- a/src/opal/mem_info.c
+++ b/src/opal/mem_info.c
@@ -399,9 +399,9 @@  static int get_linux_mem_devices(fwts_framework *fw)
 				failures++;
 			}
 			free(mba_path);
-			free(mem_buffer);
 			free(namelist[i]);
 		}
+		free(mem_buffer);
 	}
 	free(namelist);