diff mbox series

acpi: s3: fix potential memory leaks on fwts_get() calls

Message ID 20240126085408.42394-1-ivan.hu@canonical.com
State Accepted
Headers show
Series acpi: s3: fix potential memory leaks on fwts_get() calls | expand

Commit Message

Ivan Hu Jan. 26, 2024, 8:54 a.m. UTC 
Potential memory leaks when str is not s2idle and NULL.

Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
---
 src/acpi/s3/s3.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/src/acpi/s3/s3.c b/src/acpi/s3/s3.c
index 903f22f4..ffdb7165 100644
--- a/src/acpi/s3/s3.c
+++ b/src/acpi/s3/s3.c
@@ -206,10 +206,11 @@  static int s3_init(fwts_framework *fw)
 	str = fwts_get(PM_SUSPEND_PATH);
 	if (str && strstr(str, "[s2idle]")) {
 		strncpy(sleep_type_orig, "s2idle", strlen("s2idle") + 1);
-		free(str);
 	} else {
 		strncpy(sleep_type_orig, "deep", strlen("deep") + 1);
 	}
+	if (str)
+		free(str);
 
 	if (s3_sleep_type) {
 		fwts_log_info(fw, "Override system suspend default by '%s'\n", s3_sleep_type);
@@ -220,10 +221,11 @@  static int s3_init(fwts_framework *fw)
 	str = fwts_get(PM_SUSPEND_PATH);
 	if (str && strstr(str, "[s2idle]")) {
 		strncpy(sleep_type, "s2idle", strlen("s2idle") + 1);
-		free(str);
 	} else {
 		strncpy(sleep_type, "S3", strlen("S3") + 1);
 	}
+	if (str)
+		free(str);
 
 	str = fwts_get(INTEL_PM_S0IX_WARN);
 	if (str && strstr(str, "N"))