| Message ID | 20230712083804.2581833-2-arthur@aheymans.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/3] acpi/spcr: Update supported port types | expand |
Thanks! Acked-by: Ivan Hu <ivan.hu@canonical.com> On 7/12/23 16:37, arthur@aheymans.xyz wrote: > From: Arthur Heymans <arthur@aheymans.xyz> > > Interrupt type 0 means the described interface only supports polled > operation. > > Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> > --- > src/acpi/spcr/spcr.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/src/acpi/spcr/spcr.c b/src/acpi/spcr/spcr.c > index 0f76d86a..fe297c88 100644 > --- a/src/acpi/spcr/spcr.c > +++ b/src/acpi/spcr/spcr.c > @@ -181,12 +181,6 @@ static int spcr_test1(fwts_framework *fw) > reserved1 = spcr->reserved1[0] + (spcr->reserved1[1] << 8) + (spcr->reserved1[2] << 16); > fwts_acpi_reserved_zero("SPCR", "Reserved1", reserved1, &passed); > > - if (spcr->interrupt_type == 0) { > - passed = false; > - fwts_failed(fw, LOG_LEVEL_HIGH, > - "SPCRUnknownInterruptType", > - "SPCR interrupt type field is zero, expecting support bits to be set"); > - } > if (spcr->interrupt_type & 0xf0) { > passed = false; > fwts_failed(fw, LOG_LEVEL_HIGH,
diff --git a/src/acpi/spcr/spcr.c b/src/acpi/spcr/spcr.c index 0f76d86a..fe297c88 100644 --- a/src/acpi/spcr/spcr.c +++ b/src/acpi/spcr/spcr.c @@ -181,12 +181,6 @@ static int spcr_test1(fwts_framework *fw) reserved1 = spcr->reserved1[0] + (spcr->reserved1[1] << 8) + (spcr->reserved1[2] << 16); fwts_acpi_reserved_zero("SPCR", "Reserved1", reserved1, &passed); - if (spcr->interrupt_type == 0) { - passed = false; - fwts_failed(fw, LOG_LEVEL_HIGH, - "SPCRUnknownInterruptType", - "SPCR interrupt type field is zero, expecting support bits to be set"); - } if (spcr->interrupt_type & 0xf0) { passed = false; fwts_failed(fw, LOG_LEVEL_HIGH,