| Message ID | 20210813170229.472683-1-alex.hung@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] acpi: fadt: clarify comments of FACS and HW-reduced mode | expand |
On 8/14/21 1:02 AM, Alex Hung wrote: > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/acpi/fadt/fadt.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/src/acpi/fadt/fadt.c b/src/acpi/fadt/fadt.c > index 0677a690..acf767e5 100644 > --- a/src/acpi/fadt/fadt.c > +++ b/src/acpi/fadt/fadt.c > @@ -76,9 +76,8 @@ static int fadt_init(fwts_framework *fw) > } > > /* > - * Some tests require data from the FACS, also, which is > - * required (5.2.10) is we are not in reduced hardware > - * mode > + * Some tests require data from the FACS (5.2.10), which > + * requires that we are not in hardware-reduced mode > */ > if (!fwts_acpi_is_reduced_hardware(fw)) { > if (fwts_acpi_find_table(fw, "FACS", 0, &table) != FWTS_OK) { > Acked-by: Ivan Hu <ivan.hu@canonical.com>
On 13/08/2021 18:02, Alex Hung wrote: > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/acpi/fadt/fadt.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/src/acpi/fadt/fadt.c b/src/acpi/fadt/fadt.c > index 0677a690..acf767e5 100644 > --- a/src/acpi/fadt/fadt.c > +++ b/src/acpi/fadt/fadt.c > @@ -76,9 +76,8 @@ static int fadt_init(fwts_framework *fw) > } > > /* > - * Some tests require data from the FACS, also, which is > - * required (5.2.10) is we are not in reduced hardware > - * mode > + * Some tests require data from the FACS (5.2.10), which > + * requires that we are not in hardware-reduced mode > */ > if (!fwts_acpi_is_reduced_hardware(fw)) { > if (fwts_acpi_find_table(fw, "FACS", 0, &table) != FWTS_OK) { > Thanks for the clarification Alex. Acked-by: Colin Ian King <colin.king@canonical.com>
diff --git a/src/acpi/fadt/fadt.c b/src/acpi/fadt/fadt.c index 0677a690..acf767e5 100644 --- a/src/acpi/fadt/fadt.c +++ b/src/acpi/fadt/fadt.c @@ -76,9 +76,8 @@ static int fadt_init(fwts_framework *fw) } /* - * Some tests require data from the FACS, also, which is - * required (5.2.10) is we are not in reduced hardware - * mode + * Some tests require data from the FACS (5.2.10), which + * requires that we are not in hardware-reduced mode */ if (!fwts_acpi_is_reduced_hardware(fw)) { if (fwts_acpi_find_table(fw, "FACS", 0, &table) != FWTS_OK) {
Signed-off-by: Alex Hung <alex.hung@canonical.com> --- src/acpi/fadt/fadt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)