diff mbox series

fwts-coreboot: remove blank line and fix a comment in a typo

Message ID 20210411132434.1189380-1-colin.king@canonical.com
State Accepted
Headers show
Series fwts-coreboot: remove blank line and fix a comment in a typo | expand

Commit Message

Colin Ian King April 11, 2021, 1:24 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Minor code clean up, no functional change

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_coreboot.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Alex Hung April 11, 2021, 8:54 p.m. UTC | #1 
On 2021-04-11 7:24 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Minor code clean up, no functional change
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_coreboot.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/lib/src/fwts_coreboot.c b/src/lib/src/fwts_coreboot.c
> index 3d69ac8c..a54973cb 100644
> --- a/src/lib/src/fwts_coreboot.c
> +++ b/src/lib/src/fwts_coreboot.c
> @@ -29,7 +29,6 @@ fwts_list* fwts_coreboot_cbmem_log(void)
>  	char *console;
>  
>  	console = fwts_coreboot_cbmem_console_dump();
> -
>  	if (!console)
>  		return NULL;
>  
> @@ -44,7 +43,7 @@ fwts_list* fwts_coreboot_cbmem_log(void)
>  fwts_list* fwts_coreboot_cbmem_log(void)
>  {
>  	/*
> -	 * TODO: add arm plattform support
> +	 * TODO: add arm platform support
>  	 */
>  	return NULL;
>  }
> 


Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu April 12, 2021, 7:32 a.m. UTC | #2 
On 4/11/21 9:24 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Minor code clean up, no functional change
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_coreboot.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/lib/src/fwts_coreboot.c b/src/lib/src/fwts_coreboot.c
> index 3d69ac8c..a54973cb 100644
> --- a/src/lib/src/fwts_coreboot.c
> +++ b/src/lib/src/fwts_coreboot.c
> @@ -29,7 +29,6 @@ fwts_list* fwts_coreboot_cbmem_log(void)
>  	char *console;
>  
>  	console = fwts_coreboot_cbmem_console_dump();
> -
>  	if (!console)
>  		return NULL;
>  
> @@ -44,7 +43,7 @@ fwts_list* fwts_coreboot_cbmem_log(void)
>  fwts_list* fwts_coreboot_cbmem_log(void)
>  {
>  	/*
> -	 * TODO: add arm plattform support
> +	 * TODO: add arm platform support
>  	 */
>  	return NULL;
>  }
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/lib/src/fwts_coreboot.c b/src/lib/src/fwts_coreboot.c
index 3d69ac8c..a54973cb 100644
--- a/src/lib/src/fwts_coreboot.c
+++ b/src/lib/src/fwts_coreboot.c
@@ -29,7 +29,6 @@  fwts_list* fwts_coreboot_cbmem_log(void)
 	char *console;
 
 	console = fwts_coreboot_cbmem_console_dump();
-
 	if (!console)
 		return NULL;
 
@@ -44,7 +43,7 @@  fwts_list* fwts_coreboot_cbmem_log(void)
 fwts_list* fwts_coreboot_cbmem_log(void)
 {
 	/*
-	 * TODO: add arm plattform support
+	 * TODO: add arm platform support
 	 */
 	return NULL;
 }