pci: maxreadreq: Add "safe to ignore ... message"

According to PCIe spec:
Functions that do not generate Read Requests larger than 128 bytes and
Functions that do not generate Read Requests on their own behalf are
permitted to implement this field as Read Only (RO) with a value of
000b.

Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/pci/maxreadreq/maxreadreq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

On 11/02/2021 00:55, Alex Hung wrote:
> According to PCIe spec:
> Functions that do not generate Read Requests larger than 128 bytes and
> Functions that do not generate Read Requests on their own behalf are
> permitted to implement this field as Read Only (RO) with a value of
> 000b.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/pci/maxreadreq/maxreadreq.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/pci/maxreadreq/maxreadreq.c b/src/pci/maxreadreq/maxreadreq.c
> index b9e7d869..c0964176 100644
> --- a/src/pci/maxreadreq/maxreadreq.c
> +++ b/src/pci/maxreadreq/maxreadreq.c
> @@ -145,7 +145,8 @@ static int maxreadreq_test1(fwts_framework *fw)
>  			"Express bus. Some drivers (for example the Brocade Fibre Channel driver) "
>  			"allow one to override the firmware settings. Where possible, this BIOS "
>  			"configuration setting is worth increasing it a little more for better "
> -			"performance at a small reduction of bus sharing.");
> +			"performance at a small reduction of bus sharing. Note it is safe to "
> +			"ignore this failure if the register is hardwired to zero per PCIe spec.");
>  	} else
>  		fwts_passed(fw, "All devices have MaxReadReq set > 128.");
>  
> 

Acked-by: Colin Ian King <colin.king@canonical.com>

On 2/11/21 8:55 AM, Alex Hung wrote:
> According to PCIe spec:
> Functions that do not generate Read Requests larger than 128 bytes and
> Functions that do not generate Read Requests on their own behalf are
> permitted to implement this field as Read Only (RO) with a value of
> 000b.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/pci/maxreadreq/maxreadreq.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/pci/maxreadreq/maxreadreq.c b/src/pci/maxreadreq/maxreadreq.c
> index b9e7d869..c0964176 100644
> --- a/src/pci/maxreadreq/maxreadreq.c
> +++ b/src/pci/maxreadreq/maxreadreq.c
> @@ -145,7 +145,8 @@ static int maxreadreq_test1(fwts_framework *fw)
>  			"Express bus. Some drivers (for example the Brocade Fibre Channel driver) "
>  			"allow one to override the firmware settings. Where possible, this BIOS "
>  			"configuration setting is worth increasing it a little more for better "
> -			"performance at a small reduction of bus sharing.");
> +			"performance at a small reduction of bus sharing. Note it is safe to "
> +			"ignore this failure if the register is hardwired to zero per PCIe spec.");
>  	} else
>  		fwts_passed(fw, "All devices have MaxReadReq set > 128.");
>  
> 


Acked-by: Ivan Hu <ivan.hu@canonical.com>