diff mbox series

dmicheck: add dmi version check to SMBIOS3

Message ID 20201209234539.58234-1-alex.hung@canonical.com
State Accepted
Headers show
Series dmicheck: add dmi version check to SMBIOS3 | expand

Commit Message

Alex Hung Dec. 9, 2020, 11:45 p.m. UTC 
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/dmi/dmicheck/dmicheck.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ivan Hu Dec. 14, 2020, 3:42 a.m. UTC | #1 
On 12/10/20 7:45 AM, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index aa31e936..41dd0f6c 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -2230,6 +2230,9 @@ static int dmicheck_test3(fwts_framework *fw)
>  		return FWTS_ERROR;
>  	}
>  
> +	if (dmi_version_check(fw, version) != FWTS_OK)
> +		return FWTS_SKIP;
> +
>  	table = dmi_table_smbios30(fw, &entry30);
>  	if (table == NULL)
>  		return FWTS_ERROR;
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
Colin Ian King Dec. 15, 2020, 9:23 a.m. UTC | #2 
On 09/12/2020 23:45, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index aa31e936..41dd0f6c 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -2230,6 +2230,9 @@ static int dmicheck_test3(fwts_framework *fw)
>  		return FWTS_ERROR;
>  	}
>  
> +	if (dmi_version_check(fw, version) != FWTS_OK)
> +		return FWTS_SKIP;
> +
>  	table = dmi_table_smbios30(fw, &entry30);
>  	if (table == NULL)
>  		return FWTS_ERROR;
> 


Acked-by: Colin Ian King <colin.king@canonical.com>
diff mbox series

Patch

diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
index aa31e936..41dd0f6c 100644
--- a/src/dmi/dmicheck/dmicheck.c
+++ b/src/dmi/dmicheck/dmicheck.c
@@ -2230,6 +2230,9 @@  static int dmicheck_test3(fwts_framework *fw)
 		return FWTS_ERROR;
 	}
 
+	if (dmi_version_check(fw, version) != FWTS_OK)
+		return FWTS_SKIP;
+
 	table = dmi_table_smbios30(fw, &entry30);
 	if (table == NULL)
 		return FWTS_ERROR;