diff mbox series

klog.json: sync AE_NOT_FOUND severity with a5d747194a9e

Message ID 20201113201913.194158-1-alex.hung@canonical.com
State Accepted
Headers show
Series klog.json: sync AE_NOT_FOUND severity with a5d747194a9e | expand

Commit Message

Alex Hung Nov. 13, 2020, 8:19 p.m. UTC
Both rules can point to the same type of errors and therefore they
should have the same severity.

Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 data/klog.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Colin Ian King Nov. 13, 2020, 8:26 p.m. UTC | #1
On 13/11/2020 20:19, Alex Hung wrote:
> Both rules can point to the same type of errors and therefore they
> should have the same severity.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  data/klog.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/data/klog.json b/data/klog.json
> index 14285f9c..ad3ffd65 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -5973,7 +5973,7 @@
>    },
>    {
>     "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> +   "log_level": "LOG_LEVEL_CRITICAL",
>     "pattern": "ACPI Error.+psparse",
>     "advice": "The ACPI engine has failed to execute some AML. The error message above lists the method that caused this error.",
>     "label": "KlogAcpiParseOrExecFailure"
> 

Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu Nov. 16, 2020, 6:20 a.m. UTC | #2
On 11/14/20 4:19 AM, Alex Hung wrote:
> Both rules can point to the same type of errors and therefore they
> should have the same severity.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  data/klog.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/data/klog.json b/data/klog.json
> index 14285f9c..ad3ffd65 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -5973,7 +5973,7 @@
>    },
>    {
>     "compare_mode": "regex",
> -   "log_level": "LOG_LEVEL_HIGH",
> +   "log_level": "LOG_LEVEL_CRITICAL",
>     "pattern": "ACPI Error.+psparse",
>     "advice": "The ACPI engine has failed to execute some AML. The error message above lists the method that caused this error.",
>     "label": "KlogAcpiParseOrExecFailure"
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/data/klog.json b/data/klog.json
index 14285f9c..ad3ffd65 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -5973,7 +5973,7 @@ 
   },
   {
    "compare_mode": "regex",
-   "log_level": "LOG_LEVEL_HIGH",
+   "log_level": "LOG_LEVEL_CRITICAL",
    "pattern": "ACPI Error.+psparse",
    "advice": "The ACPI engine has failed to execute some AML. The error message above lists the method that caused this error.",
    "label": "KlogAcpiParseOrExecFailure"