| Message ID | 20201113194746.146322-2-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] ACPICA: Update to version 20201113 | expand |
On 2020-11-13 12:47 p.m., Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The latest ACPICA is annotating more unknown UUIDs, so update > the tests to reflect this change. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > .../syntaxcheck-0001/syntaxcheck-0001.log | 60 ++++++++++++++++++- > 1 file changed, 58 insertions(+), 2 deletions(-) > > diff --git a/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log b/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log > index c9206380..0ad91273 100644 > --- a/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log > +++ b/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log > @@ -951,6 +951,20 @@ syntaxcheck thread enters the method and blocks and then a second > syntaxcheck thread also executes the method, ending up in two attempts > syntaxcheck to create the object and causing a failure. > syntaxcheck > +syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in > +syntaxcheck line 67 > +syntaxcheck Line | AML source > +syntaxcheck ---------------------------------------------------------- > +syntaxcheck 00064| 0x00, 0x00, 0x00, 0x00 // .... > +syntaxcheck 00065| }) > +syntaxcheck 00066| Concatenate (STS0, TEMP, Local2) > +syntaxcheck 00067| _OSC (ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */, REVS, SIZE, Local2) > +syntaxcheck | ^ > +syntaxcheck | Remark 2184: Unknown UUID string > +syntaxcheck 00068| } > +syntaxcheck 00069| > +syntaxcheck 00070| Method (_OSC, 4, NotSerialized) // _OSC: Operating System Capabilities > +syntaxcheck ========================================================== > syntaxcheck FAILED [LOW] AMLAsmASL_MSG_SERIALIZED_REQUIRED: Test 1, > syntaxcheck Assembler remark in line 70 > syntaxcheck Line | AML source > @@ -981,6 +995,20 @@ syntaxcheck 00075| CreateDWordField (Arg0, 0x04, IID1) > syntaxcheck 00076| CreateDWordField (Arg0, 0x08, IID2) > syntaxcheck 00077| CreateDWordField (Arg0, 0x0C, IID3) > syntaxcheck 00078| Name (UID0, ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */) > +syntaxcheck | ^ > +syntaxcheck | Remark 2184: Unknown UUID string > +syntaxcheck 00079| CreateDWordField (UID0, 0x00, EID0) > +syntaxcheck 00080| CreateDWordField (UID0, 0x04, EID1) > +syntaxcheck 00081| CreateDWordField (UID0, 0x08, EID2) > +syntaxcheck ========================================================== > +syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in > +syntaxcheck line 78 > +syntaxcheck Line | AML source > +syntaxcheck ---------------------------------------------------------- > +syntaxcheck 00075| CreateDWordField (Arg0, 0x04, IID1) > +syntaxcheck 00076| CreateDWordField (Arg0, 0x08, IID2) > +syntaxcheck 00077| CreateDWordField (Arg0, 0x0C, IID3) > +syntaxcheck 00078| Name (UID0, ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */) > syntaxcheck | ^ > syntaxcheck | Remark 2173: Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_PR.CPU0._OSC) > syntaxcheck 00079| CreateDWordField (UID0, 0x00, EID0) > @@ -1037,6 +1065,20 @@ syntaxcheck thread enters the method and blocks and then a second > syntaxcheck thread also executes the method, ending up in two attempts > syntaxcheck to create the object and causing a failure. > syntaxcheck > +syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in > +syntaxcheck line 140 > +syntaxcheck Line | AML source > +syntaxcheck ---------------------------------------------------------- > +syntaxcheck 00137| 0x00, 0x00, 0x00, 0x00 // .... > +syntaxcheck 00138| }) > +syntaxcheck 00139| Concatenate (STS1, TEMP, Local2) > +syntaxcheck 00140| _OSC (ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */, REVS, SIZE, Local2) > +syntaxcheck | ^ > +syntaxcheck | Remark 2184: Unknown UUID string > +syntaxcheck 00141| } > +syntaxcheck 00142| > +syntaxcheck 00143| Method (_OSC, 4, NotSerialized) // _OSC: Operating System Capabilities > +syntaxcheck ========================================================== > syntaxcheck FAILED [LOW] AMLAsmASL_MSG_SERIALIZED_REQUIRED: Test 1, > syntaxcheck Assembler remark in line 143 > syntaxcheck Line | AML source > @@ -1067,6 +1109,20 @@ syntaxcheck 00148| CreateDWordField (Arg0, 0x04, IID1) > syntaxcheck 00149| CreateDWordField (Arg0, 0x08, IID2) > syntaxcheck 00150| CreateDWordField (Arg0, 0x0C, IID3) > syntaxcheck 00151| Name (UID1, ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */) > +syntaxcheck | ^ > +syntaxcheck | Remark 2184: Unknown UUID string > +syntaxcheck 00152| CreateDWordField (UID1, 0x00, EID0) > +syntaxcheck 00153| CreateDWordField (UID1, 0x04, EID1) > +syntaxcheck 00154| CreateDWordField (UID1, 0x08, EID2) > +syntaxcheck ========================================================== > +syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in > +syntaxcheck line 151 > +syntaxcheck Line | AML source > +syntaxcheck ---------------------------------------------------------- > +syntaxcheck 00148| CreateDWordField (Arg0, 0x04, IID1) > +syntaxcheck 00149| CreateDWordField (Arg0, 0x08, IID2) > +syntaxcheck 00150| CreateDWordField (Arg0, 0x0C, IID3) > +syntaxcheck 00151| Name (UID1, ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */) > syntaxcheck | ^ > syntaxcheck | Remark 2173: Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_PR.CPU1._OSC) > syntaxcheck 00152| CreateDWordField (UID1, 0x00, EID0) > @@ -1101,11 +1157,11 @@ syntaxcheck 00189| Load (CST1, HC1) /* \_PR_.CPU1.HC1_ * > syntaxcheck 00190| } > syntaxcheck 00191| } > syntaxcheck ========================================================== > -syntaxcheck Table SSDT (5) reassembly: Found 0 errors, 0 warnings, 10 > +syntaxcheck Table SSDT (5) reassembly: Found 0 errors, 0 warnings, 14 > syntaxcheck remarks. > syntaxcheck > syntaxcheck > syntaxcheck ========================================================== > -syntaxcheck 2 passed, 67 failed, 0 warning, 0 aborted, 0 skipped, 0 > +syntaxcheck 2 passed, 71 failed, 0 warning, 0 aborted, 0 skipped, 0 > syntaxcheck info only. > syntaxcheck ========================================================== > Acked-by: Alex Hung <alex.hung@canonical.com>
On 11/14/20 3:47 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The latest ACPICA is annotating more unknown UUIDs, so update > the tests to reflect this change. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > .../syntaxcheck-0001/syntaxcheck-0001.log | 60 ++++++++++++++++++- > 1 file changed, 58 insertions(+), 2 deletions(-) > > diff --git a/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log b/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log > index c9206380..0ad91273 100644 > --- a/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log > +++ b/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log > @@ -951,6 +951,20 @@ syntaxcheck thread enters the method and blocks and then a second > syntaxcheck thread also executes the method, ending up in two attempts > syntaxcheck to create the object and causing a failure. > syntaxcheck > +syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in > +syntaxcheck line 67 > +syntaxcheck Line | AML source > +syntaxcheck ---------------------------------------------------------- > +syntaxcheck 00064| 0x00, 0x00, 0x00, 0x00 // .... > +syntaxcheck 00065| }) > +syntaxcheck 00066| Concatenate (STS0, TEMP, Local2) > +syntaxcheck 00067| _OSC (ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */, REVS, SIZE, Local2) > +syntaxcheck | ^ > +syntaxcheck | Remark 2184: Unknown UUID string > +syntaxcheck 00068| } > +syntaxcheck 00069| > +syntaxcheck 00070| Method (_OSC, 4, NotSerialized) // _OSC: Operating System Capabilities > +syntaxcheck ========================================================== > syntaxcheck FAILED [LOW] AMLAsmASL_MSG_SERIALIZED_REQUIRED: Test 1, > syntaxcheck Assembler remark in line 70 > syntaxcheck Line | AML source > @@ -981,6 +995,20 @@ syntaxcheck 00075| CreateDWordField (Arg0, 0x04, IID1) > syntaxcheck 00076| CreateDWordField (Arg0, 0x08, IID2) > syntaxcheck 00077| CreateDWordField (Arg0, 0x0C, IID3) > syntaxcheck 00078| Name (UID0, ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */) > +syntaxcheck | ^ > +syntaxcheck | Remark 2184: Unknown UUID string > +syntaxcheck 00079| CreateDWordField (UID0, 0x00, EID0) > +syntaxcheck 00080| CreateDWordField (UID0, 0x04, EID1) > +syntaxcheck 00081| CreateDWordField (UID0, 0x08, EID2) > +syntaxcheck ========================================================== > +syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in > +syntaxcheck line 78 > +syntaxcheck Line | AML source > +syntaxcheck ---------------------------------------------------------- > +syntaxcheck 00075| CreateDWordField (Arg0, 0x04, IID1) > +syntaxcheck 00076| CreateDWordField (Arg0, 0x08, IID2) > +syntaxcheck 00077| CreateDWordField (Arg0, 0x0C, IID3) > +syntaxcheck 00078| Name (UID0, ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */) > syntaxcheck | ^ > syntaxcheck | Remark 2173: Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_PR.CPU0._OSC) > syntaxcheck 00079| CreateDWordField (UID0, 0x00, EID0) > @@ -1037,6 +1065,20 @@ syntaxcheck thread enters the method and blocks and then a second > syntaxcheck thread also executes the method, ending up in two attempts > syntaxcheck to create the object and causing a failure. > syntaxcheck > +syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in > +syntaxcheck line 140 > +syntaxcheck Line | AML source > +syntaxcheck ---------------------------------------------------------- > +syntaxcheck 00137| 0x00, 0x00, 0x00, 0x00 // .... > +syntaxcheck 00138| }) > +syntaxcheck 00139| Concatenate (STS1, TEMP, Local2) > +syntaxcheck 00140| _OSC (ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */, REVS, SIZE, Local2) > +syntaxcheck | ^ > +syntaxcheck | Remark 2184: Unknown UUID string > +syntaxcheck 00141| } > +syntaxcheck 00142| > +syntaxcheck 00143| Method (_OSC, 4, NotSerialized) // _OSC: Operating System Capabilities > +syntaxcheck ========================================================== > syntaxcheck FAILED [LOW] AMLAsmASL_MSG_SERIALIZED_REQUIRED: Test 1, > syntaxcheck Assembler remark in line 143 > syntaxcheck Line | AML source > @@ -1067,6 +1109,20 @@ syntaxcheck 00148| CreateDWordField (Arg0, 0x04, IID1) > syntaxcheck 00149| CreateDWordField (Arg0, 0x08, IID2) > syntaxcheck 00150| CreateDWordField (Arg0, 0x0C, IID3) > syntaxcheck 00151| Name (UID1, ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */) > +syntaxcheck | ^ > +syntaxcheck | Remark 2184: Unknown UUID string > +syntaxcheck 00152| CreateDWordField (UID1, 0x00, EID0) > +syntaxcheck 00153| CreateDWordField (UID1, 0x04, EID1) > +syntaxcheck 00154| CreateDWordField (UID1, 0x08, EID2) > +syntaxcheck ========================================================== > +syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in > +syntaxcheck line 151 > +syntaxcheck Line | AML source > +syntaxcheck ---------------------------------------------------------- > +syntaxcheck 00148| CreateDWordField (Arg0, 0x04, IID1) > +syntaxcheck 00149| CreateDWordField (Arg0, 0x08, IID2) > +syntaxcheck 00150| CreateDWordField (Arg0, 0x0C, IID3) > +syntaxcheck 00151| Name (UID1, ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */) > syntaxcheck | ^ > syntaxcheck | Remark 2173: Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_PR.CPU1._OSC) > syntaxcheck 00152| CreateDWordField (UID1, 0x00, EID0) > @@ -1101,11 +1157,11 @@ syntaxcheck 00189| Load (CST1, HC1) /* \_PR_.CPU1.HC1_ * > syntaxcheck 00190| } > syntaxcheck 00191| } > syntaxcheck ========================================================== > -syntaxcheck Table SSDT (5) reassembly: Found 0 errors, 0 warnings, 10 > +syntaxcheck Table SSDT (5) reassembly: Found 0 errors, 0 warnings, 14 > syntaxcheck remarks. > syntaxcheck > syntaxcheck > syntaxcheck ========================================================== > -syntaxcheck 2 passed, 67 failed, 0 warning, 0 aborted, 0 skipped, 0 > +syntaxcheck 2 passed, 71 failed, 0 warning, 0 aborted, 0 skipped, 0 > syntaxcheck info only. > syntaxcheck ========================================================== > Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log b/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log index c9206380..0ad91273 100644 --- a/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log +++ b/fwts-test/syntaxcheck-0001/syntaxcheck-0001.log @@ -951,6 +951,20 @@ syntaxcheck thread enters the method and blocks and then a second syntaxcheck thread also executes the method, ending up in two attempts syntaxcheck to create the object and causing a failure. syntaxcheck +syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in +syntaxcheck line 67 +syntaxcheck Line | AML source +syntaxcheck ---------------------------------------------------------- +syntaxcheck 00064| 0x00, 0x00, 0x00, 0x00 // .... +syntaxcheck 00065| }) +syntaxcheck 00066| Concatenate (STS0, TEMP, Local2) +syntaxcheck 00067| _OSC (ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */, REVS, SIZE, Local2) +syntaxcheck | ^ +syntaxcheck | Remark 2184: Unknown UUID string +syntaxcheck 00068| } +syntaxcheck 00069| +syntaxcheck 00070| Method (_OSC, 4, NotSerialized) // _OSC: Operating System Capabilities +syntaxcheck ========================================================== syntaxcheck FAILED [LOW] AMLAsmASL_MSG_SERIALIZED_REQUIRED: Test 1, syntaxcheck Assembler remark in line 70 syntaxcheck Line | AML source @@ -981,6 +995,20 @@ syntaxcheck 00075| CreateDWordField (Arg0, 0x04, IID1) syntaxcheck 00076| CreateDWordField (Arg0, 0x08, IID2) syntaxcheck 00077| CreateDWordField (Arg0, 0x0C, IID3) syntaxcheck 00078| Name (UID0, ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */) +syntaxcheck | ^ +syntaxcheck | Remark 2184: Unknown UUID string +syntaxcheck 00079| CreateDWordField (UID0, 0x00, EID0) +syntaxcheck 00080| CreateDWordField (UID0, 0x04, EID1) +syntaxcheck 00081| CreateDWordField (UID0, 0x08, EID2) +syntaxcheck ========================================================== +syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in +syntaxcheck line 78 +syntaxcheck Line | AML source +syntaxcheck ---------------------------------------------------------- +syntaxcheck 00075| CreateDWordField (Arg0, 0x04, IID1) +syntaxcheck 00076| CreateDWordField (Arg0, 0x08, IID2) +syntaxcheck 00077| CreateDWordField (Arg0, 0x0C, IID3) +syntaxcheck 00078| Name (UID0, ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */) syntaxcheck | ^ syntaxcheck | Remark 2173: Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_PR.CPU0._OSC) syntaxcheck 00079| CreateDWordField (UID0, 0x00, EID0) @@ -1037,6 +1065,20 @@ syntaxcheck thread enters the method and blocks and then a second syntaxcheck thread also executes the method, ending up in two attempts syntaxcheck to create the object and causing a failure. syntaxcheck +syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in +syntaxcheck line 140 +syntaxcheck Line | AML source +syntaxcheck ---------------------------------------------------------- +syntaxcheck 00137| 0x00, 0x00, 0x00, 0x00 // .... +syntaxcheck 00138| }) +syntaxcheck 00139| Concatenate (STS1, TEMP, Local2) +syntaxcheck 00140| _OSC (ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */, REVS, SIZE, Local2) +syntaxcheck | ^ +syntaxcheck | Remark 2184: Unknown UUID string +syntaxcheck 00141| } +syntaxcheck 00142| +syntaxcheck 00143| Method (_OSC, 4, NotSerialized) // _OSC: Operating System Capabilities +syntaxcheck ========================================================== syntaxcheck FAILED [LOW] AMLAsmASL_MSG_SERIALIZED_REQUIRED: Test 1, syntaxcheck Assembler remark in line 143 syntaxcheck Line | AML source @@ -1067,6 +1109,20 @@ syntaxcheck 00148| CreateDWordField (Arg0, 0x04, IID1) syntaxcheck 00149| CreateDWordField (Arg0, 0x08, IID2) syntaxcheck 00150| CreateDWordField (Arg0, 0x0C, IID3) syntaxcheck 00151| Name (UID1, ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */) +syntaxcheck | ^ +syntaxcheck | Remark 2184: Unknown UUID string +syntaxcheck 00152| CreateDWordField (UID1, 0x00, EID0) +syntaxcheck 00153| CreateDWordField (UID1, 0x04, EID1) +syntaxcheck 00154| CreateDWordField (UID1, 0x08, EID2) +syntaxcheck ========================================================== +syntaxcheck FAILED [LOW] AMLAsmUnknown: Test 1, Assembler remark in +syntaxcheck line 151 +syntaxcheck Line | AML source +syntaxcheck ---------------------------------------------------------- +syntaxcheck 00148| CreateDWordField (Arg0, 0x04, IID1) +syntaxcheck 00149| CreateDWordField (Arg0, 0x08, IID2) +syntaxcheck 00150| CreateDWordField (Arg0, 0x0C, IID3) +syntaxcheck 00151| Name (UID1, ToUUID ("4077a616-290c-47be-9ebd-d87058713953") /* Unknown UUID */) syntaxcheck | ^ syntaxcheck | Remark 2173: Creation of named objects within a method is highly inefficient, use globals or method local variables instead (\_PR.CPU1._OSC) syntaxcheck 00152| CreateDWordField (UID1, 0x00, EID0) @@ -1101,11 +1157,11 @@ syntaxcheck 00189| Load (CST1, HC1) /* \_PR_.CPU1.HC1_ * syntaxcheck 00190| } syntaxcheck 00191| } syntaxcheck ========================================================== -syntaxcheck Table SSDT (5) reassembly: Found 0 errors, 0 warnings, 10 +syntaxcheck Table SSDT (5) reassembly: Found 0 errors, 0 warnings, 14 syntaxcheck remarks. syntaxcheck syntaxcheck syntaxcheck ========================================================== -syntaxcheck 2 passed, 67 failed, 0 warning, 0 aborted, 0 skipped, 0 +syntaxcheck 2 passed, 71 failed, 0 warning, 0 aborted, 0 skipped, 0 syntaxcheck info only. syntaxcheck ==========================================================