diff mbox series

[1/2] doc: add new --dump-acpi-from-sysfs option

Message ID 20200619063049.27265-1-ivan.hu@canonical.com
State Accepted
Headers show
Series [1/2] doc: add new --dump-acpi-from-sysfs option | expand

Commit Message

Ivan Hu June 19, 2020, 6:30 a.m. UTC
This new option allows one to specify the dumping acpi log default from
syslfs.
For example,
fwts --dump --dump-acpi-from-sysfs

Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
---
 doc/fwts.1 | 3 +++
 1 file changed, 3 insertions(+)

Comments

Colin Ian King June 22, 2020, 2:09 p.m. UTC | #1
On 19/06/2020 07:30, Ivan Hu wrote:
> This new option allows one to specify the dumping acpi log default from
> syslfs.
> For example,
> fwts --dump --dump-acpi-from-sysfs
> 
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>  doc/fwts.1 | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/doc/fwts.1 b/doc/fwts.1
> index a2884dae..3cac7d58 100644
> --- a/doc/fwts.1
> +++ b/doc/fwts.1
> @@ -117,6 +117,9 @@ cpuinfo.log \- containing the output from cat /proc/cpuinfo
>  .br
>  README.txt \- containing a timestamp and kernel version information.
>  .TP
> +.B \-\-dump-acpi-from-sysfs

All - should be escaped, e.g.:

+.B \-\-dump\-acpi\-from\-sysfs


Can that be fixed before applying?

> +specify dumping acpi table log default from sysfs.
> +.TP
>  .B \-\-dumpfile=acpidump.log
>  load ACPI tables from output generated from acpidump or from sudo fwts \-\-dump.  The
>  latter is preferred as fwts \-\-dump is able to dump more tables than acpidump. This
> 
Acked-by: Colin Ian King <colin.king@canonical.com>
Alex Hung June 22, 2020, 5:35 p.m. UTC | #2
On 2020-06-19 12:30 a.m., Ivan Hu wrote:
> This new option allows one to specify the dumping acpi log default from
> syslfs.
> For example,
> fwts --dump --dump-acpi-from-sysfs
> 
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>  doc/fwts.1 | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/doc/fwts.1 b/doc/fwts.1
> index a2884dae..3cac7d58 100644
> --- a/doc/fwts.1
> +++ b/doc/fwts.1
> @@ -117,6 +117,9 @@ cpuinfo.log \- containing the output from cat /proc/cpuinfo
>  .br
>  README.txt \- containing a timestamp and kernel version information.
>  .TP
> +.B \-\-dump-acpi-from-sysfs
> +specify dumping acpi table log default from sysfs.
> +.TP
>  .B \-\-dumpfile=acpidump.log
>  load ACPI tables from output generated from acpidump or from sudo fwts \-\-dump.  The
>  latter is preferred as fwts \-\-dump is able to dump more tables than acpidump. This
> 


Acked-by: Alex Hung <alex.hung@canonical.com>
diff mbox series

Patch

diff --git a/doc/fwts.1 b/doc/fwts.1
index a2884dae..3cac7d58 100644
--- a/doc/fwts.1
+++ b/doc/fwts.1
@@ -117,6 +117,9 @@  cpuinfo.log \- containing the output from cat /proc/cpuinfo
 .br
 README.txt \- containing a timestamp and kernel version information.
 .TP
+.B \-\-dump-acpi-from-sysfs
+specify dumping acpi table log default from sysfs.
+.TP
 .B \-\-dumpfile=acpidump.log
 load ACPI tables from output generated from acpidump or from sudo fwts \-\-dump.  The
 latter is preferred as fwts \-\-dump is able to dump more tables than acpidump. This