| Message ID | 20200610004022.177152-1-alex.hung@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | cpu/msr: remove General Performance Counters | expand |
On 6/10/20 8:40 AM, Alex Hung wrote: > The registers are specific to a core, not a cpu package. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/cpu/msr/msr.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/cpu/msr/msr.c b/src/cpu/msr/msr.c > index 17864c0b..3a8722c2 100644 > --- a/src/cpu/msr/msr.c > +++ b/src/cpu/msr/msr.c > @@ -454,10 +454,13 @@ static const msr_info IA32_MSRs[] = { > { "VMX_TRUE_EXIT_CTLS", 0x0000048f, 0xffffffffffffffffULL, NULL }, > { "VMX_TRUE_ENTRY_CTLS", 0x00000490, 0xffffffffffffffffULL, NULL }, > { "VMX_VMFUNC", 0x00000491, 0xffffffffffffffffULL, NULL }, > + /* Do not check syscall MSRs, they will be different on > + * each CPU, so checking them across CPUs is incorrect > { "A_PMC4", 0x000004c5, 0xffffffffffffffffULL, NULL }, > { "A_PMC5", 0x000004c6, 0xffffffffffffffffULL, NULL }, > { "A_PMC6", 0x000004c7, 0xffffffffffffffffULL, NULL }, > { "A_PMC7", 0x000004c8, 0xffffffffffffffffULL, NULL }, > + */ > { "EFER", 0xc0000080, 0x0000000000000d01ULL, NULL }, > /* Do not check syscall MSRs, they will be different on > * each CPU, so checking them across CPUs is incorrect > Acked-by: Ivan Hu <ivan.hu@canonical.com>
On 10/06/2020 01:40, Alex Hung wrote: > The registers are specific to a core, not a cpu package. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/cpu/msr/msr.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/cpu/msr/msr.c b/src/cpu/msr/msr.c > index 17864c0b..3a8722c2 100644 > --- a/src/cpu/msr/msr.c > +++ b/src/cpu/msr/msr.c > @@ -454,10 +454,13 @@ static const msr_info IA32_MSRs[] = { > { "VMX_TRUE_EXIT_CTLS", 0x0000048f, 0xffffffffffffffffULL, NULL }, > { "VMX_TRUE_ENTRY_CTLS", 0x00000490, 0xffffffffffffffffULL, NULL }, > { "VMX_VMFUNC", 0x00000491, 0xffffffffffffffffULL, NULL }, > + /* Do not check syscall MSRs, they will be different on > + * each CPU, so checking them across CPUs is incorrect > { "A_PMC4", 0x000004c5, 0xffffffffffffffffULL, NULL }, > { "A_PMC5", 0x000004c6, 0xffffffffffffffffULL, NULL }, > { "A_PMC6", 0x000004c7, 0xffffffffffffffffULL, NULL }, > { "A_PMC7", 0x000004c8, 0xffffffffffffffffULL, NULL }, > + */ > { "EFER", 0xc0000080, 0x0000000000000d01ULL, NULL }, > /* Do not check syscall MSRs, they will be different on > * each CPU, so checking them across CPUs is incorrect > Acked-by: Colin Ian King <colin.king@canonical.com>
diff --git a/src/cpu/msr/msr.c b/src/cpu/msr/msr.c index 17864c0b..3a8722c2 100644 --- a/src/cpu/msr/msr.c +++ b/src/cpu/msr/msr.c @@ -454,10 +454,13 @@ static const msr_info IA32_MSRs[] = { { "VMX_TRUE_EXIT_CTLS", 0x0000048f, 0xffffffffffffffffULL, NULL }, { "VMX_TRUE_ENTRY_CTLS", 0x00000490, 0xffffffffffffffffULL, NULL }, { "VMX_VMFUNC", 0x00000491, 0xffffffffffffffffULL, NULL }, + /* Do not check syscall MSRs, they will be different on + * each CPU, so checking them across CPUs is incorrect { "A_PMC4", 0x000004c5, 0xffffffffffffffffULL, NULL }, { "A_PMC5", 0x000004c6, 0xffffffffffffffffULL, NULL }, { "A_PMC6", 0x000004c7, 0xffffffffffffffffULL, NULL }, { "A_PMC7", 0x000004c8, 0xffffffffffffffffULL, NULL }, + */ { "EFER", 0xc0000080, 0x0000000000000d01ULL, NULL }, /* Do not check syscall MSRs, they will be different on * each CPU, so checking them across CPUs is incorrect
The registers are specific to a core, not a cpu package. Signed-off-by: Alex Hung <alex.hung@canonical.com> --- src/cpu/msr/msr.c | 3 +++ 1 file changed, 3 insertions(+)