| Message ID | 20200609170740.52358-1-alex.hung@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | fwts-collect: depreciate ebda collection | expand |
On 09/06/2020 18:07, Alex Hung wrote: > EBDA is old and no longer available in modern systems. > > While at it, trailing spaces were also removed. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > doc/fwts-collect.1 | 4 ++-- > scripts/fwts-collect | 5 ++--- > 2 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/doc/fwts-collect.1 b/doc/fwts-collect.1 > index b1cf96ce..3bdd2ae8 100644 > --- a/doc/fwts-collect.1 > +++ b/doc/fwts-collect.1 > @@ -32,10 +32,10 @@ The tool > .B fwts-collect > collects logs and various system and firmware dumps into the gzip'd tar ball > fwts-logs.tar.gz which can then be added to bug reports. It collects data > -from /proc/iomem, /proc/mtrr, /proc/interrupts, IRQ counts from > +from /proc/iomem, /proc/mtrr, /proc/interrupts, IRQ counts from > /sys/firmware/acpi/interrupts and kernel logs. It also invokes fwts and > gathers ACPI tables, memorymaps, MultiProcessor table dumps, CMOS data, > -UEFI variables, EBDA region, kernel version and ACPI version information. > +UEFI variables, kernel version and ACPI version information. > .B > fwts > using sudo is required. > diff --git a/scripts/fwts-collect b/scripts/fwts-collect > index 4a3798f0..7123d2a9 100755 > --- a/scripts/fwts-collect > +++ b/scripts/fwts-collect > @@ -70,7 +70,7 @@ acpi_irq_dump() > echo "/sys/firmware/acpi/interrupts:" > echo " " > for I in /sys/firmware/acpi/interrupts/* > - do > + do > name=`basename $I` > echo -e "$name\t" `cat $I` > done > @@ -81,7 +81,7 @@ acpi_irq_dump() > while getopts "o:h" opt; > do > case $opt in > - h) show_help > + h) show_help > exit 0 > ;; > \?) > @@ -152,7 +152,6 @@ cp /var/log/kern.log kern.log > # > fwts --dump >& /dev/null > fwts cmosdump --log-format="" -r cmosdump.log >& /dev/null > -fwts ebdadump --log-format="" -r ebdadump.log >& /dev/null > fwts uefidump --log-format="" -r uefidump.log >& /dev/null > fwts memmapdump --log-format="" -r memmap.log >& /dev/null > fwts acpidump --log-format="" -r acpitables.log >& /dev/null > Yep, good idea. Colin
On 6/10/20 1:07 AM, Alex Hung wrote: > EBDA is old and no longer available in modern systems. > > While at it, trailing spaces were also removed. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > doc/fwts-collect.1 | 4 ++-- > scripts/fwts-collect | 5 ++--- > 2 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/doc/fwts-collect.1 b/doc/fwts-collect.1 > index b1cf96ce..3bdd2ae8 100644 > --- a/doc/fwts-collect.1 > +++ b/doc/fwts-collect.1 > @@ -32,10 +32,10 @@ The tool > .B fwts-collect > collects logs and various system and firmware dumps into the gzip'd tar ball > fwts-logs.tar.gz which can then be added to bug reports. It collects data > -from /proc/iomem, /proc/mtrr, /proc/interrupts, IRQ counts from > +from /proc/iomem, /proc/mtrr, /proc/interrupts, IRQ counts from > /sys/firmware/acpi/interrupts and kernel logs. It also invokes fwts and > gathers ACPI tables, memorymaps, MultiProcessor table dumps, CMOS data, > -UEFI variables, EBDA region, kernel version and ACPI version information. > +UEFI variables, kernel version and ACPI version information. > .B > fwts > using sudo is required. > diff --git a/scripts/fwts-collect b/scripts/fwts-collect > index 4a3798f0..7123d2a9 100755 > --- a/scripts/fwts-collect > +++ b/scripts/fwts-collect > @@ -70,7 +70,7 @@ acpi_irq_dump() > echo "/sys/firmware/acpi/interrupts:" > echo " " > for I in /sys/firmware/acpi/interrupts/* > - do > + do > name=`basename $I` > echo -e "$name\t" `cat $I` > done > @@ -81,7 +81,7 @@ acpi_irq_dump() > while getopts "o:h" opt; > do > case $opt in > - h) show_help > + h) show_help > exit 0 > ;; > \?) > @@ -152,7 +152,6 @@ cp /var/log/kern.log kern.log > # > fwts --dump >& /dev/null > fwts cmosdump --log-format="" -r cmosdump.log >& /dev/null > -fwts ebdadump --log-format="" -r ebdadump.log >& /dev/null > fwts uefidump --log-format="" -r uefidump.log >& /dev/null > fwts memmapdump --log-format="" -r memmap.log >& /dev/null > fwts acpidump --log-format="" -r acpitables.log >& /dev/null > Acked-by: Ivan Hu <ivan.hu@canonical.com>
On 09/06/2020 18:07, Alex Hung wrote: > EBDA is old and no longer available in modern systems. > > While at it, trailing spaces were also removed. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > doc/fwts-collect.1 | 4 ++-- > scripts/fwts-collect | 5 ++--- > 2 files changed, 4 insertions(+), 5 deletions(-) > > diff --git a/doc/fwts-collect.1 b/doc/fwts-collect.1 > index b1cf96ce..3bdd2ae8 100644 > --- a/doc/fwts-collect.1 > +++ b/doc/fwts-collect.1 > @@ -32,10 +32,10 @@ The tool > .B fwts-collect > collects logs and various system and firmware dumps into the gzip'd tar ball > fwts-logs.tar.gz which can then be added to bug reports. It collects data > -from /proc/iomem, /proc/mtrr, /proc/interrupts, IRQ counts from > +from /proc/iomem, /proc/mtrr, /proc/interrupts, IRQ counts from > /sys/firmware/acpi/interrupts and kernel logs. It also invokes fwts and > gathers ACPI tables, memorymaps, MultiProcessor table dumps, CMOS data, > -UEFI variables, EBDA region, kernel version and ACPI version information. > +UEFI variables, kernel version and ACPI version information. > .B > fwts > using sudo is required. > diff --git a/scripts/fwts-collect b/scripts/fwts-collect > index 4a3798f0..7123d2a9 100755 > --- a/scripts/fwts-collect > +++ b/scripts/fwts-collect > @@ -70,7 +70,7 @@ acpi_irq_dump() > echo "/sys/firmware/acpi/interrupts:" > echo " " > for I in /sys/firmware/acpi/interrupts/* > - do > + do > name=`basename $I` > echo -e "$name\t" `cat $I` > done > @@ -81,7 +81,7 @@ acpi_irq_dump() > while getopts "o:h" opt; > do > case $opt in > - h) show_help > + h) show_help > exit 0 > ;; > \?) > @@ -152,7 +152,6 @@ cp /var/log/kern.log kern.log > # > fwts --dump >& /dev/null > fwts cmosdump --log-format="" -r cmosdump.log >& /dev/null > -fwts ebdadump --log-format="" -r ebdadump.log >& /dev/null > fwts uefidump --log-format="" -r uefidump.log >& /dev/null > fwts memmapdump --log-format="" -r memmap.log >& /dev/null > fwts acpidump --log-format="" -r acpitables.log >& /dev/null > Acked-by: Colin Ian King <colin.king@canonical.com>
diff --git a/doc/fwts-collect.1 b/doc/fwts-collect.1 index b1cf96ce..3bdd2ae8 100644 --- a/doc/fwts-collect.1 +++ b/doc/fwts-collect.1 @@ -32,10 +32,10 @@ The tool .B fwts-collect collects logs and various system and firmware dumps into the gzip'd tar ball fwts-logs.tar.gz which can then be added to bug reports. It collects data -from /proc/iomem, /proc/mtrr, /proc/interrupts, IRQ counts from +from /proc/iomem, /proc/mtrr, /proc/interrupts, IRQ counts from /sys/firmware/acpi/interrupts and kernel logs. It also invokes fwts and gathers ACPI tables, memorymaps, MultiProcessor table dumps, CMOS data, -UEFI variables, EBDA region, kernel version and ACPI version information. +UEFI variables, kernel version and ACPI version information. .B fwts using sudo is required. diff --git a/scripts/fwts-collect b/scripts/fwts-collect index 4a3798f0..7123d2a9 100755 --- a/scripts/fwts-collect +++ b/scripts/fwts-collect @@ -70,7 +70,7 @@ acpi_irq_dump() echo "/sys/firmware/acpi/interrupts:" echo " " for I in /sys/firmware/acpi/interrupts/* - do + do name=`basename $I` echo -e "$name\t" `cat $I` done @@ -81,7 +81,7 @@ acpi_irq_dump() while getopts "o:h" opt; do case $opt in - h) show_help + h) show_help exit 0 ;; \?) @@ -152,7 +152,6 @@ cp /var/log/kern.log kern.log # fwts --dump >& /dev/null fwts cmosdump --log-format="" -r cmosdump.log >& /dev/null -fwts ebdadump --log-format="" -r ebdadump.log >& /dev/null fwts uefidump --log-format="" -r uefidump.log >& /dev/null fwts memmapdump --log-format="" -r memmap.log >& /dev/null fwts acpidump --log-format="" -r acpitables.log >& /dev/null
EBDA is old and no longer available in modern systems. While at it, trailing spaces were also removed. Signed-off-by: Alex Hung <alex.hung@canonical.com> --- doc/fwts-collect.1 | 4 ++-- scripts/fwts-collect | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-)