diff mbox series

[06/10] dmicheck: add CXL Flexbus 1.0 to slot type in type 9

Message ID 20200521023802.1553594-6-alex.hung@canonical.com
State Accepted
Headers show
Series [01/10] dmicheck: test feature flags in type 2 | expand

Commit Message

Alex Hung May 21, 2020, 2:37 a.m. UTC 
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/dmi/dmicheck/dmicheck.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Colin Ian King May 26, 2020, 4:30 p.m. UTC | #1 
On 21/05/2020 03:37, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index 5fe0283c..d163bed3 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1420,6 +1420,7 @@ static void dmicheck_entry(fwts_framework *fw,
>  				break;
>  			dmi_str_check(fw, table, addr, "Slot Designation", hdr, 0x4);
>  			if (!(((data[0x5] >= 0x01) && (data[0x5] <= 0x23)) ||
> +			      (data[0x5] == 0x30) ||
>  			      ((data[0x5] >= 0xa0) && (data[0x5] <= 0xbd))))
>  				fwts_failed(fw, LOG_LEVEL_HIGH, DMI_VALUE_OUT_OF_RANGE,
>  					"Out of range value 0x%2.2" PRIx8 " "
> 

Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu May 28, 2020, 6:31 a.m. UTC | #2 
On 5/21/20 10:37 AM, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index 5fe0283c..d163bed3 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1420,6 +1420,7 @@ static void dmicheck_entry(fwts_framework *fw,
>  				break;
>  			dmi_str_check(fw, table, addr, "Slot Designation", hdr, 0x4);
>  			if (!(((data[0x5] >= 0x01) && (data[0x5] <= 0x23)) ||
> +			      (data[0x5] == 0x30) ||
>  			      ((data[0x5] >= 0xa0) && (data[0x5] <= 0xbd))))
>  				fwts_failed(fw, LOG_LEVEL_HIGH, DMI_VALUE_OUT_OF_RANGE,
>  					"Out of range value 0x%2.2" PRIx8 " "
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
index 5fe0283c..d163bed3 100644
--- a/src/dmi/dmicheck/dmicheck.c
+++ b/src/dmi/dmicheck/dmicheck.c
@@ -1420,6 +1420,7 @@  static void dmicheck_entry(fwts_framework *fw,
 				break;
 			dmi_str_check(fw, table, addr, "Slot Designation", hdr, 0x4);
 			if (!(((data[0x5] >= 0x01) && (data[0x5] <= 0x23)) ||
+			      (data[0x5] == 0x30) ||
 			      ((data[0x5] >= 0xa0) && (data[0x5] <= 0xbd))))
 				fwts_failed(fw, LOG_LEVEL_HIGH, DMI_VALUE_OUT_OF_RANGE,
 					"Out of range value 0x%2.2" PRIx8 " "