diff mbox series

[05/10] dmicheck: fix typo in type 8

Message ID 20200521023802.1553594-5-alex.hung@canonical.com
State Accepted
Headers show
Series [01/10] dmicheck: test feature flags in type 2 | expand

Commit Message

Alex Hung May 21, 2020, 2:37 a.m. UTC 
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/dmi/dmicheck/dmicheck.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Colin Ian King May 26, 2020, 4:29 p.m. UTC | #1 
On 21/05/2020 03:37, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index dd2e5d59..5fe0283c 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1401,7 +1401,7 @@ static void dmicheck_entry(fwts_framework *fw,
>  					"(range allowed 0x00..0x23, 0xa0..0xa4, 0xff) "
>  					"while accessing entry '%s' @ "
>  					"0x%8.8" PRIx32 ", field '%s', offset 0x%2.2x",
> -					data[0x7], table, addr, "Internal Connector Type", 0x7);
> +					data[0x7], table, addr, "External Connector Type", 0x7);
>  
>  			if (!((data[0x8] <= 0x23) ||
>  			      (data[0x8] == 0xff) ||
> 
Good catch!

Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu May 28, 2020, 6:30 a.m. UTC | #2 
On 5/21/20 10:37 AM, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index dd2e5d59..5fe0283c 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1401,7 +1401,7 @@ static void dmicheck_entry(fwts_framework *fw,
>  					"(range allowed 0x00..0x23, 0xa0..0xa4, 0xff) "
>  					"while accessing entry '%s' @ "
>  					"0x%8.8" PRIx32 ", field '%s', offset 0x%2.2x",
> -					data[0x7], table, addr, "Internal Connector Type", 0x7);
> +					data[0x7], table, addr, "External Connector Type", 0x7);
>  
>  			if (!((data[0x8] <= 0x23) ||
>  			      (data[0x8] == 0xff) ||
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
index dd2e5d59..5fe0283c 100644
--- a/src/dmi/dmicheck/dmicheck.c
+++ b/src/dmi/dmicheck/dmicheck.c
@@ -1401,7 +1401,7 @@  static void dmicheck_entry(fwts_framework *fw,
 					"(range allowed 0x00..0x23, 0xa0..0xa4, 0xff) "
 					"while accessing entry '%s' @ "
 					"0x%8.8" PRIx32 ", field '%s', offset 0x%2.2x",
-					data[0x7], table, addr, "Internal Connector Type", 0x7);
+					data[0x7], table, addr, "External Connector Type", 0x7);
 
 			if (!((data[0x8] <= 0x23) ||
 			      (data[0x8] == 0xff) ||