diff mbox series

[01/10] dmicheck: test feature flags in type 2

Message ID 20200521023802.1553594-1-alex.hung@canonical.com
State Accepted
Headers show
Series [01/10] dmicheck: test feature flags in type 2 | expand

Commit Message

Alex Hung May 21, 2020, 2:37 a.m. UTC 
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/dmi/dmicheck/dmicheck.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Colin Ian King May 26, 2020, 4:19 p.m. UTC | #1 
On 21/05/2020 03:37, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index c53bf163..46d7e620 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1260,6 +1260,7 @@ static void dmicheck_entry(fwts_framework *fw,
>  			dmi_str_check(fw, table, addr, "Asset Tag", hdr, 0x8);
>  			if (hdr->length < 0x0f)
>  				break;
> +			dmi_reserved_bits_check(fw, table, addr, "Feature Flags", hdr, sizeof(uint8_t), 0x9, 5, 7);
>  			dmi_str_check(fw, table, addr, "Location In Chassis", hdr, 0xa);
>  			dmi_min_max_uint8_check(fw, table, addr, "Type", hdr, 0xd, 0x1, 0xd);
>  			break;
> 
Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu May 28, 2020, 6:28 a.m. UTC | #2 
On 5/21/20 10:37 AM, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index c53bf163..46d7e620 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1260,6 +1260,7 @@ static void dmicheck_entry(fwts_framework *fw,
>  			dmi_str_check(fw, table, addr, "Asset Tag", hdr, 0x8);
>  			if (hdr->length < 0x0f)
>  				break;
> +			dmi_reserved_bits_check(fw, table, addr, "Feature Flags", hdr, sizeof(uint8_t), 0x9, 5, 7);
>  			dmi_str_check(fw, table, addr, "Location In Chassis", hdr, 0xa);
>  			dmi_min_max_uint8_check(fw, table, addr, "Type", hdr, 0xd, 0x1, 0xd);
>  			break;
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
index c53bf163..46d7e620 100644
--- a/src/dmi/dmicheck/dmicheck.c
+++ b/src/dmi/dmicheck/dmicheck.c
@@ -1260,6 +1260,7 @@  static void dmicheck_entry(fwts_framework *fw,
 			dmi_str_check(fw, table, addr, "Asset Tag", hdr, 0x8);
 			if (hdr->length < 0x0f)
 				break;
+			dmi_reserved_bits_check(fw, table, addr, "Feature Flags", hdr, sizeof(uint8_t), 0x9, 5, 7);
 			dmi_str_check(fw, table, addr, "Location In Chassis", hdr, 0xa);
 			dmi_min_max_uint8_check(fw, table, addr, "Type", hdr, 0xd, 0x1, 0xd);
 			break;