| Message ID | 20200519170355.1369493-1-alex.hung@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | acpi/method: fix incorrect error messages for _SUB tests | expand |
On 19/05/2020 18:03, Alex Hung wrote: > _SUB returns only a string (buffer), no an integer. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/lib/src/fwts_acpi_object_eval.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/lib/src/fwts_acpi_object_eval.c b/src/lib/src/fwts_acpi_object_eval.c > index 7f41fa52..d72aa460 100644 > --- a/src/lib/src/fwts_acpi_object_eval.c > +++ b/src/lib/src/fwts_acpi_object_eval.c > @@ -2187,7 +2187,7 @@ void fwts_method_test_SUB_return( > FWTS_UNUSED(private); > > if (obj == NULL) { > - fwts_method_failed_null_object(fw, name, "a buffer or integer"); > + fwts_method_failed_null_object(fw, name, "a buffer"); > return; > } > > @@ -2212,7 +2212,7 @@ void fwts_method_test_SUB_return( > } > else { > fwts_failed(fw, LOG_LEVEL_MEDIUM, "Method_SUBBadReturnType", > - "Method _SUB did not return a string or an integer."); > + "Method _SUB did not return a string."); > } > } > > Acked-by: Colin Ian King <colin.king@canonical.com>
On 5/20/20 1:03 AM, Alex Hung wrote: > _SUB returns only a string (buffer), no an integer. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/lib/src/fwts_acpi_object_eval.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/lib/src/fwts_acpi_object_eval.c b/src/lib/src/fwts_acpi_object_eval.c > index 7f41fa52..d72aa460 100644 > --- a/src/lib/src/fwts_acpi_object_eval.c > +++ b/src/lib/src/fwts_acpi_object_eval.c > @@ -2187,7 +2187,7 @@ void fwts_method_test_SUB_return( > FWTS_UNUSED(private); > > if (obj == NULL) { > - fwts_method_failed_null_object(fw, name, "a buffer or integer"); > + fwts_method_failed_null_object(fw, name, "a buffer"); > return; > } > > @@ -2212,7 +2212,7 @@ void fwts_method_test_SUB_return( > } > else { > fwts_failed(fw, LOG_LEVEL_MEDIUM, "Method_SUBBadReturnType", > - "Method _SUB did not return a string or an integer."); > + "Method _SUB did not return a string."); > } > } > > Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/src/lib/src/fwts_acpi_object_eval.c b/src/lib/src/fwts_acpi_object_eval.c index 7f41fa52..d72aa460 100644 --- a/src/lib/src/fwts_acpi_object_eval.c +++ b/src/lib/src/fwts_acpi_object_eval.c @@ -2187,7 +2187,7 @@ void fwts_method_test_SUB_return( FWTS_UNUSED(private); if (obj == NULL) { - fwts_method_failed_null_object(fw, name, "a buffer or integer"); + fwts_method_failed_null_object(fw, name, "a buffer"); return; } @@ -2212,7 +2212,7 @@ void fwts_method_test_SUB_return( } else { fwts_failed(fw, LOG_LEVEL_MEDIUM, "Method_SUBBadReturnType", - "Method _SUB did not return a string or an integer."); + "Method _SUB did not return a string."); } }
_SUB returns only a string (buffer), no an integer. Signed-off-by: Alex Hung <alex.hung@canonical.com> --- src/lib/src/fwts_acpi_object_eval.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)