diff mbox series

[1/2] acpi/method: add tests for _SLI method

Message ID 20200516021745.1199863-1-alex.hung@canonical.com
State Accepted
Headers show
Series [1/2] acpi/method: add tests for _SLI method | expand

Commit Message

Alex Hung May 16, 2020, 2:17 a.m. UTC
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/acpi/method/method.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

Ivan Hu May 22, 2020, 3:43 a.m. UTC | #1
On 5/16/20 10:17 AM, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index cfabcaa0..9463b2a8 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -1106,6 +1106,12 @@ static int method_test_PXM(fwts_framework *fw)
>  		"_PXM", NULL, 0, fwts_method_test_integer_return, NULL);
>  }
>  
> +static int method_test_SLI(fwts_framework *fw)
> +{
> +	return method_evaluate_method(fw, METHOD_OPTIONAL,
> +		"_SLI", NULL, 0, fwts_method_test_buffer_return, NULL);
> +}
> +
>  /* Section 6.2.17 _CCA */
>  static int method_test_CCA(fwts_framework *fw)
>  {
> @@ -5571,7 +5577,7 @@ static fwts_framework_minor_test method_tests[] = {
>  	{ method_test_PRS, "Test _PRS (Possible Resource Settings)." },
>  	{ method_test_PRT, "Test _PRT (PCI Routing Table)." },
>  	{ method_test_PXM, "Test _PXM (Proximity)." },
> -	/* { method_test_SLI, "Test _SLI (System Locality Information)." }, */
> +	{ method_test_SLI, "Test _SLI (System Locality Information)." },
>  	/* { method_test_SRS, "Test _SRS (Set Resource Settings)." }, */
>  	{ method_test_CCA, "Test _CCA (Cache Coherency Attribute)." },
>  
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
Colin Ian King May 26, 2020, 3:49 p.m. UTC | #2
On 16/05/2020 03:17, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/method/method.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index cfabcaa0..9463b2a8 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -1106,6 +1106,12 @@ static int method_test_PXM(fwts_framework *fw)
>  		"_PXM", NULL, 0, fwts_method_test_integer_return, NULL);
>  }
>  
> +static int method_test_SLI(fwts_framework *fw)
> +{
> +	return method_evaluate_method(fw, METHOD_OPTIONAL,
> +		"_SLI", NULL, 0, fwts_method_test_buffer_return, NULL);
> +}
> +
>  /* Section 6.2.17 _CCA */
>  static int method_test_CCA(fwts_framework *fw)
>  {
> @@ -5571,7 +5577,7 @@ static fwts_framework_minor_test method_tests[] = {
>  	{ method_test_PRS, "Test _PRS (Possible Resource Settings)." },
>  	{ method_test_PRT, "Test _PRT (PCI Routing Table)." },
>  	{ method_test_PXM, "Test _PXM (Proximity)." },
> -	/* { method_test_SLI, "Test _SLI (System Locality Information)." }, */
> +	{ method_test_SLI, "Test _SLI (System Locality Information)." },
>  	/* { method_test_SRS, "Test _SRS (Set Resource Settings)." }, */
>  	{ method_test_CCA, "Test _CCA (Cache Coherency Attribute)." },
>  
> 
Acked-by: Colin Ian King <colin.king@canonical.com>
diff mbox series

Patch

diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
index cfabcaa0..9463b2a8 100644
--- a/src/acpi/method/method.c
+++ b/src/acpi/method/method.c
@@ -1106,6 +1106,12 @@  static int method_test_PXM(fwts_framework *fw)
 		"_PXM", NULL, 0, fwts_method_test_integer_return, NULL);
 }
 
+static int method_test_SLI(fwts_framework *fw)
+{
+	return method_evaluate_method(fw, METHOD_OPTIONAL,
+		"_SLI", NULL, 0, fwts_method_test_buffer_return, NULL);
+}
+
 /* Section 6.2.17 _CCA */
 static int method_test_CCA(fwts_framework *fw)
 {
@@ -5571,7 +5577,7 @@  static fwts_framework_minor_test method_tests[] = {
 	{ method_test_PRS, "Test _PRS (Possible Resource Settings)." },
 	{ method_test_PRT, "Test _PRT (PCI Routing Table)." },
 	{ method_test_PXM, "Test _PXM (Proximity)." },
-	/* { method_test_SLI, "Test _SLI (System Locality Information)." }, */
+	{ method_test_SLI, "Test _SLI (System Locality Information)." },
 	/* { method_test_SRS, "Test _SRS (Set Resource Settings)." }, */
 	{ method_test_CCA, "Test _CCA (Cache Coherency Attribute)." },