| Message ID | 20200515205628.1039962-1-alex.hung@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] acpi/method: add tests for _MAT method | expand |
On 15/05/2020 21:56, Alex Hung wrote: > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/acpi/method/method.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c > index 0bf376fd..b7e9177c 100644 > --- a/src/acpi/method/method.c > +++ b/src/acpi/method/method.c > @@ -132,7 +132,7 @@ > * _LSI Y > * _LSR N > * _LSW N > - * _MAT N > + * _MAT Y > * _MBM Y > * _MLS Y > * _MSG Y > @@ -874,6 +874,12 @@ static int method_test_CRS(fwts_framework *fw) > "_CRS", NULL, 0, method_test_CRS_return, "_CRS"); > } > > +static int method_test_MAT(fwts_framework *fw) > +{ > + return method_evaluate_method(fw, METHOD_OPTIONAL, > + "_MAT", NULL, 0, fwts_method_test_buffer_return, NULL); > +} > + > static int method_test_PRS(fwts_framework *fw) > { > /* Re-use the _CRS checking on the returned buffer */ > @@ -5627,7 +5633,7 @@ static fwts_framework_minor_test method_tests[] = { > { method_test_GSB, "Test _GSB (Global System Interrupt Base)." }, > { method_test_HPP, "Test _HPP (Hot Plug Parameters)." }, > /* { method_test_HPX, "Test _HPX (Hot Plug Extensions)." }, */ > - /* { method_test_MAT, "Test _MAT (Multiple APIC Table Entry)." }, */ > + { method_test_MAT, "Test _MAT (Multiple APIC Table Entry)." }, > { method_test_PRS, "Test _PRS (Possible Resource Settings)." }, > { method_test_PRT, "Test _PRT (PCI Routing Table)." }, > { method_test_PXM, "Test _PXM (Proximity)." }, > Acked-by: Colin Ian King <colin.king@canonical.com>
On 5/16/20 4:56 AM, Alex Hung wrote: > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/acpi/method/method.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c > index 0bf376fd..b7e9177c 100644 > --- a/src/acpi/method/method.c > +++ b/src/acpi/method/method.c > @@ -132,7 +132,7 @@ > * _LSI Y > * _LSR N > * _LSW N > - * _MAT N > + * _MAT Y > * _MBM Y > * _MLS Y > * _MSG Y > @@ -874,6 +874,12 @@ static int method_test_CRS(fwts_framework *fw) > "_CRS", NULL, 0, method_test_CRS_return, "_CRS"); > } > > +static int method_test_MAT(fwts_framework *fw) > +{ > + return method_evaluate_method(fw, METHOD_OPTIONAL, > + "_MAT", NULL, 0, fwts_method_test_buffer_return, NULL); > +} > + > static int method_test_PRS(fwts_framework *fw) > { > /* Re-use the _CRS checking on the returned buffer */ > @@ -5627,7 +5633,7 @@ static fwts_framework_minor_test method_tests[] = { > { method_test_GSB, "Test _GSB (Global System Interrupt Base)." }, > { method_test_HPP, "Test _HPP (Hot Plug Parameters)." }, > /* { method_test_HPX, "Test _HPX (Hot Plug Extensions)." }, */ > - /* { method_test_MAT, "Test _MAT (Multiple APIC Table Entry)." }, */ > + { method_test_MAT, "Test _MAT (Multiple APIC Table Entry)." }, > { method_test_PRS, "Test _PRS (Possible Resource Settings)." }, > { method_test_PRT, "Test _PRT (PCI Routing Table)." }, > { method_test_PXM, "Test _PXM (Proximity)." }, > Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c index 0bf376fd..b7e9177c 100644 --- a/src/acpi/method/method.c +++ b/src/acpi/method/method.c @@ -132,7 +132,7 @@ * _LSI Y * _LSR N * _LSW N - * _MAT N + * _MAT Y * _MBM Y * _MLS Y * _MSG Y @@ -874,6 +874,12 @@ static int method_test_CRS(fwts_framework *fw) "_CRS", NULL, 0, method_test_CRS_return, "_CRS"); } +static int method_test_MAT(fwts_framework *fw) +{ + return method_evaluate_method(fw, METHOD_OPTIONAL, + "_MAT", NULL, 0, fwts_method_test_buffer_return, NULL); +} + static int method_test_PRS(fwts_framework *fw) { /* Re-use the _CRS checking on the returned buffer */ @@ -5627,7 +5633,7 @@ static fwts_framework_minor_test method_tests[] = { { method_test_GSB, "Test _GSB (Global System Interrupt Base)." }, { method_test_HPP, "Test _HPP (Hot Plug Parameters)." }, /* { method_test_HPX, "Test _HPX (Hot Plug Extensions)." }, */ - /* { method_test_MAT, "Test _MAT (Multiple APIC Table Entry)." }, */ + { method_test_MAT, "Test _MAT (Multiple APIC Table Entry)." }, { method_test_PRS, "Test _PRS (Possible Resource Settings)." }, { method_test_PRT, "Test _PRT (PCI Routing Table)." }, { method_test_PXM, "Test _PXM (Proximity)." },
Signed-off-by: Alex Hung <alex.hung@canonical.com> --- src/acpi/method/method.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)