| Message ID | 20200513212715.602832-1-alex.hung@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | acpi/time: fix passing method name instead of NULL | expand |
On 5/14/20 5:27 AM, Alex Hung wrote: > fwts_method_test_passed_failed_return requres method name in private > argument. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/acpi/devices/time/time.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/acpi/devices/time/time.c b/src/acpi/devices/time/time.c > index 14c1d3bd..c60264c2 100644 > --- a/src/acpi/devices/time/time.c > +++ b/src/acpi/devices/time/time.c > @@ -270,7 +270,7 @@ static int method_test_STP(fwts_framework *fw) > arg[1].Integer.Value = 0; /* wake up instantly */ > > return fwts_evaluate_method(fw, METHOD_OPTIONAL, &device, > - "_STP", arg, 2, fwts_method_test_passed_failed_return, NULL); > + "_STP", arg, 2, fwts_method_test_passed_failed_return, "_STP"); > } > > static int method_test_STV(fwts_framework *fw) > @@ -283,7 +283,7 @@ static int method_test_STV(fwts_framework *fw) > arg[1].Integer.Value = 100; /* timer value */ > > return fwts_evaluate_method(fw, METHOD_MANDATORY, &device, > - "_STV", arg, 2, fwts_method_test_passed_failed_return, NULL); > + "_STV", arg, 2, fwts_method_test_passed_failed_return, "_STV"); > } > > static int method_test_TIP(fwts_framework *fw) > Acked-by: Ivan Hu <ivan.hu@canonical.com>
On 13/05/2020 22:27, Alex Hung wrote: > fwts_method_test_passed_failed_return requres method name in private > argument. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/acpi/devices/time/time.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/acpi/devices/time/time.c b/src/acpi/devices/time/time.c > index 14c1d3bd..c60264c2 100644 > --- a/src/acpi/devices/time/time.c > +++ b/src/acpi/devices/time/time.c > @@ -270,7 +270,7 @@ static int method_test_STP(fwts_framework *fw) > arg[1].Integer.Value = 0; /* wake up instantly */ > > return fwts_evaluate_method(fw, METHOD_OPTIONAL, &device, > - "_STP", arg, 2, fwts_method_test_passed_failed_return, NULL); > + "_STP", arg, 2, fwts_method_test_passed_failed_return, "_STP"); > } > > static int method_test_STV(fwts_framework *fw) > @@ -283,7 +283,7 @@ static int method_test_STV(fwts_framework *fw) > arg[1].Integer.Value = 100; /* timer value */ > > return fwts_evaluate_method(fw, METHOD_MANDATORY, &device, > - "_STV", arg, 2, fwts_method_test_passed_failed_return, NULL); > + "_STV", arg, 2, fwts_method_test_passed_failed_return, "_STV"); > } > > static int method_test_TIP(fwts_framework *fw) > Acked-by: Colin Ian King <colin.king@canonical.com>
diff --git a/src/acpi/devices/time/time.c b/src/acpi/devices/time/time.c index 14c1d3bd..c60264c2 100644 --- a/src/acpi/devices/time/time.c +++ b/src/acpi/devices/time/time.c @@ -270,7 +270,7 @@ static int method_test_STP(fwts_framework *fw) arg[1].Integer.Value = 0; /* wake up instantly */ return fwts_evaluate_method(fw, METHOD_OPTIONAL, &device, - "_STP", arg, 2, fwts_method_test_passed_failed_return, NULL); + "_STP", arg, 2, fwts_method_test_passed_failed_return, "_STP"); } static int method_test_STV(fwts_framework *fw) @@ -283,7 +283,7 @@ static int method_test_STV(fwts_framework *fw) arg[1].Integer.Value = 100; /* timer value */ return fwts_evaluate_method(fw, METHOD_MANDATORY, &device, - "_STV", arg, 2, fwts_method_test_passed_failed_return, NULL); + "_STV", arg, 2, fwts_method_test_passed_failed_return, "_STV"); } static int method_test_TIP(fwts_framework *fw)
fwts_method_test_passed_failed_return requres method name in private argument. Signed-off-by: Alex Hung <alex.hung@canonical.com> --- src/acpi/devices/time/time.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)