| Message ID | 20200513210214.601243-1-alex.hung@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | acpi/method: revise _CPC's error messages | expand |
On 13/05/2020 22:02, Alex Hung wrote: > Change _REV to revision. _REV is also a predefined object in ACPI spec. > This is to remove confusion between _CPC's field and _REV object. > > There are no functional changes. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/acpi/method/method.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c > index 7ab72ba7..637f99bb 100644 > --- a/src/acpi/method/method.c > +++ b/src/acpi/method/method.c > @@ -1854,7 +1854,7 @@ static void method_test_CPC_return( > } else { > fwts_failed(fw, LOG_LEVEL_HIGH, > "Method_CPCBadRevision", > - "_CPC's _REV is incorrect, " > + "_CPC's revision is incorrect, " > "expecting 1 ,2 or 3, got 0x%" PRIx8 , revision); > > return; > Acked-by: Colin Ian King <colin.king@canonical.com>
On 5/14/20 5:02 AM, Alex Hung wrote: > Change _REV to revision. _REV is also a predefined object in ACPI spec. > This is to remove confusion between _CPC's field and _REV object. > > There are no functional changes. > > Signed-off-by: Alex Hung <alex.hung@canonical.com> > --- > src/acpi/method/method.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c > index 7ab72ba7..637f99bb 100644 > --- a/src/acpi/method/method.c > +++ b/src/acpi/method/method.c > @@ -1854,7 +1854,7 @@ static void method_test_CPC_return( > } else { > fwts_failed(fw, LOG_LEVEL_HIGH, > "Method_CPCBadRevision", > - "_CPC's _REV is incorrect, " > + "_CPC's revision is incorrect, " > "expecting 1 ,2 or 3, got 0x%" PRIx8 , revision); > > return; > Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c index 7ab72ba7..637f99bb 100644 --- a/src/acpi/method/method.c +++ b/src/acpi/method/method.c @@ -1854,7 +1854,7 @@ static void method_test_CPC_return( } else { fwts_failed(fw, LOG_LEVEL_HIGH, "Method_CPCBadRevision", - "_CPC's _REV is incorrect, " + "_CPC's revision is incorrect, " "expecting 1 ,2 or 3, got 0x%" PRIx8 , revision); return;
Change _REV to revision. _REV is also a predefined object in ACPI spec. This is to remove confusion between _CPC's field and _REV object. There are no functional changes. Signed-off-by: Alex Hung <alex.hung@canonical.com> --- src/acpi/method/method.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)