diff mbox series

[V4] klog.json: add a "Unable ... IOMMU perf counter" message

Message ID 20200428184149.293255-1-alex.hung@canonical.com
State Accepted
Headers show
Series [V4] klog.json: add a "Unable ... IOMMU perf counter" message | expand

Commit Message

Alex Hung April 28, 2020, 6:41 p.m. UTC
This message shows performance counters are not supported on AMD IOMMU
hardware.

More info @ https://lore.kernel.org/lkml/20180727102710.GA6738@8bytes.org/

Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---

[V2] update advise and commit comments
[V3] change spec -> specifications
[V4] should not be -> should be

 data/klog.json | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Colin Ian King April 28, 2020, 6:45 p.m. UTC | #1
On 28/04/2020 19:41, Alex Hung wrote:
> This message shows performance counters are not supported on AMD IOMMU
> hardware.
> 
> More info @ https://lore.kernel.org/lkml/20180727102710.GA6738@8bytes.org/
> 
> Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
> 
> [V2] update advise and commit comments
> [V3] change spec -> specifications
> [V4] should not be -> should be
> 
>  data/klog.json | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/data/klog.json b/data/klog.json
> index 15043658..cdb93554 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2697,6 +2697,13 @@ atform Communications Channel Table (PCCT) and find the PCC subspace communicati
>      "advice": "BIOS setup is configured to enable IOMMU, but BIOS lacks IVRS table that is describing which is the address of IOMMU",
>      "label": "KlogAmdIommuNoIVRS"
>    },
> +  {
> +    "compare_mode": "string",
> +    "log_level": "LOG_LEVEL_MEDIUM",
> +    "pattern": "Unable to read/write to IOMMU perf counter",
> +    "advice": "AMD IOMMU performance counter is inaccessible and public specifications do not have information on how it should be supported",
> +    "label": "KlogAmdIommuPCNotSupported"
> +  },
>    {
>      "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
> 

Thanks for the V4 fix up.

Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu April 30, 2020, 7:15 a.m. UTC | #2
On 4/29/20 2:41 AM, Alex Hung wrote:
> This message shows performance counters are not supported on AMD IOMMU
> hardware.
> 
> More info @ https://lore.kernel.org/lkml/20180727102710.GA6738@8bytes.org/
> 
> Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
> 
> [V2] update advise and commit comments
> [V3] change spec -> specifications
> [V4] should not be -> should be
> 
>  data/klog.json | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/data/klog.json b/data/klog.json
> index 15043658..cdb93554 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2697,6 +2697,13 @@ atform Communications Channel Table (PCCT) and find the PCC subspace communicati
>      "advice": "BIOS setup is configured to enable IOMMU, but BIOS lacks IVRS table that is describing which is the address of IOMMU",
>      "label": "KlogAmdIommuNoIVRS"
>    },
> +  {
> +    "compare_mode": "string",
> +    "log_level": "LOG_LEVEL_MEDIUM",
> +    "pattern": "Unable to read/write to IOMMU perf counter",
> +    "advice": "AMD IOMMU performance counter is inaccessible and public specifications do not have information on how it should be supported",
> +    "label": "KlogAmdIommuPCNotSupported"
> +  },
>    {
>      "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/data/klog.json b/data/klog.json
index 15043658..cdb93554 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -2697,6 +2697,13 @@  atform Communications Channel Table (PCCT) and find the PCC subspace communicati
     "advice": "BIOS setup is configured to enable IOMMU, but BIOS lacks IVRS table that is describing which is the address of IOMMU",
     "label": "KlogAmdIommuNoIVRS"
   },
+  {
+    "compare_mode": "string",
+    "log_level": "LOG_LEVEL_MEDIUM",
+    "pattern": "Unable to read/write to IOMMU perf counter",
+    "advice": "AMD IOMMU performance counter is inaccessible and public specifications do not have information on how it should be supported",
+    "label": "KlogAmdIommuPCNotSupported"
+  },
   {
     "compare_mode": "string",
     "log_level": "LOG_LEVEL_HIGH",