diff mbox series

acpi: gpedump: ensure buf is set on default case

Message ID 20200407172531.920263-1-colin.king@canonical.com
State Accepted
Headers show
Series acpi: gpedump: ensure buf is set on default case | expand

Commit Message

Colin Ian King April 7, 2020, 5:25 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

There is no default case in the switch statement and Coverity is
complaining that buffer buf is not being initialized. Cater for this
unlikely eventuality.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/acpi/gpedump/gpedump.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Alex Hung April 7, 2020, 6:09 p.m. UTC | #1 
On 2020-04-07 11:25 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> There is no default case in the switch statement and Coverity is
> complaining that buffer buf is not being initialized. Cater for this
> unlikely eventuality.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/gpedump/gpedump.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/acpi/gpedump/gpedump.c b/src/acpi/gpedump/gpedump.c
> index 38e03149..faf69bdf 100644
> --- a/src/acpi/gpedump/gpedump.c
> +++ b/src/acpi/gpedump/gpedump.c
> @@ -85,6 +85,9 @@ static void gpu_dump_gpes(
>  				n++;
>  			snprintf(buf, sizeof(buf), "notifies %" PRIu32 " devices", n);
>  			break;
> +		default:
> +			strncpy(buf, "unknown", sizeof(buf));
> +			break;
>  		}
>  		fwts_log_info_verbatim(fw, "      GPE 0x%2.2" PRIx8 ":",
>  			gpe_block_info->BlockBaseNumber + gpe);
> 

Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu April 8, 2020, 6:43 a.m. UTC | #2 
On 4/8/20 1:25 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> There is no default case in the switch statement and Coverity is
> complaining that buffer buf is not being initialized. Cater for this
> unlikely eventuality.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpi/gpedump/gpedump.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/acpi/gpedump/gpedump.c b/src/acpi/gpedump/gpedump.c
> index 38e03149..faf69bdf 100644
> --- a/src/acpi/gpedump/gpedump.c
> +++ b/src/acpi/gpedump/gpedump.c
> @@ -85,6 +85,9 @@ static void gpu_dump_gpes(
>  				n++;
>  			snprintf(buf, sizeof(buf), "notifies %" PRIu32 " devices", n);
>  			break;
> +		default:
> +			strncpy(buf, "unknown", sizeof(buf));
> +			break;
>  		}
>  		fwts_log_info_verbatim(fw, "      GPE 0x%2.2" PRIx8 ":",
>  			gpe_block_info->BlockBaseNumber + gpe);
> 


Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/acpi/gpedump/gpedump.c b/src/acpi/gpedump/gpedump.c
index 38e03149..faf69bdf 100644
--- a/src/acpi/gpedump/gpedump.c
+++ b/src/acpi/gpedump/gpedump.c
@@ -85,6 +85,9 @@  static void gpu_dump_gpes(
 				n++;
 			snprintf(buf, sizeof(buf), "notifies %" PRIu32 " devices", n);
 			break;
+		default:
+			strncpy(buf, "unknown", sizeof(buf));
+			break;
 		}
 		fwts_log_info_verbatim(fw, "      GPE 0x%2.2" PRIx8 ":",
 			gpe_block_info->BlockBaseNumber + gpe);