diff mbox series

[4/4] dmicheck: update Memory Array Location (type 16)

Message ID 20200407005237.145347-5-alex.hung@canonical.com
State Accepted
Headers show
Series dmicheck: update contents in SMBIOS spec 3.3 | expand

Commit Message

Alex Hung April 7, 2020, 12:52 a.m. UTC
CXL Flexbus was added in SMBIOS spec 3.3

Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/dmi/dmicheck/dmicheck.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Colin Ian King April 7, 2020, 3:12 p.m. UTC | #1
On 07/04/2020 01:52, Alex Hung wrote:
> CXL Flexbus was added in SMBIOS spec 3.3
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index be206a8a..40b3374f 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1586,10 +1586,10 @@ static void dmicheck_entry(fwts_framework *fw,
>  			if (hdr->length < 0x0f)
>  				break;
>  			if (!(((data[0x4] >= 0x01) && (data[0x4] <= 0x0a)) ||
> -			      ((data[0x4] >= 0xa0) && (data[0x4] <= 0xa3))))
> +			      ((data[0x4] >= 0xa0) && (data[0x4] <= 0xa4))))
>  				fwts_failed(fw, LOG_LEVEL_HIGH, DMI_VALUE_OUT_OF_RANGE,
>  					"Out of range value 0x%2.2" PRIx8 " "
> -					"(range allowed 0x01..0x0a, 0xa0..0xa3) "
> +					"(range allowed 0x01..0x0a, 0xa0..0xa4) "
>  					"while accessing entry '%s' @ "
>  					"0x%8.8" PRIx32 ", field '%s', offset 0x%2.2x",
>  					data[0x4], table, addr, "Location", 0x4);
> 
Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu April 8, 2020, 6:41 a.m. UTC | #2
On 4/7/20 8:52 AM, Alex Hung wrote:
> CXL Flexbus was added in SMBIOS spec 3.3
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/dmi/dmicheck/dmicheck.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index be206a8a..40b3374f 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1586,10 +1586,10 @@ static void dmicheck_entry(fwts_framework *fw,
>  			if (hdr->length < 0x0f)
>  				break;
>  			if (!(((data[0x4] >= 0x01) && (data[0x4] <= 0x0a)) ||
> -			      ((data[0x4] >= 0xa0) && (data[0x4] <= 0xa3))))
> +			      ((data[0x4] >= 0xa0) && (data[0x4] <= 0xa4))))
>  				fwts_failed(fw, LOG_LEVEL_HIGH, DMI_VALUE_OUT_OF_RANGE,
>  					"Out of range value 0x%2.2" PRIx8 " "
> -					"(range allowed 0x01..0x0a, 0xa0..0xa3) "
> +					"(range allowed 0x01..0x0a, 0xa0..0xa4) "
>  					"while accessing entry '%s' @ "
>  					"0x%8.8" PRIx32 ", field '%s', offset 0x%2.2x",
>  					data[0x4], table, addr, "Location", 0x4);
> 


Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
index be206a8a..40b3374f 100644
--- a/src/dmi/dmicheck/dmicheck.c
+++ b/src/dmi/dmicheck/dmicheck.c
@@ -1586,10 +1586,10 @@  static void dmicheck_entry(fwts_framework *fw,
 			if (hdr->length < 0x0f)
 				break;
 			if (!(((data[0x4] >= 0x01) && (data[0x4] <= 0x0a)) ||
-			      ((data[0x4] >= 0xa0) && (data[0x4] <= 0xa3))))
+			      ((data[0x4] >= 0xa0) && (data[0x4] <= 0xa4))))
 				fwts_failed(fw, LOG_LEVEL_HIGH, DMI_VALUE_OUT_OF_RANGE,
 					"Out of range value 0x%2.2" PRIx8 " "
-					"(range allowed 0x01..0x0a, 0xa0..0xa3) "
+					"(range allowed 0x01..0x0a, 0xa0..0xa4) "
 					"while accessing entry '%s' @ "
 					"0x%8.8" PRIx32 ", field '%s', offset 0x%2.2x",
 					data[0x4], table, addr, "Location", 0x4);