diff mbox series

[2/2] fwts-test: disassemble-0001: sync output with updated ACPICA

Message ID 20181213171541.28766-3-colin.king@canonical.com
State Accepted
Headers show
Series ACPICA: Update to version 20181213 | expand

Commit Message

Colin Ian King Dec. 13, 2018, 5:15 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

The latest ACPICA 20181213 adds annotations to the GPE disassembly
such as "xx=0x00-0xFF", so we need to sync the changes back to the
test data output.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 fwts-test/disassemble-0001/DSDT0.dsl.original | 52 +++++++++----------
 1 file changed, 26 insertions(+), 26 deletions(-)

Comments

Ivan Hu Dec. 14, 2018, 9:01 a.m. UTC | #1
On 12/14/18 1:15 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The latest ACPICA 20181213 adds annotations to the GPE disassembly
> such as "xx=0x00-0xFF", so we need to sync the changes back to the
> test data output.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   fwts-test/disassemble-0001/DSDT0.dsl.original | 52 +++++++++----------
>   1 file changed, 26 insertions(+), 26 deletions(-)
> 
> diff --git a/fwts-test/disassemble-0001/DSDT0.dsl.original b/fwts-test/disassemble-0001/DSDT0.dsl.original
> index a67e0636..af8a2c5b 100644
> --- a/fwts-test/disassemble-0001/DSDT0.dsl.original
> +++ b/fwts-test/disassemble-0001/DSDT0.dsl.original
> @@ -1,11 +1,11 @@
>   /*
>    * Intel ACPI Component Architecture
> - * AML/ASL+ Disassembler version 20170531 (64-bit version)
> - * Copyright (c) 2000 - 2017 Intel Corporation
> + * AML/ASL+ Disassembler version 20181213 (64-bit version)
> + * Copyright (c) 2000 - 2018 Intel Corporation
>    *
>    * Disassembling to non-symbolic legacy ASL operators
>    *
> - * Disassembly of /tmp/fwts_tmp_table_11901_DSDT_2.dsl, Thu Jun  1 11:20:40 2017
> + * Disassembly of /tmp/fwts_tmp_table_26691_DSDT_2.dsl, Thu Dec 13 17:05:02 2018
>    *
>    * Original Table Header:
>    *     Signature        "DSDT"
> @@ -414,7 +414,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>       Name (VFN1, Zero)
>       Scope (_GPE)
>       {
> -        Method (_L01, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L01, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Add (L01C, One, L01C) /* \L01C */
>               P8XH (Zero, One)
> @@ -510,7 +510,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>               }
>           }
>   
> -        Method (_L02, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L02, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Store (Zero, GPEC) /* \GPEC */
>               If (\_SB.PCI0.LPCB.ECOK ())
> @@ -541,22 +541,22 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>               }
>           }
>   
> -        Method (_L03, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L03, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Notify (\_SB.PCI0.USB1, 0x02) // Device Wake
>           }
>   
> -        Method (_L04, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L04, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Notify (\_SB.PCI0.USB2, 0x02) // Device Wake
>           }
>   
> -        Method (_L05, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L05, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Notify (\_SB.PCI0.USB5, 0x02) // Device Wake
>           }
>   
> -        Method (_L06, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L06, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               If (\_SB.PCI0.GFX0.GSSE)
>               {
> @@ -568,7 +568,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>               }
>           }
>   
> -        Method (_L09, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L09, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               If (\_SB.PCI0.RP01.PSPX)
>               {
> @@ -613,17 +613,17 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>               }
>           }
>   
> -        Method (_L0B, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L0B, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Notify (\_SB.PCI0.PCIB, 0x02) // Device Wake
>           }
>   
> -        Method (_L0C, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L0C, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Notify (\_SB.PCI0.USB3, 0x02) // Device Wake
>           }
>   
> -        Method (_L0D, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L0D, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               If (\_SB.PCI0.EHC1.PMES)
>               {
> @@ -644,12 +644,12 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>               }
>           }
>   
> -        Method (_L0E, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L0E, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Notify (\_SB.PCI0.USB4, 0x02) // Device Wake
>           }
>   
> -        Method (_L1B, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L1B, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Not (LPOL, LPOL) /* \LPOL */
>               Notify (\_SB.LID0, 0x80) // Status Change
> @@ -5529,7 +5529,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>                           BTW1,   16
>                       }
>   
> -                    Method (_Q11, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q11, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store (0x87, P80H) /* \P80H */
>                           If (IGDS)
> @@ -5542,7 +5542,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>                           }
>                       }
>   
> -                    Method (_Q12, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q12, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store (0x86, P80H) /* \P80H */
>                           If (IGDS)
> @@ -5555,7 +5555,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>                           }
>                       }
>   
> -                    Method (_Q1C, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q1C, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_1C=====", Debug)
>                           If (VIDO)
> @@ -5573,19 +5573,19 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>                           }
>                       }
>   
> -                    Method (_Q1D, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q1D, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_1D=====", Debug)
>                           PCLK ()
>                       }
>   
> -                    Method (_Q1E, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q1E, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_1E=====", Debug)
>                           PCLK ()
>                       }
>   
> -                    Method (_Q25, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q25, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_25=====", Debug)
>                           Sleep (0x03E8)
> @@ -5594,7 +5594,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>                           Notify (^^BAT1, 0x80) // Status Change
>                       }
>   
> -                    Method (_Q34, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q34, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_34=====", Debug)
>                           If (BKEY)
> @@ -5604,7 +5604,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>                           }
>                       }
>   
> -                    Method (_Q37, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q37, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_37=====", Debug)
>                           Notify (ACAD, 0x80) // Status Change
> @@ -5612,7 +5612,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>                           Notify (^^BAT1, 0x80) // Status Change
>                       }
>   
> -                    Method (_Q38, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q38, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_38=====", Debug)
>                           Notify (ACAD, 0x80) // Status Change
> @@ -5620,14 +5620,14 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>                           Notify (^^BAT1, 0x80) // Status Change
>                       }
>   
> -                    Method (_Q2D, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q2D, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_2D=====", Debug)
>                           Store (Zero, DTSM) /* \DTSM */
>                           TRAP (0x46)
>                       }
>   
> -                    Method (_Q2E, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q2E, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_2E=====", Debug)
>                           Store (One, DTSM) /* \DTSM */
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
Alex Hung Dec. 17, 2018, 2:56 a.m. UTC | #2
On 2018-12-14 1:15 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The latest ACPICA 20181213 adds annotations to the GPE disassembly
> such as "xx=0x00-0xFF", so we need to sync the changes back to the
> test data output.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   fwts-test/disassemble-0001/DSDT0.dsl.original | 52 +++++++++----------
>   1 file changed, 26 insertions(+), 26 deletions(-)
> 
> diff --git a/fwts-test/disassemble-0001/DSDT0.dsl.original b/fwts-test/disassemble-0001/DSDT0.dsl.original
> index a67e0636..af8a2c5b 100644
> --- a/fwts-test/disassemble-0001/DSDT0.dsl.original
> +++ b/fwts-test/disassemble-0001/DSDT0.dsl.original
> @@ -1,11 +1,11 @@
>   /*
>    * Intel ACPI Component Architecture
> - * AML/ASL+ Disassembler version 20170531 (64-bit version)
> - * Copyright (c) 2000 - 2017 Intel Corporation
> + * AML/ASL+ Disassembler version 20181213 (64-bit version)
> + * Copyright (c) 2000 - 2018 Intel Corporation
>    *
>    * Disassembling to non-symbolic legacy ASL operators
>    *
> - * Disassembly of /tmp/fwts_tmp_table_11901_DSDT_2.dsl, Thu Jun  1 11:20:40 2017
> + * Disassembly of /tmp/fwts_tmp_table_26691_DSDT_2.dsl, Thu Dec 13 17:05:02 2018
>    *
>    * Original Table Header:
>    *     Signature        "DSDT"
> @@ -414,7 +414,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>       Name (VFN1, Zero)
>       Scope (_GPE)
>       {
> -        Method (_L01, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L01, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Add (L01C, One, L01C) /* \L01C */
>               P8XH (Zero, One)
> @@ -510,7 +510,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>               }
>           }
>   
> -        Method (_L02, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L02, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Store (Zero, GPEC) /* \GPEC */
>               If (\_SB.PCI0.LPCB.ECOK ())
> @@ -541,22 +541,22 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>               }
>           }
>   
> -        Method (_L03, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L03, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Notify (\_SB.PCI0.USB1, 0x02) // Device Wake
>           }
>   
> -        Method (_L04, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L04, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Notify (\_SB.PCI0.USB2, 0x02) // Device Wake
>           }
>   
> -        Method (_L05, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L05, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Notify (\_SB.PCI0.USB5, 0x02) // Device Wake
>           }
>   
> -        Method (_L06, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L06, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               If (\_SB.PCI0.GFX0.GSSE)
>               {
> @@ -568,7 +568,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>               }
>           }
>   
> -        Method (_L09, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L09, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               If (\_SB.PCI0.RP01.PSPX)
>               {
> @@ -613,17 +613,17 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>               }
>           }
>   
> -        Method (_L0B, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L0B, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Notify (\_SB.PCI0.PCIB, 0x02) // Device Wake
>           }
>   
> -        Method (_L0C, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L0C, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Notify (\_SB.PCI0.USB3, 0x02) // Device Wake
>           }
>   
> -        Method (_L0D, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L0D, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               If (\_SB.PCI0.EHC1.PMES)
>               {
> @@ -644,12 +644,12 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>               }
>           }
>   
> -        Method (_L0E, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L0E, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Notify (\_SB.PCI0.USB4, 0x02) // Device Wake
>           }
>   
> -        Method (_L1B, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
> +        Method (_L1B, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
>           {
>               Not (LPOL, LPOL) /* \LPOL */
>               Notify (\_SB.LID0, 0x80) // Status Change
> @@ -5529,7 +5529,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>                           BTW1,   16
>                       }
>   
> -                    Method (_Q11, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q11, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store (0x87, P80H) /* \P80H */
>                           If (IGDS)
> @@ -5542,7 +5542,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>                           }
>                       }
>   
> -                    Method (_Q12, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q12, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store (0x86, P80H) /* \P80H */
>                           If (IGDS)
> @@ -5555,7 +5555,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>                           }
>                       }
>   
> -                    Method (_Q1C, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q1C, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_1C=====", Debug)
>                           If (VIDO)
> @@ -5573,19 +5573,19 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>                           }
>                       }
>   
> -                    Method (_Q1D, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q1D, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_1D=====", Debug)
>                           PCLK ()
>                       }
>   
> -                    Method (_Q1E, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q1E, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_1E=====", Debug)
>                           PCLK ()
>                       }
>   
> -                    Method (_Q25, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q25, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_25=====", Debug)
>                           Sleep (0x03E8)
> @@ -5594,7 +5594,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>                           Notify (^^BAT1, 0x80) // Status Change
>                       }
>   
> -                    Method (_Q34, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q34, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_34=====", Debug)
>                           If (BKEY)
> @@ -5604,7 +5604,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>                           }
>                       }
>   
> -                    Method (_Q37, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q37, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_37=====", Debug)
>                           Notify (ACAD, 0x80) // Status Change
> @@ -5612,7 +5612,7 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>                           Notify (^^BAT1, 0x80) // Status Change
>                       }
>   
> -                    Method (_Q38, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q38, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_38=====", Debug)
>                           Notify (ACAD, 0x80) // Status Change
> @@ -5620,14 +5620,14 @@ DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
>                           Notify (^^BAT1, 0x80) // Status Change
>                       }
>   
> -                    Method (_Q2D, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q2D, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_2D=====", Debug)
>                           Store (Zero, DTSM) /* \DTSM */
>                           TRAP (0x46)
>                       }
>   
> -                    Method (_Q2E, 0, NotSerialized)  // _Qxx: EC Query
> +                    Method (_Q2E, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
>                       {
>                           Store ("=====QUERY_2E=====", Debug)
>                           Store (One, DTSM) /* \DTSM */
> 

Acked-by: Alex Hung <alex.hung@canonical.com>
diff mbox series

Patch

diff --git a/fwts-test/disassemble-0001/DSDT0.dsl.original b/fwts-test/disassemble-0001/DSDT0.dsl.original
index a67e0636..af8a2c5b 100644
--- a/fwts-test/disassemble-0001/DSDT0.dsl.original
+++ b/fwts-test/disassemble-0001/DSDT0.dsl.original
@@ -1,11 +1,11 @@ 
 /*
  * Intel ACPI Component Architecture
- * AML/ASL+ Disassembler version 20170531 (64-bit version)
- * Copyright (c) 2000 - 2017 Intel Corporation
+ * AML/ASL+ Disassembler version 20181213 (64-bit version)
+ * Copyright (c) 2000 - 2018 Intel Corporation
  * 
  * Disassembling to non-symbolic legacy ASL operators
  *
- * Disassembly of /tmp/fwts_tmp_table_11901_DSDT_2.dsl, Thu Jun  1 11:20:40 2017
+ * Disassembly of /tmp/fwts_tmp_table_26691_DSDT_2.dsl, Thu Dec 13 17:05:02 2018
  *
  * Original Table Header:
  *     Signature        "DSDT"
@@ -414,7 +414,7 @@  DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
     Name (VFN1, Zero)
     Scope (_GPE)
     {
-        Method (_L01, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
+        Method (_L01, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
         {
             Add (L01C, One, L01C) /* \L01C */
             P8XH (Zero, One)
@@ -510,7 +510,7 @@  DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
             }
         }
 
-        Method (_L02, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
+        Method (_L02, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
         {
             Store (Zero, GPEC) /* \GPEC */
             If (\_SB.PCI0.LPCB.ECOK ())
@@ -541,22 +541,22 @@  DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
             }
         }
 
-        Method (_L03, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
+        Method (_L03, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
         {
             Notify (\_SB.PCI0.USB1, 0x02) // Device Wake
         }
 
-        Method (_L04, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
+        Method (_L04, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
         {
             Notify (\_SB.PCI0.USB2, 0x02) // Device Wake
         }
 
-        Method (_L05, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
+        Method (_L05, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
         {
             Notify (\_SB.PCI0.USB5, 0x02) // Device Wake
         }
 
-        Method (_L06, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
+        Method (_L06, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
         {
             If (\_SB.PCI0.GFX0.GSSE)
             {
@@ -568,7 +568,7 @@  DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
             }
         }
 
-        Method (_L09, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
+        Method (_L09, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
         {
             If (\_SB.PCI0.RP01.PSPX)
             {
@@ -613,17 +613,17 @@  DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
             }
         }
 
-        Method (_L0B, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
+        Method (_L0B, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
         {
             Notify (\_SB.PCI0.PCIB, 0x02) // Device Wake
         }
 
-        Method (_L0C, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
+        Method (_L0C, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
         {
             Notify (\_SB.PCI0.USB3, 0x02) // Device Wake
         }
 
-        Method (_L0D, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
+        Method (_L0D, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
         {
             If (\_SB.PCI0.EHC1.PMES)
             {
@@ -644,12 +644,12 @@  DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
             }
         }
 
-        Method (_L0E, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
+        Method (_L0E, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
         {
             Notify (\_SB.PCI0.USB4, 0x02) // Device Wake
         }
 
-        Method (_L1B, 0, NotSerialized)  // _Lxx: Level-Triggered GPE
+        Method (_L1B, 0, NotSerialized)  // _Lxx: Level-Triggered GPE, xx=0x00-0xFF
         {
             Not (LPOL, LPOL) /* \LPOL */
             Notify (\_SB.LID0, 0x80) // Status Change
@@ -5529,7 +5529,7 @@  DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
                         BTW1,   16
                     }
 
-                    Method (_Q11, 0, NotSerialized)  // _Qxx: EC Query
+                    Method (_Q11, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
                     {
                         Store (0x87, P80H) /* \P80H */
                         If (IGDS)
@@ -5542,7 +5542,7 @@  DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
                         }
                     }
 
-                    Method (_Q12, 0, NotSerialized)  // _Qxx: EC Query
+                    Method (_Q12, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
                     {
                         Store (0x86, P80H) /* \P80H */
                         If (IGDS)
@@ -5555,7 +5555,7 @@  DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
                         }
                     }
 
-                    Method (_Q1C, 0, NotSerialized)  // _Qxx: EC Query
+                    Method (_Q1C, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
                     {
                         Store ("=====QUERY_1C=====", Debug)
                         If (VIDO)
@@ -5573,19 +5573,19 @@  DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
                         }
                     }
 
-                    Method (_Q1D, 0, NotSerialized)  // _Qxx: EC Query
+                    Method (_Q1D, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
                     {
                         Store ("=====QUERY_1D=====", Debug)
                         PCLK ()
                     }
 
-                    Method (_Q1E, 0, NotSerialized)  // _Qxx: EC Query
+                    Method (_Q1E, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
                     {
                         Store ("=====QUERY_1E=====", Debug)
                         PCLK ()
                     }
 
-                    Method (_Q25, 0, NotSerialized)  // _Qxx: EC Query
+                    Method (_Q25, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
                     {
                         Store ("=====QUERY_25=====", Debug)
                         Sleep (0x03E8)
@@ -5594,7 +5594,7 @@  DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
                         Notify (^^BAT1, 0x80) // Status Change
                     }
 
-                    Method (_Q34, 0, NotSerialized)  // _Qxx: EC Query
+                    Method (_Q34, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
                     {
                         Store ("=====QUERY_34=====", Debug)
                         If (BKEY)
@@ -5604,7 +5604,7 @@  DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
                         }
                     }
 
-                    Method (_Q37, 0, NotSerialized)  // _Qxx: EC Query
+                    Method (_Q37, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
                     {
                         Store ("=====QUERY_37=====", Debug)
                         Notify (ACAD, 0x80) // Status Change
@@ -5612,7 +5612,7 @@  DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
                         Notify (^^BAT1, 0x80) // Status Change
                     }
 
-                    Method (_Q38, 0, NotSerialized)  // _Qxx: EC Query
+                    Method (_Q38, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
                     {
                         Store ("=====QUERY_38=====", Debug)
                         Notify (ACAD, 0x80) // Status Change
@@ -5620,14 +5620,14 @@  DefinitionBlock ("", "DSDT", 2, "TOSCPL", "CRESTLNE", 0x06040000)
                         Notify (^^BAT1, 0x80) // Status Change
                     }
 
-                    Method (_Q2D, 0, NotSerialized)  // _Qxx: EC Query
+                    Method (_Q2D, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
                     {
                         Store ("=====QUERY_2D=====", Debug)
                         Store (Zero, DTSM) /* \DTSM */
                         TRAP (0x46)
                     }
 
-                    Method (_Q2E, 0, NotSerialized)  // _Qxx: EC Query
+                    Method (_Q2E, 0, NotSerialized)  // _Qxx: EC Query, xx=0x00-0xFF
                     {
                         Store ("=====QUERY_2E=====", Debug)
                         Store (One, DTSM) /* \DTSM */