Message ID | 20181006105732.21366-2-colin.king@canonical.com |
---|---|
State | Accepted |
Headers | show |
Series | update to ACPICA 20181003 | expand |
On 10/06/2018 06:57 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > changes in this release of ACPICA are detailed at the following > link on the ACPICA developer mailing list: > > https://lists.acpica.org/pipermail/devel/2018-October/001825.html > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/acpica/source/compiler/aslmessages.c | 3 ++- > src/acpica/source/compiler/aslmessages.h | 1 + > src/acpica/source/compiler/aslopt.c | 1 - > src/acpica/source/compiler/asltransform.c | 10 ++++++++++ > src/acpica/source/components/executer/exserial.c | 0 > src/acpica/source/include/acpixf.h | 2 +- > 6 files changed, 14 insertions(+), 3 deletions(-) > mode change 100755 => 100644 src/acpica/source/components/executer/exserial.c > > diff --git a/src/acpica/source/compiler/aslmessages.c b/src/acpica/source/compiler/aslmessages.c > index efa58cb5..14e140b2 100644 > --- a/src/acpica/source/compiler/aslmessages.c > +++ b/src/acpica/source/compiler/aslmessages.c > @@ -358,7 +358,8 @@ const char *AslCompilerMsgs [] = > /* ASL_MSG_OEM_TABLE_ID */ "Invalid OEM Table ID", > /* ASL_MSG_OEM_ID */ "Invalid OEM ID", > /* ASL_MSG_UNLOAD */ "Unload is not supported by all operating systems", > -/* ASL_MSG_OFFSET */ "Unnecessary/redundant use of Offset operator" > +/* ASL_MSG_OFFSET */ "Unnecessary/redundant use of Offset operator", > +/* ASL_MSG_LONG_SLEEP */ "Very long Sleep, greater than 1 second" > }; > > /* Table compiler */ > diff --git a/src/acpica/source/compiler/aslmessages.h b/src/acpica/source/compiler/aslmessages.h > index 5030a817..907744a2 100644 > --- a/src/acpica/source/compiler/aslmessages.h > +++ b/src/acpica/source/compiler/aslmessages.h > @@ -361,6 +361,7 @@ typedef enum > ASL_MSG_OEM_ID, > ASL_MSG_UNLOAD, > ASL_MSG_OFFSET, > + ASL_MSG_LONG_SLEEP, > > /* These messages are used by the Data Table compiler only */ > > diff --git a/src/acpica/source/compiler/aslopt.c b/src/acpica/source/compiler/aslopt.c > index 4e53a4b0..0f5ce5fd 100644 > --- a/src/acpica/source/compiler/aslopt.c > +++ b/src/acpica/source/compiler/aslopt.c > @@ -522,7 +522,6 @@ OptBuildShortestPath ( > > Cleanup: > > - ACPI_FREE (NewPathExternal); > return (Status); > } > > diff --git a/src/acpica/source/compiler/asltransform.c b/src/acpica/source/compiler/asltransform.c > index 3249e367..324b0364 100644 > --- a/src/acpica/source/compiler/asltransform.c > +++ b/src/acpica/source/compiler/asltransform.c > @@ -501,6 +501,16 @@ TrTransformSubtree ( > AslError (ASL_WARNING, ASL_MSG_UNLOAD, Op, NULL); > break; > > + case PARSEOP_SLEEP: > + > + /* Remark for very long sleep values */ > + > + if (Op->Asl.Child->Asl.Value.Integer > 1000) > + { > + AslError (ASL_REMARK, ASL_MSG_LONG_SLEEP, Op, NULL); > + } > + break; > + > default: > > /* Nothing to do here for other opcodes */ > diff --git a/src/acpica/source/components/executer/exserial.c b/src/acpica/source/components/executer/exserial.c > old mode 100755 > new mode 100644 > diff --git a/src/acpica/source/include/acpixf.h b/src/acpica/source/include/acpixf.h > index ea92eb46..aaf284cb 100644 > --- a/src/acpica/source/include/acpixf.h > +++ b/src/acpica/source/include/acpixf.h > @@ -154,7 +154,7 @@ > > /* Current ACPICA subsystem version in YYYYMMDD format */ > > -#define ACPI_CA_VERSION 0x20180927 > +#define ACPI_CA_VERSION 0x20181003 > > #include "acconfig.h" > #include "actypes.h" Acked-by: Ivan Hu <ivan.hu@canonical.com>
On 2018-10-06 06:57 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > changes in this release of ACPICA are detailed at the following > link on the ACPICA developer mailing list: > > https://lists.acpica.org/pipermail/devel/2018-October/001825.html > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/acpica/source/compiler/aslmessages.c | 3 ++- > src/acpica/source/compiler/aslmessages.h | 1 + > src/acpica/source/compiler/aslopt.c | 1 - > src/acpica/source/compiler/asltransform.c | 10 ++++++++++ > src/acpica/source/components/executer/exserial.c | 0 > src/acpica/source/include/acpixf.h | 2 +- > 6 files changed, 14 insertions(+), 3 deletions(-) > mode change 100755 => 100644 src/acpica/source/components/executer/exserial.c > > diff --git a/src/acpica/source/compiler/aslmessages.c b/src/acpica/source/compiler/aslmessages.c > index efa58cb5..14e140b2 100644 > --- a/src/acpica/source/compiler/aslmessages.c > +++ b/src/acpica/source/compiler/aslmessages.c > @@ -358,7 +358,8 @@ const char *AslCompilerMsgs [] = > /* ASL_MSG_OEM_TABLE_ID */ "Invalid OEM Table ID", > /* ASL_MSG_OEM_ID */ "Invalid OEM ID", > /* ASL_MSG_UNLOAD */ "Unload is not supported by all operating systems", > -/* ASL_MSG_OFFSET */ "Unnecessary/redundant use of Offset operator" > +/* ASL_MSG_OFFSET */ "Unnecessary/redundant use of Offset operator", > +/* ASL_MSG_LONG_SLEEP */ "Very long Sleep, greater than 1 second" > }; > > /* Table compiler */ > diff --git a/src/acpica/source/compiler/aslmessages.h b/src/acpica/source/compiler/aslmessages.h > index 5030a817..907744a2 100644 > --- a/src/acpica/source/compiler/aslmessages.h > +++ b/src/acpica/source/compiler/aslmessages.h > @@ -361,6 +361,7 @@ typedef enum > ASL_MSG_OEM_ID, > ASL_MSG_UNLOAD, > ASL_MSG_OFFSET, > + ASL_MSG_LONG_SLEEP, > > /* These messages are used by the Data Table compiler only */ > > diff --git a/src/acpica/source/compiler/aslopt.c b/src/acpica/source/compiler/aslopt.c > index 4e53a4b0..0f5ce5fd 100644 > --- a/src/acpica/source/compiler/aslopt.c > +++ b/src/acpica/source/compiler/aslopt.c > @@ -522,7 +522,6 @@ OptBuildShortestPath ( > > Cleanup: > > - ACPI_FREE (NewPathExternal); > return (Status); > } > > diff --git a/src/acpica/source/compiler/asltransform.c b/src/acpica/source/compiler/asltransform.c > index 3249e367..324b0364 100644 > --- a/src/acpica/source/compiler/asltransform.c > +++ b/src/acpica/source/compiler/asltransform.c > @@ -501,6 +501,16 @@ TrTransformSubtree ( > AslError (ASL_WARNING, ASL_MSG_UNLOAD, Op, NULL); > break; > > + case PARSEOP_SLEEP: > + > + /* Remark for very long sleep values */ > + > + if (Op->Asl.Child->Asl.Value.Integer > 1000) > + { > + AslError (ASL_REMARK, ASL_MSG_LONG_SLEEP, Op, NULL); > + } > + break; > + > default: > > /* Nothing to do here for other opcodes */ > diff --git a/src/acpica/source/components/executer/exserial.c b/src/acpica/source/components/executer/exserial.c > old mode 100755 > new mode 100644 > diff --git a/src/acpica/source/include/acpixf.h b/src/acpica/source/include/acpixf.h > index ea92eb46..aaf284cb 100644 > --- a/src/acpica/source/include/acpixf.h > +++ b/src/acpica/source/include/acpixf.h > @@ -154,7 +154,7 @@ > > /* Current ACPICA subsystem version in YYYYMMDD format */ > > -#define ACPI_CA_VERSION 0x20180927 > +#define ACPI_CA_VERSION 0x20181003 > > #include "acconfig.h" > #include "actypes.h" > Acked-by: Alex Hung <alex.hung@canonical.com>
diff --git a/src/acpica/source/compiler/aslmessages.c b/src/acpica/source/compiler/aslmessages.c index efa58cb5..14e140b2 100644 --- a/src/acpica/source/compiler/aslmessages.c +++ b/src/acpica/source/compiler/aslmessages.c @@ -358,7 +358,8 @@ const char *AslCompilerMsgs [] = /* ASL_MSG_OEM_TABLE_ID */ "Invalid OEM Table ID", /* ASL_MSG_OEM_ID */ "Invalid OEM ID", /* ASL_MSG_UNLOAD */ "Unload is not supported by all operating systems", -/* ASL_MSG_OFFSET */ "Unnecessary/redundant use of Offset operator" +/* ASL_MSG_OFFSET */ "Unnecessary/redundant use of Offset operator", +/* ASL_MSG_LONG_SLEEP */ "Very long Sleep, greater than 1 second" }; /* Table compiler */ diff --git a/src/acpica/source/compiler/aslmessages.h b/src/acpica/source/compiler/aslmessages.h index 5030a817..907744a2 100644 --- a/src/acpica/source/compiler/aslmessages.h +++ b/src/acpica/source/compiler/aslmessages.h @@ -361,6 +361,7 @@ typedef enum ASL_MSG_OEM_ID, ASL_MSG_UNLOAD, ASL_MSG_OFFSET, + ASL_MSG_LONG_SLEEP, /* These messages are used by the Data Table compiler only */ diff --git a/src/acpica/source/compiler/aslopt.c b/src/acpica/source/compiler/aslopt.c index 4e53a4b0..0f5ce5fd 100644 --- a/src/acpica/source/compiler/aslopt.c +++ b/src/acpica/source/compiler/aslopt.c @@ -522,7 +522,6 @@ OptBuildShortestPath ( Cleanup: - ACPI_FREE (NewPathExternal); return (Status); } diff --git a/src/acpica/source/compiler/asltransform.c b/src/acpica/source/compiler/asltransform.c index 3249e367..324b0364 100644 --- a/src/acpica/source/compiler/asltransform.c +++ b/src/acpica/source/compiler/asltransform.c @@ -501,6 +501,16 @@ TrTransformSubtree ( AslError (ASL_WARNING, ASL_MSG_UNLOAD, Op, NULL); break; + case PARSEOP_SLEEP: + + /* Remark for very long sleep values */ + + if (Op->Asl.Child->Asl.Value.Integer > 1000) + { + AslError (ASL_REMARK, ASL_MSG_LONG_SLEEP, Op, NULL); + } + break; + default: /* Nothing to do here for other opcodes */ diff --git a/src/acpica/source/components/executer/exserial.c b/src/acpica/source/components/executer/exserial.c old mode 100755 new mode 100644 diff --git a/src/acpica/source/include/acpixf.h b/src/acpica/source/include/acpixf.h index ea92eb46..aaf284cb 100644 --- a/src/acpica/source/include/acpixf.h +++ b/src/acpica/source/include/acpixf.h @@ -154,7 +154,7 @@ /* Current ACPICA subsystem version in YYYYMMDD format */ -#define ACPI_CA_VERSION 0x20180927 +#define ACPI_CA_VERSION 0x20181003 #include "acconfig.h" #include "actypes.h"