diff mbox series

uefi: uefidump: make array uefidump_info_table const

Message ID 20170904130703.12844-1-colin.king@canonical.com
State Accepted
Headers show
Series uefi: uefidump: make array uefidump_info_table const | expand

Commit Message

Colin Ian King Sept. 4, 2017, 1:07 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

Array uefidump_info_table is static and read-only so make it
also const

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/uefi/uefidump/uefidump.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Alex Hung Sept. 5, 2017, 5:31 a.m. UTC | #1
On 2017-09-04 06:07 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Array uefidump_info_table is static and read-only so make it
> also const
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/uefi/uefidump/uefidump.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c
> index 305d2d6a..c4c44b1a 100644
> --- a/src/uefi/uefidump/uefidump.c
> +++ b/src/uefi/uefidump/uefidump.c
> @@ -1379,7 +1379,7 @@ static void uefidump_info_syspreporder(fwts_framework *fw, fwts_uefi_var *var)
>   	free(str);
>   }
>   
> -static uefidump_info uefidump_info_table[] = {
> +static const uefidump_info uefidump_info_table[] = {
>   	{ "PlatformLangCodes",	uefidump_info_platform_langcodes },
>   	{ "PlatformLang",	uefidump_info_platform_lang },
>   	{ "BootOptionSupport", 	uefidump_info_bootoptionsupport },
> @@ -1420,7 +1420,7 @@ static void uefidump_var(fwts_framework *fw, fwts_uefi_var *var)
>   {
>   	char varname[512];
>   	char guid_str[37];
> -	uefidump_info *info;
> +	const uefidump_info *info;
>   
>   	fwts_uefi_get_varname(varname, sizeof(varname), var);
>   
> 

Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu Sept. 6, 2017, 8:21 a.m. UTC | #2
On 09/04/2017 09:07 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Array uefidump_info_table is static and read-only so make it
> also const
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   src/uefi/uefidump/uefidump.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c
> index 305d2d6a..c4c44b1a 100644
> --- a/src/uefi/uefidump/uefidump.c
> +++ b/src/uefi/uefidump/uefidump.c
> @@ -1379,7 +1379,7 @@ static void uefidump_info_syspreporder(fwts_framework *fw, fwts_uefi_var *var)
>   	free(str);
>   }
>   
> -static uefidump_info uefidump_info_table[] = {
> +static const uefidump_info uefidump_info_table[] = {
>   	{ "PlatformLangCodes",	uefidump_info_platform_langcodes },
>   	{ "PlatformLang",	uefidump_info_platform_lang },
>   	{ "BootOptionSupport", 	uefidump_info_bootoptionsupport },
> @@ -1420,7 +1420,7 @@ static void uefidump_var(fwts_framework *fw, fwts_uefi_var *var)
>   {
>   	char varname[512];
>   	char guid_str[37];
> -	uefidump_info *info;
> +	const uefidump_info *info;
>   
>   	fwts_uefi_get_varname(varname, sizeof(varname), var);
>   
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox series

Patch

diff --git a/src/uefi/uefidump/uefidump.c b/src/uefi/uefidump/uefidump.c
index 305d2d6a..c4c44b1a 100644
--- a/src/uefi/uefidump/uefidump.c
+++ b/src/uefi/uefidump/uefidump.c
@@ -1379,7 +1379,7 @@  static void uefidump_info_syspreporder(fwts_framework *fw, fwts_uefi_var *var)
 	free(str);
 }
 
-static uefidump_info uefidump_info_table[] = {
+static const uefidump_info uefidump_info_table[] = {
 	{ "PlatformLangCodes",	uefidump_info_platform_langcodes },
 	{ "PlatformLang",	uefidump_info_platform_lang },
 	{ "BootOptionSupport", 	uefidump_info_bootoptionsupport },
@@ -1420,7 +1420,7 @@  static void uefidump_var(fwts_framework *fw, fwts_uefi_var *var)
 {
 	char varname[512];
 	char guid_str[37];
-	uefidump_info *info;
+	const uefidump_info *info;
 
 	fwts_uefi_get_varname(varname, sizeof(varname), var);